mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets
synced 2024-12-19 18:30:33 +00:00
fce6fdfb20
== What ==
* Remove the empty Gadget and Gadget_definition namespaces.
* Remove the "gadgets-definition-edit" user right.
* Remove need for custom namespace permissions that previously
had to extend editsitejs to apply to NS_GADGET.
== Why ==
Simplify the (unused) "GadgetDefinitionNamespaceRepo" backend for
Gadgets 2.0 by making it less radically different from the status quo.
The experimental 2.0 branch will now make use of the "gadget definition"
content model via "MediaWiki:Gadgets/<id>.json" pages, instead of
through a dedicated namespace.
When I first worked the Gadgets 2.0 branch, content models
were not a thing in MediaWiki, and interface-admin wasn't a thing yet
either. Now that we have per-page permissions and per-page content
models, we don't really need a separate namespace.
This follows the principle of least surprise, and fits well with other
interface admin and site configuration tools such as:
- Citoid, MediaWiki:Citoid-template-type-map.json,
- VisualEditor, MediaWiki:Visualeditor-template-tools-definition.json,
- AbuseFilter, MediaWiki:BlockedExternalDomains.json,
- the upcoming "Community Config" initiative.
If/when we develop the SpecialPage GUI for editing gadget definitions,
this can save its data to these pages the same as it would in
any other namespace. Similar to how Special:BlockedExternalDomains
operates on MediaWiki:BlockedExternalDomains.json.
See also bf1d6b3e93
(I6ffd5e9467), which recently removed the
gadgets-edit user right in favour of the editsite{css,js,json} rights.
Change-Id: I5b04ab251552e839087d0a8a6923d205adc7f771
256 lines
7.4 KiB
PHP
256 lines
7.4 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Extension\Gadgets;
|
|
|
|
use InvalidArgumentException;
|
|
use MediaWiki\Linker\LinkTarget;
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Title\Title;
|
|
use Message;
|
|
|
|
abstract class GadgetRepo {
|
|
|
|
/**
|
|
* @var GadgetRepo|null
|
|
*/
|
|
private static $instance;
|
|
|
|
/** @internal */
|
|
public const RESOURCE_TITLE_PREFIX = 'MediaWiki:Gadget-';
|
|
|
|
/**
|
|
* Get the ids of the gadgets provided by this repository
|
|
*
|
|
* It's possible this could be out of sync with what
|
|
* getGadget() will return due to caching
|
|
*
|
|
* @return string[]
|
|
*/
|
|
abstract public function getGadgetIds(): array;
|
|
|
|
/**
|
|
* Get the Gadget object for a given gadget ID
|
|
*
|
|
* @param string $id
|
|
* @return Gadget
|
|
* @throws InvalidArgumentException For unregistered ID, used by getStructuredList()
|
|
*/
|
|
abstract public function getGadget( string $id ): Gadget;
|
|
|
|
/**
|
|
* Invalidate any caches based on the provided page (after create, edit, or delete).
|
|
*
|
|
* This must be called on create and delete as well (T39228).
|
|
*
|
|
* @param LinkTarget $target
|
|
* @return void
|
|
*/
|
|
public function handlePageUpdate( LinkTarget $target ): void {
|
|
}
|
|
|
|
/**
|
|
* Given a gadget ID, return the title of the page where the gadget is
|
|
* defined (or null if the given repo does not have per-gadget definition
|
|
* pages).
|
|
*
|
|
* @param string $id
|
|
* @return Title|null
|
|
*/
|
|
public function getGadgetDefinitionTitle( string $id ): ?Title {
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* Get a lists of Gadget objects by category
|
|
*
|
|
* @return array<string,Gadget[]> `[ 'category' => [ 'name' => $gadget ] ]`
|
|
*/
|
|
public function getStructuredList() {
|
|
$list = [];
|
|
foreach ( $this->getGadgetIds() as $id ) {
|
|
try {
|
|
$gadget = $this->getGadget( $id );
|
|
} catch ( InvalidArgumentException $e ) {
|
|
continue;
|
|
}
|
|
$list[$gadget->getCategory()][$gadget->getName()] = $gadget;
|
|
}
|
|
|
|
return $list;
|
|
}
|
|
|
|
/**
|
|
* Get the page name without "MediaWiki:Gadget-" prefix.
|
|
*
|
|
* This name is used by `mw.loader.require()` so that `require("./example.json")` resolves
|
|
* to `MediaWiki:Gadget-example.json`.
|
|
*
|
|
* @param string $titleText
|
|
* @return string
|
|
*/
|
|
public function titleWithoutPrefix( string $titleText ): string {
|
|
$numReplaces = 1; // there will only one occurrence of the prefix
|
|
return str_replace( self::RESOURCE_TITLE_PREFIX, '', $titleText, $numReplaces );
|
|
}
|
|
|
|
/**
|
|
* @param Gadget $gadget
|
|
* @return Message[]
|
|
*/
|
|
public function validationWarnings( Gadget $gadget ): array {
|
|
// Basic checks local to the gadget definition
|
|
$warningMsgKeys = $gadget->getValidationWarnings();
|
|
$warnings = array_map( static function ( $warningMsgKey ) {
|
|
return wfMessage( $warningMsgKey );
|
|
}, $warningMsgKeys );
|
|
|
|
// Check for invalid values in skins, rights, namespaces, and contentModels
|
|
$this->checkInvalidLoadConditions( $gadget, 'skins', $warnings );
|
|
$this->checkInvalidLoadConditions( $gadget, 'rights', $warnings );
|
|
$this->checkInvalidLoadConditions( $gadget, 'namespaces', $warnings );
|
|
$this->checkInvalidLoadConditions( $gadget, 'contentModels', $warnings );
|
|
|
|
// Peer gadgets not being styles-only gadgets, or not being defined at all
|
|
foreach ( $gadget->getPeers() as $peer ) {
|
|
try {
|
|
$peerGadget = $this->getGadget( $peer );
|
|
if ( $peerGadget->getType() !== 'styles' ) {
|
|
$warnings[] = wfMessage( "gadgets-validate-invalidpeer", $peer );
|
|
}
|
|
} catch ( InvalidArgumentException $ex ) {
|
|
$warnings[] = wfMessage( "gadgets-validate-nopeer", $peer );
|
|
}
|
|
}
|
|
|
|
// Check that the gadget pages exist and are of the right content model
|
|
$warnings = array_merge(
|
|
$warnings,
|
|
$this->checkTitles( $gadget->getScripts(), CONTENT_MODEL_JAVASCRIPT,
|
|
"gadgets-validate-invalidjs" ),
|
|
$this->checkTitles( $gadget->getStyles(), CONTENT_MODEL_CSS,
|
|
"gadgets-validate-invalidcss" ),
|
|
$this->checkTitles( $gadget->getJSONs(), CONTENT_MODEL_JSON,
|
|
"gadgets-validate-invalidjson" )
|
|
);
|
|
|
|
return $warnings;
|
|
}
|
|
|
|
/**
|
|
* Check titles used in gadget to verify existence and correct content model.
|
|
* @param array $pages
|
|
* @param string $expectedContentModel
|
|
* @param string $msg
|
|
* @return Message[]
|
|
*/
|
|
private function checkTitles( array $pages, string $expectedContentModel, string $msg ): array {
|
|
$warnings = [];
|
|
foreach ( $pages as $pageName ) {
|
|
$title = Title::newFromText( $pageName );
|
|
if ( !$title ) {
|
|
$warnings[] = wfMessage( "gadgets-validate-invalidtitle", $pageName );
|
|
continue;
|
|
}
|
|
if ( !$title->exists() ) {
|
|
$warnings[] = wfMessage( "gadgets-validate-nopage", $pageName );
|
|
continue;
|
|
}
|
|
$contentModel = $title->getContentModel();
|
|
if ( $contentModel !== $expectedContentModel ) {
|
|
$warnings[] = wfMessage( $msg, $pageName, $contentModel );
|
|
}
|
|
}
|
|
return $warnings;
|
|
}
|
|
|
|
/**
|
|
* @param Gadget $gadget
|
|
* @param string $condition
|
|
* @param Message[] &$warnings
|
|
*/
|
|
private function checkInvalidLoadConditions( Gadget $gadget, string $condition, array &$warnings ) {
|
|
switch ( $condition ) {
|
|
case 'skins':
|
|
$allSkins = array_keys( MediaWikiServices::getInstance()->getSkinFactory()->getInstalledSkins() );
|
|
$this->maybeAddWarnings( $gadget->getRequiredSkins(),
|
|
static function ( $skin ) use ( $allSkins ) {
|
|
return !in_array( $skin, $allSkins, true );
|
|
}, $warnings, "gadgets-validate-invalidskins" );
|
|
break;
|
|
|
|
case 'rights':
|
|
$allPerms = MediaWikiServices::getInstance()->getPermissionManager()->getAllPermissions();
|
|
$this->maybeAddWarnings( $gadget->getRequiredRights(),
|
|
static function ( $right ) use ( $allPerms ) {
|
|
return !in_array( $right, $allPerms, true );
|
|
}, $warnings, "gadgets-validate-invalidrights" );
|
|
break;
|
|
|
|
case 'namespaces':
|
|
$nsInfo = MediaWikiServices::getInstance()->getNamespaceInfo();
|
|
$this->maybeAddWarnings( $gadget->getRequiredNamespaces(),
|
|
static function ( $ns ) use ( $nsInfo ) {
|
|
return !$nsInfo->exists( $ns );
|
|
}, $warnings, "gadgets-validate-invalidnamespaces"
|
|
);
|
|
break;
|
|
|
|
case 'contentModels':
|
|
$contentHandlerFactory = MediaWikiServices::getInstance()->getContentHandlerFactory();
|
|
$this->maybeAddWarnings( $gadget->getRequiredContentModels(),
|
|
static function ( $model ) use ( $contentHandlerFactory ) {
|
|
return !$contentHandlerFactory->isDefinedModel( $model );
|
|
}, $warnings, "gadgets-validate-invalidcontentmodels"
|
|
);
|
|
break;
|
|
default:
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Iterate over the given $entries, for each check if it is invalid using $isInvalid predicate,
|
|
* and if so add the $message to $warnings.
|
|
*
|
|
* @param array $entries
|
|
* @param callable $isInvalid
|
|
* @param array &$warnings
|
|
* @param string $message
|
|
*/
|
|
private function maybeAddWarnings( array $entries, callable $isInvalid, array &$warnings, string $message ) {
|
|
$invalidEntries = [];
|
|
foreach ( $entries as $entry ) {
|
|
if ( $isInvalid( $entry ) ) {
|
|
$invalidEntries[] = $entry;
|
|
}
|
|
}
|
|
if ( count( $invalidEntries ) ) {
|
|
$warnings[] = wfMessage( $message,
|
|
Message::listParam( $invalidEntries, 'comma' ),
|
|
count( $invalidEntries ) );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Get the configured default GadgetRepo.
|
|
*
|
|
* @deprecated Use the GadgetsRepo service instead
|
|
* @return GadgetRepo
|
|
*/
|
|
public static function singleton() {
|
|
if ( self::$instance === null ) {
|
|
return MediaWikiServices::getInstance()->getService( 'GadgetsRepo' );
|
|
}
|
|
return self::$instance;
|
|
}
|
|
|
|
/**
|
|
* Should only be used by unit tests
|
|
*
|
|
* @deprecated Use the GadgetsRepo service instead
|
|
* @param GadgetRepo|null $repo
|
|
*/
|
|
public static function setSingleton( $repo = null ) {
|
|
self::$instance = $repo;
|
|
}
|
|
}
|