mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets
synced 2024-09-23 10:22:21 +00:00
d2a37f5f69
The reason for this hook is not the validation itself, because that is already done by `GadgetDefinitionContent->isValid` which is part of the core Content interface, already enforced by ContentHandler. Instead, the hook was here to provide the custom interface message GadgetDefinitionValidator, because the core Content interface is limited to boolean isValid(), which provides a very generic error message. However, nowadays ContentHandler exposes this mechanism directly such that we can directly attach a custom message to it without needing to wait for the stack to reach the EditPage and then override it after the fact from a global hook. Also: * Simplify validation logic towards "is" checks with only an expected description. * Move schema.json file to top-level file. It has been unused for as long as it has been in the repo, despite appearing (due to its placement) to be used as part of the source. It was added, I believe, with the intent to be used by the validator, but it isn't. It also isn't validated or checked for correctness by anything right now. For now, keep it as informal schema in the top-level location for easy discovery where perhaps others can find a use for it. SD0001 mentions gadget developers may want to start using it for Git-maintained gadgets to help with validation in their IDE, after Gadgets 2.0 is launched. Test Plan: * Set `$wgGadgetsRepo = 'json+definition';` * Create `MediaWiki:Gadgets/example.json` * Attempt to save "x" in settings.namespaces item. * Attempt to save "x.zip" in module.pages item. * Fails with this patch, similar as on master. Bug: T31272 Change-Id: I61bc3e40348a0aeb3bd3fa9ca86ccb7b93304095
111 lines
2.4 KiB
JSON
111 lines
2.4 KiB
JSON
{
|
|
"name": "Gadgets",
|
|
"author": [
|
|
"Daniel Kinzler",
|
|
"Max Semenik",
|
|
"Timo Tijhof",
|
|
"Siddharth VP"
|
|
],
|
|
"url": "https://www.mediawiki.org/wiki/Extension:Gadgets",
|
|
"descriptionmsg": "gadgets-desc",
|
|
"license-name": "GPL-2.0-or-later",
|
|
"requires": {
|
|
"MediaWiki": ">= 1.42"
|
|
},
|
|
"type": "other",
|
|
"ContentHandlers": {
|
|
"GadgetDefinition": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Content\\GadgetDefinitionContentHandler",
|
|
"services": [
|
|
"GadgetsRepo"
|
|
]
|
|
}
|
|
},
|
|
"SpecialPages": {
|
|
"Gadgets": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Special\\SpecialGadgets",
|
|
"services": [
|
|
"GadgetsRepo"
|
|
]
|
|
},
|
|
"GadgetUsage": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Special\\SpecialGadgetUsage",
|
|
"services": [
|
|
"GadgetsRepo",
|
|
"ConnectionProvider"
|
|
]
|
|
}
|
|
},
|
|
"APIListModules": {
|
|
"gadgetcategories": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Api\\ApiQueryGadgetCategories",
|
|
"services": [
|
|
"GadgetsRepo"
|
|
]
|
|
},
|
|
"gadgets": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Api\\ApiQueryGadgets",
|
|
"services": [
|
|
"GadgetsRepo"
|
|
]
|
|
}
|
|
},
|
|
"MessagesDirs": {
|
|
"Gadgets": [
|
|
"i18n",
|
|
"i18n/api"
|
|
]
|
|
},
|
|
"ExtensionMessagesFiles": {
|
|
"GadgetsAlias": "Gadgets.alias.php"
|
|
},
|
|
"RawHtmlMessages": [
|
|
"gadgets-definition"
|
|
],
|
|
"AutoloadNamespaces": {
|
|
"MediaWiki\\Extension\\Gadgets\\": "includes/"
|
|
},
|
|
"TestAutoloadClasses": {
|
|
"GadgetTestTrait": "tests/phpunit/GadgetTestTrait.php"
|
|
},
|
|
"HookHandlers": {
|
|
"GadgetHooks": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Hooks",
|
|
"services": [
|
|
"GadgetsRepo",
|
|
"UserOptionsLookup"
|
|
]
|
|
},
|
|
"GadgetCodeEditorHooks": {
|
|
"class": "MediaWiki\\Extension\\Gadgets\\CodeEditorHooks"
|
|
}
|
|
},
|
|
"Hooks": {
|
|
"PageDeleteComplete": "GadgetHooks",
|
|
"PageSaveComplete": "GadgetHooks",
|
|
"BeforePageDisplay": "GadgetHooks",
|
|
"CodeEditorGetPageLanguage": "GadgetCodeEditorHooks",
|
|
"ContentHandlerDefaultModelFor": "GadgetHooks",
|
|
"UserGetDefaultOptions": "GadgetHooks",
|
|
"GetPreferences": "GadgetHooks",
|
|
"PreferencesGetLegend": "GadgetHooks",
|
|
"ResourceLoaderRegisterModules": "GadgetHooks",
|
|
"wgQueryPages": "GadgetHooks",
|
|
"DeleteUnknownPreferences": "GadgetHooks",
|
|
"PreferencesGetIcon": "GadgetHooks",
|
|
"getUserPermissionsErrors": "GadgetHooks"
|
|
},
|
|
"ServiceWiringFiles": [
|
|
"includes/ServiceWiring.php"
|
|
],
|
|
"config": {
|
|
"GadgetsRepo": {
|
|
"value": "definition"
|
|
},
|
|
"SpecialGadgetUsageActiveUsers": {
|
|
"value": true
|
|
}
|
|
},
|
|
"manifest_version": 2
|
|
}
|