Commit graph

30 commits

Author SHA1 Message Date
Sam Reed df866a5f21 Documentation, code updates, removal of direct member variable access 2012-02-17 21:23:46 +00:00
Roan Kattouw 9009f36e81 Revert r106007 (Split Gadget modules into two, one for scripts and one for styles): I like the concept of having multiple modules, and I'll probably implement this in the RL2 branch, but this specific implementation has issues (subclassing OutputPage, building its own head items) that were pointed out on CR but never fixed. 2012-02-02 19:04:52 +00:00
Liangent f0f203bbba Followup r100509: Don't validate skin names written in the definition page. 2012-01-18 02:44:37 +00:00
Robin Pepermans f6e96b17e9 Bug 30182: add dir="auto" as a workaround for untranslated gadget descriptions 2011-12-13 18:03:00 +00:00
Liangent cbef9a4faf Followup r100497, r101827: use another way which doesn't look that hacky to load styles in gadgets before documents. Also avoid double loading of the same stylesheet.
Now a gadget generates up to three modules:
* The first is known as meta module which still use its original name to keep B/C. It contains no contents, with dependencies of ones specified by user, scripts module, and styles module. See below.
* The second is known as scripts module whose name ends with ".scripts". It contains all scripts in this gadgets, with dependencies specified by user
* The third is known as styles module whose name ends with ".styles". It contains all styles in this gadgets and loaded before documents. After its load it's instantly marked as ready without dependencies resolved (which is the same as dependencies of .scripts but may not be used at all)

The meta module is loaded as if there's only one module under that name, and it's safe for users to reuse that name. The styles module is loaded and marked as ready in <head>, as described above. Normally the scripts and styles modules shouldn't be used by users.

A possible bug that dependency-only gadgets (ie. no scripts or styles) may not be loaded is fixed.
2011-12-13 10:41:51 +00:00
Liangent fadacf486f Followup r101827: It doesn't need to extends OutputPage anymore 2011-11-03 16:12:11 +00:00
Liangent f2478673ee Followup r100497: Fix stuff described there 2011-11-03 16:11:04 +00:00
Liangent 7bdf6f5ca2 Followup r100509: Increase GADGET_CLASS_VERSION 2011-10-24 12:49:33 +00:00
Liangent b9aa1fea37 (bug 31414) Skin specific gadgets 2011-10-22 19:09:25 +00:00
Liangent fb4ad3cac6 Followup r100497: Indention tweak 2011-10-22 05:59:55 +00:00
Liangent 294abd1e32 Move styles in gadgets to the top of pages to avoid flash of unstyled content.
Those styles should be loaded after site and user styles to keep B/C.
2011-10-22 04:32:10 +00:00
Siebrand Mazeland 76b26174eb stylize.php, update whitespace, remove superfluous comment lines
update indentation and sprinkle some braces.
2011-09-23 06:48:37 +00:00
Aaron Schulz ea4dbfd336 Replaced use of wfEmptyMsg() with new Message class. The underlying implementation changed and caused an unstub loop in some cases (like with filecache enabled). Unstubbing $wgLang requires loading $wgUser which triggers a gadget hook, which should not require unstubbing the user's language. 2011-09-23 05:43:40 +00:00
Krinkle e941ac9d18 [ResourceLoader] Set default options for gadgets that are enabled by default, otherwise they can't be disabled from the preferences (bug 30941)
* Uses the new hook in User:getDefaultOptions (bug 30940; r97365)
* This revision is based on a similar one for RL2 in the branch (r97366). Needs to be back ported as the bug occurs in 1.18 as well
2011-09-17 03:03:02 +00:00
Niklas Laxström e4ab22033d Typo and whitespace 2011-04-16 15:48:24 +00:00
Max Semenik 32ea54f472 Gadgets: store category information in class, added getters for description in different forms 2011-04-15 19:41:47 +00:00
Max Semenik dbc8ef531f Bug 13742 - Allow for gadgets to be turned on by default.
Because I'm lazy to do everything twice, README now points to on-wiki docs for definition format.
2011-04-12 18:09:50 +00:00
Max Semenik 1566407b27 Gadgets: bug 12211 - show in preferences only gadgets the user is able to use 2011-04-03 19:01:52 +00:00
Max Semenik 2700695760 Gadgets: refactored [options] parsing in preparation for adding moar 2011-04-02 16:02:53 +00:00
Max Semenik 5c03dc8ff7 Gadgets: add class version to Memcached key. This will help in avoid problems like we had with switches back and forth between 1.16 and 1.17 versions of this extension. 2011-04-02 15:36:59 +00:00
Max Semenik 10fc73e2a4 Adapt Gadgets to changes in r81692 2011-02-20 18:14:38 +00:00
Platonides 5ec0566f1d Merge r81884 (the other half is already in trunk) 2011-02-10 18:05:50 +00:00
Happy-melon edb861eaf2 Follow-up r64670 (bug22929): cleaner implementation of security for script (and potentially CSS) files. ResourceLoader *already* knows where each module has come from, so all we need to do is filter them in OutputPage according to the desired level of 'trustworthiness'.
TODO:
* Are there instances where we might want to restrict CSS as well as JS?
* Would a $wg config option and/or user preference and/or index.php GET parameter to limit inclusion be useful?
* Can we deprecate any of the existing $wg config options?
* What's going on with the duplicated code between OutputPage and SkinTemplate?
2011-02-04 16:39:17 +00:00
Sam Reed a28171f959 Remainder of some more undefined variables 2011-01-23 10:35:15 +00:00
Max Semenik f3067c12f5 Removed outdated comments. Yay, RL managed to fix some things along with breaking the others! :P 2010-11-14 11:13:13 +00:00
Max Semenik 6bb8086e45 rm stray tab from r76639 2010-11-13 19:13:43 +00:00
Max Semenik 7a5af63a10 Support for specifying extra modules as gadget's dependencies 2010-11-13 18:45:21 +00:00
Max Semenik 4b478672bf More gadgets fixage 2010-11-11 19:23:38 +00:00
Max Semenik 0345201333 Stupid, stupid /me (ping r76527) 2010-11-11 19:10:57 +00:00
Max Semenik 66a0821cb7 Merged branches/Gadgets-work/ to trunk. It now uses ResourceLoader (scripts must be explicitly marked as supporting it to be loaded this way), and in process I've completely rewritten its internal organisation in OOP style. Documentation commits will follow. 2010-11-11 18:19:57 +00:00