Commit graph

1680 commits

Author SHA1 Message Date
jenkins-bot ef4c537d9e Merge "Fix skins option to use currently displayed skin, rather than user preference" 2018-08-03 18:53:39 +00:00
Matt Russell b340532c52 Fix skins option to use currently displayed skin, rather than user preference
The user's preference usually reflects the displayed skin, however this isn't
true if the `useskin` URL query is set, or MobileFrontend is being used.

This fixes gadgets being displayed on the wrong skin when using `useskin`,
and allows mobile-specific gadgets (using `skins=minerva`).

Testing if the gadget is allowed in the current skin is split out from
`isAllowed` to `isSkinSupported` to enable a future patch showing gadgets
on preferences regardless of if they are allowed on the current skin.
Test coverage is added for both functions.

Also fixed another test which wasn't working, presumably because the placeholder
user didn't have the "read" right, so the section wasn't being kept.

Bug: T199478
Change-Id: I21febe92d54d6d0b89925f902581cc2739d824fb
2018-08-01 11:06:17 +10:00
Thiemo Kreuz bede1c0178 More loose @covers annotations in GadgetTest
This is more an integration test than anything. The @covers tags I found
are to strict, in my opinion. These test cases cover more code.

Change-Id: I6cef7ce0c612ac3dfbb855c495032df1fe96f4af
2018-07-31 18:38:26 +02:00
Fomafix 3aeffaa12b SpecialGadgetUsage: Add <thead> and <tbody> in the table
Change-Id: I53f61ce4c7d0721171a455e25b560ce33d4109b9
2018-07-30 21:38:20 +02:00
Fomafix 98ac345756 Use $lang->equals() to compare Language objects
Change-Id: Iae691c2b1e4f34bb0f509a109333277ade900659
2018-07-30 20:01:18 +02:00
Translation updater bot da783907e7 Localisation updates from https://translatewiki.net.
Change-Id: Iff8ba11db604c43a0543d5215ac1eca31985ecc1
2018-07-27 22:17:49 +02:00
libraryupgrader c86d3620e0 build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
The following sniffs now pass and were enabled:
* Squiz.Scope.MemberVarScope.Missing

Change-Id: If3902b0dffb9bb28de7093dd33e92869bead3746
2018-07-27 06:22:12 +00:00
Translation updater bot 64bd946091 Localisation updates from https://translatewiki.net.
Change-Id: I0ffeb094000bc90de4ddf7568d1410aed52ddcd6
2018-07-21 22:11:50 +02:00
Translation updater bot f1942c9c2e Localisation updates from https://translatewiki.net.
Change-Id: I34147903ecc6436fac60778c5c25982a5cd358a6
2018-07-17 22:13:52 +02:00
Translation updater bot cd469368d4 Localisation updates from https://translatewiki.net.
Change-Id: Id6f526a6701e1bc1bcefb3d96d6454be693b7b83
2018-07-14 22:20:32 +02:00
Translation updater bot f268a9faba Localisation updates from https://translatewiki.net.
Change-Id: Ib081f7bb03163ac475e612c5720270e049ee9781
2018-07-10 22:15:59 +02:00
Translation updater bot 79a5388496 Localisation updates from https://translatewiki.net.
Change-Id: Ia857fa2e97ac0b9fed7f8fb22991904481988657
2018-06-30 22:30:34 +02:00
Translation updater bot 01f0e1842f Localisation updates from https://translatewiki.net.
Change-Id: If2e00e53c7d5d00a83c0dae0a3eb6b28a051affe
2018-06-27 22:19:04 +02:00
Translation updater bot 83352ba7c2 Localisation updates from https://translatewiki.net.
Change-Id: I4034d6fe2f1d8c73a6bbac73e7a6b2fd151f50d0
2018-06-16 22:26:08 +02:00
Translation updater bot 2d6066bf26 Localisation updates from https://translatewiki.net.
Change-Id: Ib1afa4fbf3ce79fd61144e4872b0ea9823f80409
2018-06-11 22:33:52 +02:00
libraryupgrader b1a7eb2642 build: Updating mediawiki/mediawiki-phan-config to 0.3.0
Change-Id: I7603c3892408e484845cbb1e5da7cabdf4ae25c2
2018-06-08 07:05:45 +00:00
Translation updater bot d23598ef88 Localisation updates from https://translatewiki.net.
Change-Id: I1619db82ea28593b0671c76bcea68a851c9d918c
2018-06-03 22:36:23 +02:00
Translation updater bot 41c45ce732 Localisation updates from https://translatewiki.net.
Change-Id: I38573338bb2c5d3ffa5e29af2819407721638e9a
2018-06-01 22:27:31 +02:00
Translation updater bot fb99036738 Localisation updates from https://translatewiki.net.
Change-Id: I2051d8b64987a0c9cbc053bbbce1a9b9dfb14630
2018-05-29 22:24:55 +02:00
Translation updater bot 074d5cd4c8 Localisation updates from https://translatewiki.net.
Change-Id: Id8cc9bc86d09698f1b94ac99091ba815aac54141
2018-05-28 22:42:13 +02:00
libraryupgrader 33ecce01c0 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: I210883a100f2060e9bff0d5066896ce35b45a788
2018-05-26 03:01:39 +00:00
Kunal Mehta c383794d16 Fix variable name reuse in EditFilterMergedContent hook
Bug: T194695
Change-Id: Ic99e35874f1a3a4a7c1d1c302294bbecd23080ed
2018-05-14 17:11:58 -07:00
Translation updater bot 763ff4c9af Localisation updates from https://translatewiki.net.
Change-Id: Ia5018dd2bf5da68a3554ba7a1501bb2f82c4fa8d
2018-05-09 22:41:01 +02:00
Brian Wolff ee633a273b Bump phan-taint-check 1.1.0->1.2.0
Bug: T193909
Change-Id: I1bf4d64e68bff516b5f8b6266d85f670200084df
2018-05-04 20:34:59 +00:00
Translation updater bot 5d345da359 Localisation updates from https://translatewiki.net.
Change-Id: I3af9548faddab00a27bc26f2a9addc72854b0753
2018-04-29 22:31:02 +02:00
jenkins-bot b7d0a311fc Merge "Localize namespaces into lfn" 2018-04-24 23:15:48 +00:00
MarcoAurelio 399c6b01d6 Add Euskara (eu) translations to Gadgets.namespaces
@author: Theklan <https://eu.wikisource.org/?diff=7787>

Change-Id: I9fd364e8816e3c6c837cde0df900d825dabf5fc7
2018-04-24 09:49:22 +00:00
Martin Urbanec b691ef6d4e Localize namespaces into lfn
Bug: T184518
Change-Id: I74ab616086299136af89426e0e9b0673064e5e9a
2018-04-23 12:48:23 +02:00
Translation updater bot dcf6e197ef Localisation updates from https://translatewiki.net.
Change-Id: I895c907606774579ea31c2a6a73b86266ed64a04
2018-04-21 22:15:34 +02:00
libraryupgrader e1ac086c7a build: Updating mediawiki/mediawiki-codesniffer to 18.0.0
Change-Id: Ib8e7fc03e189535fcbd00bb7ecdbc57b3162868c
2018-04-14 01:31:15 +00:00
Translation updater bot bc085b3a33 Localisation updates from https://translatewiki.net.
Change-Id: I6eda40199ca468d238f7d56bfeddfe0a4c918627
2018-04-11 22:40:06 +02:00
Guycn2 f94389d941 Remove my previous username from list of authors
Change-Id: Ie6c1714766f461bbcffe280a1baf59862b99f3f1
2018-04-11 20:06:12 +00:00
Translation updater bot f3b87bc35c Localisation updates from https://translatewiki.net.
Change-Id: If2f047b0c272f727ce5fff130ae068936a50a103
2018-04-10 22:15:24 +02:00
Jayprakash12345 54d1eb0d77 Convert Special:Gadgets/export/$par to use OOUI
Bug: T191822
Change-Id: Ia59918a1a7f10d56a5c32050591a537d90c6de7c
2018-04-09 23:20:17 +05:30
Translation updater bot b4b79a6cc7 Localisation updates from https://translatewiki.net.
Change-Id: I0f93a065e83e89db8f623c72121287273453815d
2018-04-08 22:29:57 +02:00
jenkins-bot 435d0f4fcd Merge "Use SPDX license identifiers for @license" 2018-04-07 21:06:34 +00:00
jenkins-bot 4ca18e2fac Merge "Change ResultWrapper to IResultWrapper in special page" 2018-04-07 21:06:33 +00:00
Kunal Mehta bb81950e9f Use SPDX license identifiers for @license
Change-Id: I7eaf1d7bd11642f40a59505c1586fb393bf35283
2018-04-07 08:42:12 +00:00
Umherirrender 75ce384e42 Change ResultWrapper to IResultWrapper in special page
Follows core change I22ec4d3a9a19fc86efc9a2deb06f810695d38c85

Change-Id: I3f5e63478761e2cf312f75771b152d01111a3fa6
2018-04-07 10:35:58 +02:00
Sam Wilson 97c5bd7732 Prevent gadget preferences from being cleaned up
Bug: T188966
Change-Id: I5627f014827fdbf266eb7fdb00a446f81a0c3458
2018-04-06 20:06:11 +00:00
Kunal Mehta 441302fb5e build: Updating mediawiki/mediawiki-phan-config to 0.2.0
Change-Id: I4d364243c33243aceeff9793bc3e69efd62ae491
2018-04-05 13:25:35 -07:00
Translation updater bot 10a0b94148 Localisation updates from https://translatewiki.net.
Change-Id: I5b166043fa6f574999d12c51a06b009b805142b9
2018-04-04 22:50:22 +02:00
Translation updater bot 3904b600ed Localisation updates from https://translatewiki.net.
Change-Id: I980ecc0c7d31354095a4d81e7f50e120d45c98be
2018-04-03 09:51:05 +02:00
libraryupgrader 5974c3b7dc build: Updating mediawiki/mediawiki-codesniffer to 17.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.LicenseComment.InvalidLicenseTag

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment

Change-Id: I999afc9253d67e13144fe3165ffc3b8a74ac9ea4
2018-03-29 02:17:02 +00:00
Translation updater bot a41a995509 Localisation updates from https://translatewiki.net.
Change-Id: If54e68b22c8fd57e461faa9502c5ee17518e991d
2018-03-28 22:23:04 +02:00
Translation updater bot 2f004979e9 Localisation updates from https://translatewiki.net.
Change-Id: Ic25b545d91a0d8d280dd72bab49e0aa2e1235599
2018-03-26 22:19:06 +02:00
Translation updater bot 26b6f2f2be Localisation updates from https://translatewiki.net.
Change-Id: I08576f2fea5e439ced82a042189e2e3c550fce39
2018-03-22 22:08:54 +01:00
Translation updater bot 2db46bf16e Localisation updates from https://translatewiki.net.
Change-Id: I0040a82d08e73900d0764ad207f8768a0c0a5a90
2018-03-19 22:19:16 +01:00
libraryupgrader 5b7e9fcfb6 build: Updating jakub-onderka/php-parallel-lint to 1.0.0
Change-Id: Iaa264fc2a0f6d20fdd47a1abe19ac05047ebc4fd
2018-03-09 10:05:29 +00:00
Translation updater bot 4edd974571 Localisation updates from https://translatewiki.net.
Change-Id: I30bb222c5b105fb5aa2f9179a68779f5cd24f517
2018-03-08 22:45:49 +01:00