wikimedia/mediawiki-extensions-Gadgets
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets synced 2024-11-27 16:50:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

SECURITY: Improve regular expression performance

Browse source 
* This patch improves the performance of an
  ext:Gadgets regular expression which helps parse
  out sections of the gadgets definition page.

Bug: T363773
Change-Id: Ic9e1a181b261ae4d25e9ce2f91ad12f92e9855d9
This commit is contained in:
sbassett 2024-05-14 14:37:17 -05:00
parent 5dbf7bce92
commit f2bc65a518
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/MediaWikiGadgetsDefinitionRepo.php
View file

@ -198,7 +198,7 @@ class MediaWikiGadgetsDefinitionRepo extends GadgetRepo {
foreach ( $lines as $line ) { foreach ( $lines as $line ) {
$m = []; $m = [];
if ( preg_match( '/^==+ *([^*:\s|]+?)\s*==+\s*$/', $line, $m ) ) { if ( preg_match( '/^==+ *([^*:\s|]+)\s*(?<!=)==+\s*$/', $line, $m ) ) {
$section = $m[1]; $section = $m[1];
} else { } else {
$gadget = $this->newFromDefinition( $line, $section ); $gadget = $this->newFromDefinition( $line, $section );