mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets
synced 2024-11-14 11:04:43 +00:00
Remove default gadgets from Special:GadgetUsage
The numbers for default gadgets are inconsistent and can be misleading. Change-Id: Ib46084d617a536e4e25da80424ad70cec2a09f5a
This commit is contained in:
parent
e76340f89c
commit
c23335fe5e
|
@ -95,6 +95,23 @@ class SpecialGadgetUsage extends QueryPage {
|
|||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* Get a list of default gadgets
|
||||
* @return list
|
||||
*/
|
||||
protected function getDefaultGadgets() {
|
||||
$gadgetRepo = GadgetRepo::singleton();
|
||||
$gadgetIds = $gadgetRepo->getGadgetIds();
|
||||
$gadgetsList = array();
|
||||
foreach ( $gadgetIds as $g ) {
|
||||
$gadget = $gadgetRepo->getGadget( $g );
|
||||
if ( $gadget->isOnByDefault() ) {
|
||||
$gadgetsList[] = $gadget->getName();
|
||||
}
|
||||
}
|
||||
return $gadgetsList;
|
||||
}
|
||||
|
||||
/**
|
||||
* Format and output report results using the given information plus
|
||||
* OutputPage
|
||||
|
@ -107,13 +124,17 @@ class SpecialGadgetUsage extends QueryPage {
|
|||
* @param int $offset Paging offset
|
||||
*/
|
||||
protected function outputResults( $out, $skin, $dbr, $res, $num, $offset ) {
|
||||
$defaultGadgets = $this->getDefaultGadgets();
|
||||
if ( $num > 0 ) {
|
||||
$this->outputTableStart();
|
||||
|
||||
foreach ( $res as $row ) {
|
||||
$line = $this->formatResult( $skin, $row );
|
||||
if ( $line ) {
|
||||
$out->addHTML( $line );
|
||||
// Remove the 'gadget-' part of the result string and compare if it's present
|
||||
// in $defaultGadgets, if not we format it and add it to the output
|
||||
if ( !in_array( substr( $row->title, 7 ), $defaultGadgets ) ) {
|
||||
$line = $this->formatResult( $skin, $row );
|
||||
if ( $line ) {
|
||||
$out->addHTML( $line );
|
||||
}
|
||||
}
|
||||
}
|
||||
// Close table element
|
||||
|
|
Loading…
Reference in a new issue