wikimedia/mediawiki-extensions-Gadgets
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets synced 2024-11-11 16:49:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Drop a few easy to avoid Html::open/closeElement"

Browse source
This commit is contained in:
jenkins-bot 2024-04-29 14:07:52 +00:00 committed by Gerrit Code Review
parent 65f6500730 7d1c8336e3
commit 848a226189
1 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
includes/Special/SpecialGadgetUsage.php
View file

@ -153,9 +153,7 @@ class SpecialGadgetUsage extends QueryPage {
* and the opening <tbody>.
*/
protected function outputTableStart() {
$html = Html::openElement( 'table', [ 'class' => [ 'sortable', 'wikitable' ] ] );
$html .= Html::openElement( 'thead', [] );
$html .= Html::openElement( 'tr', [] );
$html = '';
$headers = [ 'gadgetusage-gadget', 'gadgetusage-usercount' ];
if ( $this->isActiveUsersEnabled() ) {
$headers[] = 'gadgetusage-activeusers';
@ -168,10 +166,12 @@ class SpecialGadgetUsage extends QueryPage {
$this->msg( $h )->text() );
}
}
$html .= Html::closeElement( 'tr' );
$html .= Html::closeElement( 'thead' );
$html .= Html::openElement( 'tbody', [] );
$this->getOutput()->addHTML( $html );
$this->getOutput()->addHTML(
Html::openElement( 'table', [ 'class' => [ 'sortable', 'wikitable' ] ] ) .
Html::rawElement( 'thead', [], Html::rawElement( 'tr', [], $html ) ) .
Html::openElement( 'tbody', [] )
);
$this->getOutput()->addModuleStyles( 'jquery.tablesorter.styles' );
$this->getOutput()->addModules( 'jquery.tablesorter' );
}
@ -196,7 +196,7 @@ class SpecialGadgetUsage extends QueryPage {
$gadgetTitle = substr( $result->title, 7 );
$gadgetUserCount = $this->getLanguage()->formatNum( $result->value );
if ( $gadgetTitle ) {
$html = Html::openElement( 'tr', [] );
$html = '';
// "Gadget" column
$link = $this->getLinkRenderer()->makeLink(
new TitleValue( NS_SPECIAL, 'Gadgets', 'gadget-' . $gadgetTitle ),
@ -210,8 +210,7 @@ class SpecialGadgetUsage extends QueryPage {
$activeUserCount = $this->getLanguage()->formatNum( $result->namespace );
$html .= Html::element( 'td', [], $activeUserCount );
}
$html .= Html::closeElement( 'tr' );
return $html;
return Html::rawElement( 'tr', [], $html );
}
return false;
}
@ -261,7 +260,7 @@ class SpecialGadgetUsage extends QueryPage {
$this->outputTableStart();
// Append default gadgets to the table with 'default' in the total and active user fields
foreach ( $defaultGadgets as $default ) {
$html = Html::openElement( 'tr', [] );
$html = '';
// "Gadget" column
$link = $this->getLinkRenderer()->makeLink(
new TitleValue( NS_SPECIAL, 'Gadgets', 'gadget-' . $default ),
@ -276,8 +275,7 @@ class SpecialGadgetUsage extends QueryPage {
$html .= Html::element( 'td', [ 'data-sort-value' => 'Infinity' ],
$this->msg( 'gadgetusage-default' )->text() );
}
$html .= Html::closeElement( 'tr' );
$out->addHTML( $html );
$out->addHTML( Html::rawElement( 'tr', [], $html ) );
}
foreach ( $res as $row ) {
// Remove the 'gadget-' part of the result string and compare if it's present