mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets
synced 2024-11-28 09:10:07 +00:00
Avoid 'rawrow' for HTMLForm 'info' fields
The wrapper tags that we have to create when using the 'rawrow' option would have to be different for OOUI and non-OOUI preferences forms, making it impossible to support both at the same time. We used it in order to generate `<td colspan=2>...</td>` rather than `<td></td><td>...</td>`, and make the description span both the label and the input columns. However, this is not necessary, because the label column is entirely hidden on this page of preferences, as all of the preferences have no labels. Bug: T203202 Change-Id: Ib9510a8bfb2430fdda3988d88628c9f0c509c6d0
This commit is contained in:
parent
b60ab7ae58
commit
52d57c6597
|
@ -114,12 +114,9 @@ class GadgetHooks {
|
||||||
$preferences['gadgets-intro'] =
|
$preferences['gadgets-intro'] =
|
||||||
[
|
[
|
||||||
'type' => 'info',
|
'type' => 'info',
|
||||||
'default' => Xml::tags( 'tr', [],
|
'default' => wfMessage( 'gadgets-prefstext' )->parseAsBlock(),
|
||||||
Xml::tags( 'td', [ 'colspan' => 2 ],
|
|
||||||
wfMessage( 'gadgets-prefstext' )->parseAsBlock() ) ),
|
|
||||||
'section' => 'gadgets',
|
'section' => 'gadgets',
|
||||||
'rawrow' => true,
|
'raw' => true,
|
||||||
'raw' => true, // Needed to pass phan-taint-check-plugin, see T201902
|
|
||||||
];
|
];
|
||||||
|
|
||||||
$preferences['gadgets'] =
|
$preferences['gadgets'] =
|
||||||
|
|
Loading…
Reference in a new issue