wikimedia/mediawiki-extensions-Gadgets
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Gadgets synced 2024-09-23 10:22:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid adding hidden gadgets in default options

Browse source 
Hidden gadgets do not have associated user preferences. Adding them to $defaultOptions only causes them to be unnecessarily exported in mw.user.options.

Bug: T299071
Change-Id: Ic55e7f2a9daa405cddd0189de3d32f5825bc336a
This commit is contained in:
Siddharth VP 2022-01-12 22:49:58 +05:30
parent 2d1f320e23
commit 43efda4f96
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/GadgetHooks.php
View file

@ -73,7 +73,10 @@ class GadgetHooks {
*/
foreach ( $gadgets as $thisSection ) {
foreach ( $thisSection as $gadgetId => $gadget ) {
$defaultOptions['gadget-' . $gadgetId] = $gadget->isOnByDefault() ? 1 : 0;
// Hidden gadgets don't need to be added here, T299071
if ( !$gadget->isHidden() ) {
$defaultOptions['gadget-' . $gadgetId] = $gadget->isOnByDefault() ? 1 : 0;
}
}
}
}