2010-11-13 19:13:43 +00:00
|
|
|
<?php
|
2010-11-11 18:19:57 +00:00
|
|
|
/**
|
|
|
|
* Gadgets extension - lets users select custom javascript gadgets
|
|
|
|
*
|
2016-12-23 17:26:43 +00:00
|
|
|
* For more info see https://www.mediawiki.org/wiki/Extension:Gadgets
|
2010-11-11 18:19:57 +00:00
|
|
|
*
|
|
|
|
* @file
|
|
|
|
* @ingroup Extensions
|
|
|
|
* @author Daniel Kinzler, brightbyte.de
|
|
|
|
* @copyright © 2007 Daniel Kinzler
|
2018-04-07 01:25:09 +00:00
|
|
|
* @license GPL-2.0-or-later
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Wrapper for one gadget.
|
|
|
|
*/
|
|
|
|
class Gadget {
|
|
|
|
/**
|
|
|
|
* Increment this when changing class structure
|
|
|
|
*/
|
2015-08-03 06:34:16 +00:00
|
|
|
const GADGET_CLASS_VERSION = 9;
|
2015-04-30 05:33:04 +00:00
|
|
|
|
|
|
|
const CACHE_TTL = 86400;
|
2010-11-11 18:19:57 +00:00
|
|
|
|
2016-12-28 10:25:47 +00:00
|
|
|
private $scripts = [],
|
|
|
|
$styles = [],
|
|
|
|
$dependencies = [],
|
2016-11-18 04:54:17 +00:00
|
|
|
$peers = [],
|
2016-12-28 10:25:47 +00:00
|
|
|
$messages = [],
|
2011-09-23 06:48:37 +00:00
|
|
|
$name,
|
2010-11-11 18:19:57 +00:00
|
|
|
$definition,
|
2011-04-03 19:01:52 +00:00
|
|
|
$resourceLoaded = false,
|
2016-12-28 10:25:47 +00:00
|
|
|
$requiredRights = [],
|
|
|
|
$requiredSkins = [],
|
|
|
|
$targets = [ 'desktop' ],
|
2011-04-15 19:41:47 +00:00
|
|
|
$onByDefault = false,
|
2015-08-03 06:34:16 +00:00
|
|
|
$hidden = false,
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
$type = '',
|
2011-04-15 19:41:47 +00:00
|
|
|
$category;
|
2010-11-11 18:19:57 +00:00
|
|
|
|
2015-07-18 07:26:25 +00:00
|
|
|
public function __construct( array $options ) {
|
|
|
|
foreach ( $options as $member => $option ) {
|
|
|
|
switch ( $member ) {
|
|
|
|
case 'scripts':
|
|
|
|
case 'styles':
|
|
|
|
case 'dependencies':
|
2016-11-18 04:54:17 +00:00
|
|
|
case 'peers':
|
2015-08-03 06:34:16 +00:00
|
|
|
case 'messages':
|
2015-07-18 07:26:25 +00:00
|
|
|
case 'name':
|
|
|
|
case 'definition':
|
|
|
|
case 'resourceLoaded':
|
|
|
|
case 'requiredRights':
|
|
|
|
case 'requiredSkins':
|
|
|
|
case 'targets':
|
|
|
|
case 'onByDefault':
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
case 'type':
|
2015-08-03 06:34:16 +00:00
|
|
|
case 'hidden':
|
2015-07-18 07:26:25 +00:00
|
|
|
case 'category':
|
|
|
|
$this->{$member} = $option;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
throw new InvalidArgumentException( "Unrecognized '$member' parameter" );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-03 06:37:32 +00:00
|
|
|
/**
|
|
|
|
* Create a object based on the metadata in a GadgetDefinitionContent object
|
|
|
|
*
|
|
|
|
* @param string $id
|
|
|
|
* @param GadgetDefinitionContent $content
|
|
|
|
* @return Gadget
|
|
|
|
*/
|
|
|
|
public static function newFromDefinitionContent( $id, GadgetDefinitionContent $content ) {
|
|
|
|
$data = $content->getAssocArray();
|
|
|
|
$prefixGadgetNs = function ( $page ) {
|
|
|
|
return 'Gadget:' . $page;
|
|
|
|
};
|
2016-12-28 10:25:47 +00:00
|
|
|
$info = [
|
2015-08-03 06:37:32 +00:00
|
|
|
'name' => $id,
|
|
|
|
'resourceLoaded' => true,
|
|
|
|
'requiredRights' => $data['settings']['rights'],
|
|
|
|
'onByDefault' => $data['settings']['default'],
|
|
|
|
'hidden' => $data['settings']['hidden'],
|
|
|
|
'requiredSkins' => $data['settings']['skins'],
|
|
|
|
'category' => $data['settings']['category'],
|
|
|
|
'scripts' => array_map( $prefixGadgetNs, $data['module']['scripts'] ),
|
|
|
|
'styles' => array_map( $prefixGadgetNs, $data['module']['styles'] ),
|
|
|
|
'dependencies' => $data['module']['dependencies'],
|
2016-11-18 04:54:17 +00:00
|
|
|
'peers' => $data['module']['peers'],
|
2015-08-03 06:37:32 +00:00
|
|
|
'messages' => $data['module']['messages'],
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
'type' => $data['module']['type'],
|
2016-12-28 10:25:47 +00:00
|
|
|
];
|
2015-08-03 06:37:32 +00:00
|
|
|
|
|
|
|
return new self( $info );
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Get a placeholder object to use if a gadget doesn't exist
|
|
|
|
*
|
|
|
|
* @param string $id name
|
|
|
|
* @return Gadget
|
|
|
|
*/
|
|
|
|
public static function newEmptyGadget( $id ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
return new self( [ 'name' => $id ] );
|
2015-08-03 06:37:32 +00:00
|
|
|
}
|
|
|
|
|
2015-07-18 07:26:25 +00:00
|
|
|
/**
|
|
|
|
* Whether the provided gadget id is valid
|
|
|
|
*
|
|
|
|
* @param string $id
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function isValidGadgetID( $id ) {
|
2017-07-23 07:23:06 +00:00
|
|
|
return strlen( $id ) > 0 && ResourceLoader::isValidModuleName( self::getModuleName( $id ) );
|
2015-07-18 07:26:25 +00:00
|
|
|
}
|
|
|
|
|
2010-11-11 18:19:57 +00:00
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return string Gadget name
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function getName() {
|
|
|
|
return $this->name;
|
|
|
|
}
|
|
|
|
|
2011-04-15 19:41:47 +00:00
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return string Gadget description parsed into HTML
|
2011-04-15 19:41:47 +00:00
|
|
|
*/
|
|
|
|
public function getDescription() {
|
|
|
|
return wfMessage( "gadget-{$this->getName()}" )->parse();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return string Wikitext of gadget description
|
2011-04-15 19:41:47 +00:00
|
|
|
*/
|
|
|
|
public function getRawDescription() {
|
|
|
|
return wfMessage( "gadget-{$this->getName()}" )->plain();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return string Name of category (aka section) our gadget belongs to. Empty string if none.
|
2011-04-15 19:41:47 +00:00
|
|
|
*/
|
|
|
|
public function getCategory() {
|
|
|
|
return $this->category;
|
|
|
|
}
|
|
|
|
|
2010-11-11 18:19:57 +00:00
|
|
|
/**
|
2015-08-03 06:37:32 +00:00
|
|
|
* @param string $id Name of gadget
|
|
|
|
* @return string Name of ResourceLoader module for the gadget
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
2015-08-03 06:37:32 +00:00
|
|
|
public static function getModuleName( $id ) {
|
|
|
|
return "ext.gadget.{$id}";
|
2010-11-11 18:19:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2011-04-03 19:01:52 +00:00
|
|
|
* Checks whether this gadget is enabled for given user
|
|
|
|
*
|
2017-08-27 14:07:08 +00:00
|
|
|
* @param User $user user to check against
|
|
|
|
* @return bool
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
2011-04-03 19:01:52 +00:00
|
|
|
public function isEnabled( $user ) {
|
2011-04-12 18:09:50 +00:00
|
|
|
return (bool)$user->getOption( "gadget-{$this->name}", $this->onByDefault );
|
2011-04-03 19:01:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Checks whether given user has permissions to use this gadget
|
|
|
|
*
|
2017-08-27 14:07:08 +00:00
|
|
|
* @param User $user user to check against
|
|
|
|
* @return bool
|
2011-04-03 19:01:52 +00:00
|
|
|
*/
|
|
|
|
public function isAllowed( $user ) {
|
2017-05-30 18:38:47 +00:00
|
|
|
return count( array_intersect( $this->requiredRights, $user->getRights() ) ) ==
|
|
|
|
count( $this->requiredRights )
|
|
|
|
&& ( $this->requiredSkins === true
|
|
|
|
|| !count( $this->requiredSkins )
|
|
|
|
|| in_array( $user->getOption( 'skin' ), $this->requiredSkins )
|
|
|
|
);
|
2010-11-11 18:19:57 +00:00
|
|
|
}
|
|
|
|
|
2011-04-12 18:09:50 +00:00
|
|
|
/**
|
2017-05-30 18:38:47 +00:00
|
|
|
* @return bool Whether this gadget is on by default for everyone
|
|
|
|
* (but can be disabled in preferences)
|
2011-04-12 18:09:50 +00:00
|
|
|
*/
|
|
|
|
public function isOnByDefault() {
|
|
|
|
return $this->onByDefault;
|
|
|
|
}
|
|
|
|
|
2015-08-03 06:34:16 +00:00
|
|
|
/**
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public function isHidden() {
|
|
|
|
return $this->hidden;
|
|
|
|
}
|
|
|
|
|
2010-11-11 18:19:57 +00:00
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return bool Whether all of this gadget's JS components support ResourceLoader
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function supportsResourceLoader() {
|
|
|
|
return $this->resourceLoaded;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return bool Whether this gadget has resources that can be loaded via ResourceLoaderb
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function hasModule() {
|
2012-02-02 19:04:52 +00:00
|
|
|
return count( $this->styles )
|
|
|
|
+ ( $this->supportsResourceLoader() ? count( $this->scripts ) : 0 )
|
|
|
|
> 0;
|
2010-11-11 18:19:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return string Definition for this gadget from MediaWiki:gadgets-definition
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function getDefinition() {
|
|
|
|
return $this->definition;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return array Array of pages with JS (including namespace)
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function getScripts() {
|
|
|
|
return $this->scripts;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return array Array of pages with CSS (including namespace)
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function getStyles() {
|
|
|
|
return $this->styles;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-08-27 14:07:08 +00:00
|
|
|
* @return array Array of all of this gadget's resources
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
|
|
|
public function getScriptsAndStyles() {
|
|
|
|
return array_merge( $this->scripts, $this->styles );
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2015-08-03 06:37:32 +00:00
|
|
|
* @return array
|
2010-11-11 18:19:57 +00:00
|
|
|
*/
|
2015-08-03 06:37:32 +00:00
|
|
|
public function getTargets() {
|
|
|
|
return $this->targets;
|
2010-11-11 18:19:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Returns list of scripts that don't support ResourceLoader
|
|
|
|
* @return Array
|
|
|
|
*/
|
|
|
|
public function getLegacyScripts() {
|
|
|
|
if ( $this->supportsResourceLoader() ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
return [];
|
2010-11-11 18:19:57 +00:00
|
|
|
}
|
|
|
|
return $this->scripts;
|
|
|
|
}
|
|
|
|
|
2010-11-13 18:45:21 +00:00
|
|
|
/**
|
|
|
|
* Returns names of resources this gadget depends on
|
|
|
|
* @return Array
|
|
|
|
*/
|
|
|
|
public function getDependencies() {
|
|
|
|
return $this->dependencies;
|
|
|
|
}
|
|
|
|
|
2016-11-18 04:54:17 +00:00
|
|
|
/**
|
|
|
|
* Get list of extra modules that should be loaded when this gadget is enabled
|
|
|
|
*
|
|
|
|
* Primary use case is to allow a Gadget that includes JavaScript to also load
|
|
|
|
* a (usually, hidden) styles-type module to be applied to the page. Dependencies
|
|
|
|
* don't work for this use case as those would not be part of page rendering.
|
|
|
|
*
|
|
|
|
* @return Array
|
|
|
|
*/
|
|
|
|
public function getPeers() {
|
|
|
|
return $this->peers;
|
|
|
|
}
|
|
|
|
|
2015-08-03 06:34:16 +00:00
|
|
|
/**
|
|
|
|
* @return array
|
|
|
|
*/
|
|
|
|
public function getMessages() {
|
|
|
|
return $this->messages;
|
|
|
|
}
|
|
|
|
|
2011-04-03 19:01:52 +00:00
|
|
|
/**
|
|
|
|
* Returns array of permissions required by this gadget
|
|
|
|
* @return Array
|
|
|
|
*/
|
|
|
|
public function getRequiredRights() {
|
|
|
|
return $this->requiredRights;
|
|
|
|
}
|
|
|
|
|
2011-10-22 19:09:25 +00:00
|
|
|
/**
|
|
|
|
* Returns array of skins where this gadget works
|
|
|
|
* @return Array
|
|
|
|
*/
|
|
|
|
public function getRequiredSkins() {
|
|
|
|
return $this->requiredSkins;
|
|
|
|
}
|
|
|
|
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
/**
|
|
|
|
* Returns the load type of this Gadget's ResourceLoader module
|
2017-05-12 17:37:49 +00:00
|
|
|
* @return string 'styles' or 'general'
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
*/
|
|
|
|
public function getType() {
|
|
|
|
if ( $this->type === 'styles' || $this->type === 'general' ) {
|
|
|
|
return $this->type;
|
|
|
|
}
|
2017-05-12 17:37:49 +00:00
|
|
|
// Similar to ResourceLoaderWikiModule default
|
2016-11-17 01:53:10 +00:00
|
|
|
if ( $this->styles && !$this->scripts && !$this->dependencies ) {
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
return 'styles';
|
2017-05-12 17:37:49 +00:00
|
|
|
} else {
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
return 'general';
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|