2015-04-07 20:14:26 +00:00
|
|
|
{
|
|
|
|
|
"name": "Gadgets",
|
|
|
|
|
"author": [
|
|
|
|
|
"Daniel Kinzler",
|
Replace EditFilterMergedContent hook with ContentHandler override
The reason for this hook is not the validation itself, because that
is already done by `GadgetDefinitionContent->isValid` which is part
of the core Content interface, already enforced by ContentHandler.
Instead, the hook was here to provide the custom interface message
GadgetDefinitionValidator, because the core Content interface is
limited to boolean isValid(), which provides a very generic error
message.
However, nowadays ContentHandler exposes this mechanism directly
such that we can directly attach a custom message to it without
needing to wait for the stack to reach the EditPage and then override
it after the fact from a global hook.
Also:
* Simplify validation logic towards "is" checks with only an
expected description.
* Move schema.json file to top-level file.
It has been unused for as long as it has been in the repo, despite
appearing (due to its placement) to be used as part of the source.
It was added, I believe, with the intent to be used by the validator,
but it isn't. It also isn't validated or checked for correctness
by anything right now.
For now, keep it as informal schema in the top-level location for
easy discovery where perhaps others can find a use for it.
SD0001 mentions gadget developers may want to start using it for
Git-maintained gadgets to help with validation in their IDE, after
Gadgets 2.0 is launched.
Test Plan:
* Set `$wgGadgetsRepo = 'json+definition';`
* Create `MediaWiki:Gadgets/example.json`
* Attempt to save "x" in settings.namespaces item.
* Attempt to save "x.zip" in module.pages item.
* Fails with this patch, similar as on master.
Bug: T31272
Change-Id: I61bc3e40348a0aeb3bd3fa9ca86ccb7b93304095
2024-03-26 21:06:26 +00:00
|
|
|
"Max Semenik",
|
|
|
|
|
"Timo Tijhof",
|
|
|
|
|
"Siddharth VP"
|
2015-04-07 20:14:26 +00:00
|
|
|
],
|
|
|
|
|
"url": "https://www.mediawiki.org/wiki/Extension:Gadgets",
|
|
|
|
|
"descriptionmsg": "gadgets-desc",
|
2018-02-01 07:05:41 +00:00
|
|
|
"license-name": "GPL-2.0-or-later",
|
2017-02-04 21:06:01 +00:00
|
|
|
"requires": {
|
2024-08-22 21:11:22 +00:00
|
|
|
"MediaWiki": ">= 1.43"
|
2017-02-04 21:06:01 +00:00
|
|
|
},
|
2015-04-07 20:14:26 +00:00
|
|
|
"type": "other",
|
2015-08-03 06:37:32 +00:00
|
|
|
"ContentHandlers": {
|
2024-02-09 19:03:36 +00:00
|
|
|
"GadgetDefinition": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Content\\GadgetDefinitionContentHandler",
|
|
|
|
|
"services": [
|
|
|
|
|
"GadgetsRepo"
|
|
|
|
|
]
|
|
|
|
|
}
|
2015-08-03 06:37:32 +00:00
|
|
|
},
|
2015-04-07 20:14:26 +00:00
|
|
|
"SpecialPages": {
|
2022-08-16 15:24:01 +00:00
|
|
|
"Gadgets": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Special\\SpecialGadgets",
|
|
|
|
|
"services": [
|
2024-06-29 18:52:55 +00:00
|
|
|
"ContentLanguage",
|
|
|
|
|
"GadgetsRepo",
|
|
|
|
|
"SkinFactory"
|
2022-08-16 15:24:01 +00:00
|
|
|
]
|
|
|
|
|
},
|
|
|
|
|
"GadgetUsage": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Special\\SpecialGadgetUsage",
|
|
|
|
|
"services": [
|
2024-02-25 02:49:56 +00:00
|
|
|
"GadgetsRepo",
|
|
|
|
|
"ConnectionProvider"
|
2022-08-16 15:24:01 +00:00
|
|
|
]
|
|
|
|
|
}
|
2015-04-07 20:14:26 +00:00
|
|
|
},
|
|
|
|
|
"APIListModules": {
|
2022-08-16 15:24:01 +00:00
|
|
|
"gadgetcategories": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Api\\ApiQueryGadgetCategories",
|
|
|
|
|
"services": [
|
|
|
|
|
"GadgetsRepo"
|
|
|
|
|
]
|
|
|
|
|
},
|
|
|
|
|
"gadgets": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Api\\ApiQueryGadgets",
|
|
|
|
|
"services": [
|
|
|
|
|
"GadgetsRepo"
|
|
|
|
|
]
|
|
|
|
|
}
|
2015-04-07 20:14:26 +00:00
|
|
|
},
|
|
|
|
|
"MessagesDirs": {
|
|
|
|
|
"Gadgets": [
|
2019-01-20 19:25:32 +00:00
|
|
|
"i18n",
|
|
|
|
|
"i18n/api"
|
2015-04-07 20:14:26 +00:00
|
|
|
]
|
|
|
|
|
},
|
|
|
|
|
"ExtensionMessagesFiles": {
|
Goodbye Gadget/Gadget_definition namespaces!
== What ==
* Remove the empty Gadget and Gadget_definition namespaces.
* Remove the "gadgets-definition-edit" user right.
* Remove need for custom namespace permissions that previously
had to extend editsitejs to apply to NS_GADGET.
== Why ==
Simplify the (unused) "GadgetDefinitionNamespaceRepo" backend for
Gadgets 2.0 by making it less radically different from the status quo.
The experimental 2.0 branch will now make use of the "gadget definition"
content model via "MediaWiki:Gadgets/<id>.json" pages, instead of
through a dedicated namespace.
When I first worked the Gadgets 2.0 branch, content models
were not a thing in MediaWiki, and interface-admin wasn't a thing yet
either. Now that we have per-page permissions and per-page content
models, we don't really need a separate namespace.
This follows the principle of least surprise, and fits well with other
interface admin and site configuration tools such as:
- Citoid, MediaWiki:Citoid-template-type-map.json,
- VisualEditor, MediaWiki:Visualeditor-template-tools-definition.json,
- AbuseFilter, MediaWiki:BlockedExternalDomains.json,
- the upcoming "Community Config" initiative.
If/when we develop the SpecialPage GUI for editing gadget definitions,
this can save its data to these pages the same as it would in
any other namespace. Similar to how Special:BlockedExternalDomains
operates on MediaWiki:BlockedExternalDomains.json.
See also bf1d6b3e93 (I6ffd5e9467), which recently removed the
gadgets-edit user right in favour of the editsite{css,js,json} rights.
Change-Id: I5b04ab251552e839087d0a8a6923d205adc7f771
2023-12-05 23:28:45 +00:00
|
|
|
"GadgetsAlias": "Gadgets.alias.php"
|
2015-04-07 20:14:26 +00:00
|
|
|
},
|
2018-08-27 17:29:54 +00:00
|
|
|
"RawHtmlMessages": [
|
|
|
|
|
"gadgets-definition"
|
|
|
|
|
],
|
2022-02-06 18:54:47 +00:00
|
|
|
"AutoloadNamespaces": {
|
|
|
|
|
"MediaWiki\\Extension\\Gadgets\\": "includes/"
|
2015-04-07 20:14:26 +00:00
|
|
|
},
|
2021-10-17 13:05:15 +00:00
|
|
|
"TestAutoloadClasses": {
|
2022-08-16 15:24:01 +00:00
|
|
|
"GadgetTestTrait": "tests/phpunit/GadgetTestTrait.php"
|
2021-10-17 13:05:15 +00:00
|
|
|
},
|
2021-12-06 10:34:17 +00:00
|
|
|
"HookHandlers": {
|
|
|
|
|
"GadgetHooks": {
|
2022-08-16 15:24:01 +00:00
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\Hooks",
|
|
|
|
|
"services": [
|
2023-12-05 18:00:37 +00:00
|
|
|
"GadgetsRepo",
|
|
|
|
|
"UserOptionsLookup"
|
2022-08-16 15:24:01 +00:00
|
|
|
]
|
2023-08-15 13:36:56 +00:00
|
|
|
},
|
|
|
|
|
"GadgetCodeEditorHooks": {
|
|
|
|
|
"class": "MediaWiki\\Extension\\Gadgets\\CodeEditorHooks"
|
2021-12-06 10:34:17 +00:00
|
|
|
}
|
|
|
|
|
},
|
2015-04-07 20:14:26 +00:00
|
|
|
"Hooks": {
|
2021-12-06 10:34:17 +00:00
|
|
|
"PageDeleteComplete": "GadgetHooks",
|
|
|
|
|
"PageSaveComplete": "GadgetHooks",
|
|
|
|
|
"BeforePageDisplay": "GadgetHooks",
|
2023-08-15 13:36:56 +00:00
|
|
|
"CodeEditorGetPageLanguage": "GadgetCodeEditorHooks",
|
2021-12-06 10:34:17 +00:00
|
|
|
"ContentHandlerDefaultModelFor": "GadgetHooks",
|
|
|
|
|
"UserGetDefaultOptions": "GadgetHooks",
|
|
|
|
|
"GetPreferences": "GadgetHooks",
|
|
|
|
|
"PreferencesGetLegend": "GadgetHooks",
|
|
|
|
|
"ResourceLoaderRegisterModules": "GadgetHooks",
|
|
|
|
|
"wgQueryPages": "GadgetHooks",
|
2022-10-14 01:27:45 +00:00
|
|
|
"DeleteUnknownPreferences": "GadgetHooks",
|
2022-08-27 14:04:31 +00:00
|
|
|
"PreferencesGetIcon": "GadgetHooks",
|
|
|
|
|
"getUserPermissionsErrors": "GadgetHooks"
|
2015-04-07 20:14:26 +00:00
|
|
|
},
|
2022-08-16 15:24:01 +00:00
|
|
|
"ServiceWiringFiles": [
|
|
|
|
|
"includes/ServiceWiring.php"
|
|
|
|
|
],
|
2015-08-03 06:37:32 +00:00
|
|
|
"config": {
|
2023-12-12 11:48:04 +00:00
|
|
|
"GadgetsRepo": {
|
|
|
|
|
"value": "definition"
|
2020-05-12 00:52:38 +00:00
|
|
|
},
|
|
|
|
|
"SpecialGadgetUsageActiveUsers": {
|
|
|
|
|
"value": true
|
|
|
|
|
}
|
2015-08-03 06:37:32 +00:00
|
|
|
},
|
2020-05-12 00:52:38 +00:00
|
|
|
"manifest_version": 2
|
2015-04-07 20:14:26 +00:00
|
|
|
}
|