2013-08-29 23:32:32 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Copyright © 2007 Daniel Kinzler
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
|
|
*
|
|
|
|
* @file
|
|
|
|
*/
|
2015-08-07 00:05:29 +00:00
|
|
|
use WrappedString\WrappedString;
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
class GadgetHooks {
|
|
|
|
/**
|
2016-10-06 16:16:15 +00:00
|
|
|
* PageContentSaveComplete hook handler.
|
2013-08-29 23:32:32 +00:00
|
|
|
*
|
|
|
|
* @param $article Article
|
|
|
|
* @param $user User
|
2016-10-06 16:16:15 +00:00
|
|
|
* @param $content Content New page content
|
2013-08-29 23:32:32 +00:00
|
|
|
* @return bool
|
|
|
|
*/
|
2016-10-06 16:16:15 +00:00
|
|
|
public static function onPageContentSaveComplete( $article, $user, $content ) {
|
2013-08-29 23:32:32 +00:00
|
|
|
// update cache if MediaWiki:Gadgets-definition was edited
|
|
|
|
$title = $article->getTitle();
|
2015-07-18 22:40:42 +00:00
|
|
|
$repo = GadgetRepo::singleton();
|
|
|
|
if ( $title->getNamespace() == NS_MEDIAWIKI && $title->getText() == 'Gadgets-definition'
|
|
|
|
&& $repo instanceof MediaWikiGadgetsDefinitionRepo
|
|
|
|
) {
|
|
|
|
$repo->purgeDefinitionCache();
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* UserGetDefaultOptions hook handler
|
|
|
|
* @param $defaultOptions Array of default preference keys and values
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function userGetDefaultOptions( &$defaultOptions ) {
|
2015-07-18 22:40:42 +00:00
|
|
|
$gadgets = GadgetRepo::singleton()->getStructuredList();
|
2013-08-29 23:32:32 +00:00
|
|
|
if ( !$gadgets ) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @var $gadget Gadget
|
|
|
|
*/
|
|
|
|
foreach ( $gadgets as $thisSection ) {
|
|
|
|
foreach ( $thisSection as $gadgetId => $gadget ) {
|
|
|
|
if ( $gadget->isOnByDefault() ) {
|
|
|
|
$defaultOptions['gadget-' . $gadgetId] = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* GetPreferences hook handler.
|
|
|
|
* @param $user User
|
|
|
|
* @param $preferences Array: Preference descriptions
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function getPreferences( $user, &$preferences ) {
|
2015-07-18 22:40:42 +00:00
|
|
|
$gadgets = GadgetRepo::singleton()->getStructuredList();
|
2013-08-29 23:32:32 +00:00
|
|
|
if ( !$gadgets ) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-12-28 10:25:47 +00:00
|
|
|
$options = [];
|
|
|
|
$default = [];
|
2013-08-29 23:32:32 +00:00
|
|
|
foreach ( $gadgets as $section => $thisSection ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
$available = [];
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @var $gadget Gadget
|
|
|
|
*/
|
|
|
|
foreach ( $thisSection as $gadget ) {
|
2015-08-03 06:34:16 +00:00
|
|
|
if ( !$gadget->isHidden() && $gadget->isAllowed( $user ) ) {
|
2013-08-29 23:32:32 +00:00
|
|
|
$gname = $gadget->getName();
|
|
|
|
# bug 30182: dir="auto" because it's often not translated
|
|
|
|
$desc = '<span dir="auto">' . $gadget->getDescription() . '</span>';
|
|
|
|
$available[$desc] = $gname;
|
|
|
|
if ( $gadget->isEnabled( $user ) ) {
|
|
|
|
$default[] = $gname;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ( $section !== '' ) {
|
|
|
|
$section = wfMessage( "gadget-section-$section" )->parse();
|
|
|
|
|
|
|
|
if ( count ( $available ) ) {
|
|
|
|
$options[$section] = $available;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
$options = array_merge( $options, $available );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$preferences['gadgets-intro'] =
|
2016-12-28 10:25:47 +00:00
|
|
|
[
|
2013-08-29 23:32:32 +00:00
|
|
|
'type' => 'info',
|
|
|
|
'label' => ' ',
|
2016-12-28 10:25:47 +00:00
|
|
|
'default' => Xml::tags( 'tr', [],
|
|
|
|
Xml::tags( 'td', [ 'colspan' => 2 ],
|
2013-08-29 23:32:32 +00:00
|
|
|
wfMessage( 'gadgets-prefstext' )->parseAsBlock() ) ),
|
|
|
|
'section' => 'gadgets',
|
|
|
|
'raw' => 1,
|
|
|
|
'rawrow' => 1,
|
2016-12-28 10:25:47 +00:00
|
|
|
];
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
$preferences['gadgets'] =
|
2016-12-28 10:25:47 +00:00
|
|
|
[
|
2013-08-29 23:32:32 +00:00
|
|
|
'type' => 'multiselect',
|
|
|
|
'options' => $options,
|
|
|
|
'section' => 'gadgets',
|
|
|
|
'label' => ' ',
|
|
|
|
'prefix' => 'gadget-',
|
|
|
|
'default' => $default,
|
2016-12-28 10:25:47 +00:00
|
|
|
];
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ResourceLoaderRegisterModules hook handler.
|
|
|
|
* @param $resourceLoader ResourceLoader
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function registerModules( &$resourceLoader ) {
|
2015-07-18 22:40:42 +00:00
|
|
|
$repo = GadgetRepo::singleton();
|
|
|
|
$ids = $repo->getGadgetIds();
|
2013-08-29 23:32:32 +00:00
|
|
|
|
2015-07-18 22:40:42 +00:00
|
|
|
foreach ( $ids as $id ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
$resourceLoader->register( Gadget::getModuleName( $id ), [
|
2015-08-03 06:37:32 +00:00
|
|
|
'class' => 'GadgetResourceLoaderModule',
|
|
|
|
'id' => $id,
|
2016-12-28 10:25:47 +00:00
|
|
|
] );
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
|
2015-06-17 18:21:27 +00:00
|
|
|
return true;
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* BeforePageDisplay hook handler.
|
|
|
|
* @param $out OutputPage
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function beforePageDisplay( $out ) {
|
2015-07-18 22:40:42 +00:00
|
|
|
$repo = GadgetRepo::singleton();
|
|
|
|
$ids = $repo->getGadgetIds();
|
|
|
|
if ( !$ids ) {
|
2013-08-29 23:32:32 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
$lb = new LinkBatch();
|
|
|
|
$lb->setCaller( __METHOD__ );
|
2016-12-28 10:25:47 +00:00
|
|
|
$enabledLegacyGadgets = [];
|
|
|
|
$typelessMixedGadgets = [];
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @var $gadget Gadget
|
|
|
|
*/
|
|
|
|
$user = $out->getUser();
|
2015-07-18 22:40:42 +00:00
|
|
|
foreach ( $ids as $id ) {
|
2015-08-03 06:37:32 +00:00
|
|
|
try {
|
|
|
|
$gadget = $repo->getGadget( $id );
|
|
|
|
} catch ( InvalidArgumentException $e ) {
|
|
|
|
continue;
|
|
|
|
}
|
2016-11-18 04:54:17 +00:00
|
|
|
$peers = [];
|
|
|
|
foreach ( $gadget->getPeers() as $peerName ) {
|
|
|
|
try {
|
|
|
|
$peers[] = $repo->getGadget( $peerName );
|
|
|
|
} catch ( InvalidArgumentException $e ) {
|
|
|
|
// Ignore
|
|
|
|
// @todo: Emit warning for invalid peer?
|
|
|
|
}
|
|
|
|
}
|
2013-08-29 23:32:32 +00:00
|
|
|
if ( $gadget->isEnabled( $user ) && $gadget->isAllowed( $user ) ) {
|
|
|
|
if ( $gadget->hasModule() ) {
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
if ( $gadget->getType() === 'styles' ) {
|
|
|
|
$out->addModuleStyles( Gadget::getModuleName( $gadget->getName() ) );
|
|
|
|
} elseif ( $gadget->getType() === 'general' ) {
|
|
|
|
$out->addModules( Gadget::getModuleName( $gadget->getName() ) );
|
2016-11-18 04:54:17 +00:00
|
|
|
// Load peer modules
|
|
|
|
foreach ( $peers as $peer ) {
|
|
|
|
if ( $peer->getType() === 'styles' ) {
|
|
|
|
$out->addModuleStyles( Gadget::getModuleName( $peer->getName() ) );
|
|
|
|
}
|
|
|
|
// Else if not type=styles: Use dependencies instead.
|
|
|
|
// Note: No need for recursion as styles modules don't support
|
|
|
|
// either of 'dependencies' and 'peers'.
|
|
|
|
// @todo: Emit warning for non-styles peer?
|
|
|
|
}
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
} else {
|
|
|
|
$out->addModuleStyles( Gadget::getModuleName( $gadget->getName() ) );
|
|
|
|
$out->addModules( Gadget::getModuleName( $gadget->getName() ) );
|
|
|
|
$typelessMixedGadgets[] = $id;
|
|
|
|
}
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
|
2015-08-07 00:05:29 +00:00
|
|
|
if ( $gadget->getLegacyScripts() ) {
|
|
|
|
$enabledLegacyGadgets[] = $id;
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-28 10:25:47 +00:00
|
|
|
$strings = [];
|
2015-08-07 00:05:29 +00:00
|
|
|
foreach ( $enabledLegacyGadgets as $id ) {
|
|
|
|
$strings[] = self::makeLegacyWarning( $id );
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
foreach ( $typelessMixedGadgets as $id ) {
|
|
|
|
$strings[] = self::makeTypelessWarning( $id );
|
|
|
|
}
|
2015-08-07 00:05:29 +00:00
|
|
|
$out->addHTML( WrappedString::join( "\n", $strings ) );
|
2013-08-29 23:32:32 +00:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-08-07 00:05:29 +00:00
|
|
|
private static function makeLegacyWarning( $id ) {
|
|
|
|
$special = SpecialPage::getTitleFor( 'Gadgets' );
|
2013-08-29 23:32:32 +00:00
|
|
|
|
2015-08-07 00:05:29 +00:00
|
|
|
return ResourceLoader::makeInlineScript(
|
2016-12-28 10:25:47 +00:00
|
|
|
Xml::encodeJsCall( 'mw.log.warn', [
|
2015-08-07 00:05:29 +00:00
|
|
|
"Gadget \"$id\" was not loaded. Please migrate it to use ResourceLoader. " .
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
'See <' . $special->getCanonicalURL() . '>.'
|
2016-12-28 10:25:47 +00:00
|
|
|
] )
|
2015-08-07 00:05:29 +00:00
|
|
|
);
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|
|
|
|
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
private static function makeTypelessWarning( $id ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
return ResourceLoader::makeInlineScript( Xml::encodeJsCall( 'mw.log.warn', [
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
"Gadget \"$id\" styles loaded twice. Migrate to type=general. " .
|
2017-02-15 21:23:25 +00:00
|
|
|
'See <https://www.mediawiki.org/wiki/RL/MGU#Gadget_type>.'
|
2016-12-28 10:25:47 +00:00
|
|
|
] ) );
|
Implement support for specifying type=styles
T87871 formally introduced the concept of a styles module,
which sets mw.loader.state to "ready" when loaded through addModuleStyles().
Previously, addModuleStyles couldn't safely do that because a module may
contain scripts also, in which case mw.loader must still load the (rest)
of the module (causes styles to load twice).
In MediaWiki core or extensions this is easily avoided by calling not
calling both addModules() and addModuleStyles().
For Gadgets we call both as a workaround to allow users to provide styles
(without a FOUC), but also to provide scripts+styles. Since we don't declare
which one is intended (and some gadgets do both), we loaded them both ways.
This will no longer be allowed in the future (see T92459).
The new 'type=styles' Gadget attribute promises to ResourceLoader that a
gadget only contains styles.
Impact:
* [Bug fix] When mw.loader requires a styles module that already loaded,
it will not load again.
* [Feature] It is possible for a general scripts+styles gadget to depend on
a styles gadget. Previously this caused the styles to load twice.
* Specifying type=styles will load the module through addModuleStyles() only.
Use this for modules that contain styles that relate to elements already
on the page (e.g. when customising the skin, layout, or article content).
* Specifying type=general will load the module through addModules() only.
Use this if your module contains both scripts and styles and the styles
only relate to elements created by the script. This means the styles do not
need to be loaded separately through addModuleStyles() and will not apply
to noscript mode.
Effective difference:
* Gadgets with only styles: We assume type=styles.
This fixes the main bug (styles loading twice) and requires no migration!
* Gadgets with only scripts: We assume type=general.
This requires no migration! (And: No more empty stylesheet request)
* Gadgets with scripts (with or without styles): We assume type=general, but
unless type=general was explicitly set we'll still load it both ways so
that the styles apply directly on page load.
If this is not needed, set type=general.
If this is needed, it should become two separate modules. We do not support
a single module having two purposes (1: apply styles to the page,
2: provide scripts+styles). The styles module should be separate.
It can be made hidden, and listed as dependency of the other module.
The latter case is detected on page load and results in a console warning
with a link to T42284.
Bug: T42284
Bug: T92459
Change-Id: Ia3c9ddee243f710022144fc2884434350695699a
2016-09-01 23:31:14 +00:00
|
|
|
}
|
2015-08-03 06:37:32 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Valid gadget definition page after content is modified
|
|
|
|
*
|
|
|
|
* @param IContextSource $context
|
|
|
|
* @param Content $content
|
|
|
|
* @param Status $status
|
|
|
|
* @param string $summary
|
|
|
|
* @throws Exception
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function onEditFilterMergedContent( $context, $content, $status, $summary ) {
|
|
|
|
$title = $context->getTitle();
|
|
|
|
|
|
|
|
if ( !$title->inNamespace( NS_GADGET_DEFINITION ) ) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ( !$content instanceof GadgetDefinitionContent ) {
|
|
|
|
// This should not be possible?
|
|
|
|
throw new Exception( "Tried to save non-GadgetDefinitionContent to {$title->getPrefixedText()}" );
|
|
|
|
}
|
|
|
|
|
|
|
|
$status = $content->validate();
|
|
|
|
if ( !$status->isGood() ) {
|
|
|
|
$status->merge( $status );
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* After a new page is created in the Gadget definition namespace,
|
|
|
|
* invalidate the list of gadget ids
|
|
|
|
*
|
|
|
|
* @param WikiPage $page
|
|
|
|
*/
|
|
|
|
public static function onPageContentInsertComplete( WikiPage $page ) {
|
|
|
|
if ( $page->getTitle()->inNamespace( NS_GADGET_DEFINITION ) ) {
|
|
|
|
$repo = GadgetRepo::singleton();
|
|
|
|
if ( $repo instanceof GadgetDefinitionNamespaceRepo ) {
|
|
|
|
$repo->purgeGadgetIdsList();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Mark the Title as having a content model of javascript or css for pages
|
|
|
|
* in the Gadget namespace based on their file extension
|
|
|
|
*
|
|
|
|
* @param Title $title
|
|
|
|
* @param string $model
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function onContentHandlerDefaultModelFor( Title $title, &$model ) {
|
|
|
|
if ( $title->inNamespace( NS_GADGET ) ) {
|
|
|
|
preg_match( '!\.(css|js)$!u', $title->getText(), $ext );
|
|
|
|
$ext = isset( $ext[1] ) ? $ext[1] : '';
|
|
|
|
switch ( $ext ) {
|
|
|
|
case 'js':
|
|
|
|
$model = 'javascript';
|
|
|
|
return false;
|
|
|
|
case 'css':
|
|
|
|
$model = 'css';
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Set the CodeEditor language for Gadget definition pages. It already
|
|
|
|
* knows the language for Gadget: namespace pages.
|
|
|
|
*
|
|
|
|
* @param Title $title
|
|
|
|
* @param string $lang
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function onCodeEditorGetPageLanguage( Title $title, &$lang ) {
|
|
|
|
if ( $title->hasContentModel( 'GadgetDefinition' ) ) {
|
|
|
|
$lang = 'json';
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-10-27 13:29:26 +00:00
|
|
|
/**
|
|
|
|
* Add the GadgetUsage special page to the list of QueryPages.
|
|
|
|
* @param array &$queryPages
|
|
|
|
* @return bool
|
|
|
|
*/
|
|
|
|
public static function onwgQueryPages( &$queryPages ) {
|
2016-12-28 10:25:47 +00:00
|
|
|
$queryPages[] = [ 'SpecialGadgetUsage', 'GadgetUsage' ];
|
2015-10-27 13:29:26 +00:00
|
|
|
return true;
|
|
|
|
}
|
2013-08-29 23:32:32 +00:00
|
|
|
}
|