mediawiki-extensions-Echo/tests/phpunit
Roan Kattouw 06f0a7a6d5 NotifUser: Remove basically-unused talk notification cache
This cache was only used so that, if we're told to clear the newtalk
flag and we already know there are no edit-user-talk notifications, we
won't try to delete them. But that's not a good justification for such a
confusingly-written cache that would have been hard to convert to
getWithSetCallback(), and I'm concerned that using cached data to make
this decision could lead to inconsistencies.

Also remove the notifCountHasReachedMax() check, which made no sense: if
the user has >99 notifications, that is no justification for not marking
their user talk notifications as read when they visit their user talk
page. Whether the displayed notification count will change has no
bearing on whether these notifications should be marked as read (and now
that bundled notifications are counted individually, the displayed count
actually could change).

Bug: T164860
Change-Id: I3ff5c9b31307839b9336bd8856015db9baa52fad
2018-08-09 16:34:04 -07:00
..
api
cache
controller
gateway
iterator
maintenance
mapper NotificationMapper: Use batching in deleteByUserEventOffset() 2018-08-08 14:57:58 -07:00
model
revision_txt
AttributeManagerTest.php
BundlerTest.php
ContainmentSetTest.php
DiffParserTest.php
DiscussionParserTest.php Use setContentLang instead of setMwGlobals 2018-07-25 19:12:09 +03:00
EchoDbFactoryTest.php
EchoSummaryParserTest.php
NotificationsTest.php
NotifUserTest.php NotifUser: Remove basically-unused talk notification cache 2018-08-09 16:34:04 -07:00
TalkPageFunctionalTest.php Re-enable test coverage reporting, add @covers tags 2018-06-28 08:32:57 -04:00
ThankYouEditTest.php Re-enable test coverage reporting, add @covers tags 2018-06-28 08:32:57 -04:00
UserLocatorTest.php