mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-09-24 18:59:40 +00:00
e3c4ddc1ae
The max-height of the notifications list was hardcoded to the height of the window minus 134 pixels. I don't know where this value came from, but it doesn't seem to take borders into account. The correct value appears to be 139 in Chrome and 140 in Firefox, so I changed it to 140. Also, this really really should not be a hardcoded value. This 140 value can be measured in JavaScript; that's how I derived it. Even better, oojs-ui has a mixin called OO.ui.ClippableElement that automatically does this for you AND automatically adjusts the height when the window is resized as well. Change-Id: I17bc2c5333e5c3d5dd720e6bccf8cbbdbb4abe6c |
||
---|---|---|
api | ||
controller | ||
db_patches | ||
formatters | ||
i18n | ||
includes | ||
jobs | ||
maintenance | ||
model | ||
modules | ||
scripts | ||
special | ||
tests | ||
.gitignore | ||
.gitreview | ||
.jshintignore | ||
.jshintrc | ||
COPYING | ||
Echo.alias.php | ||
Echo.i18n.php | ||
Echo.php | ||
echo.sql | ||
Gemfile | ||
Hooks.php | ||
Makefile | ||
Notifier.php | ||
package.json | ||
Resources.php |