mediawiki-extensions-Echo/includes/Formatters/EchoPresentationModelSection.php
Ammarpad 0a677f4675 fix ::getTruncatedSectionTitle() return type
This method can return false if getParsedSectionTitle() returns false

Both Language::embedBidi and Language::truncateForVisual return
non-string primitives unchanged if they're passed to them as first
argument.

Ideally the Language methods arguments should be string-typed but
I am not sure how easy that change would be now, so better to
document the possibility here.

Change-Id: I7e2856862d6508ecd1aa57ad99b92942bc4d7bed
2024-10-24 22:46:00 +00:00

143 lines
3.6 KiB
PHP

<?php
namespace MediaWiki\Extension\Notifications\Formatters;
use BadMethodCallException;
use MediaWiki\Extension\Notifications\DiscussionParser;
use MediaWiki\Extension\Notifications\Model\Event;
use MediaWiki\Language\Language;
use MediaWiki\Parser\Parser;
use MediaWiki\Revision\RevisionRecord;
use MediaWiki\Title\Title;
use MediaWiki\User\User;
/**
* Component that represents a section of a page to be used from EchoEventPresentationModel subclass.
*/
class EchoPresentationModelSection {
/**
* @var string|false|null
*/
private $rawSectionTitle = null;
/**
* @var string|false|null
*/
private $parsedSectionTitle = null;
/**
* @var Event
*/
protected $event;
/**
* @var User
*/
protected $user;
/**
* @var Language
*/
protected $language;
public function __construct( Event $event, User $user, Language $language ) {
$this->event = $event;
$this->user = $user;
$this->language = $language;
}
/**
* Get the raw (unparsed) section title
* @return string|false Section title
*/
protected function getRawSectionTitle() {
if ( $this->rawSectionTitle !== null ) {
return $this->rawSectionTitle;
}
$sectionTitle = $this->event->getExtraParam( 'section-title' );
if ( !$sectionTitle ) {
$this->rawSectionTitle = false;
return false;
}
// Check permissions
if ( !$this->event->userCan( RevisionRecord::DELETED_TEXT, $this->user ) ) {
$this->rawSectionTitle = false;
return false;
}
$this->rawSectionTitle = $sectionTitle;
return $this->rawSectionTitle;
}
/**
* Get the section title parsed to plain text
* @return string|false Section title (plain text)
*/
protected function getParsedSectionTitle() {
if ( $this->parsedSectionTitle !== null ) {
return $this->parsedSectionTitle;
}
$rawSectionTitle = $this->getRawSectionTitle();
if ( !$rawSectionTitle ) {
$this->parsedSectionTitle = false;
return false;
}
$this->parsedSectionTitle = DiscussionParser::getTextSnippet(
$rawSectionTitle,
$this->language,
DiscussionParser::DEFAULT_SNIPPET_LENGTH,
$this->event->getTitle(),
// linestart=false, because this wikitext was inside a heading like `== … ==`,
// so start-of-line markup like `*` should not be parsed (T299572)
false
);
return $this->parsedSectionTitle;
}
/**
* Check if there is a section.
*
* This also returns false if the revision is deleted,
* even if there is a section, because the section can't
* be viewed in that case.
* @return bool Whether there is a section
*/
public function exists() {
return (bool)$this->getRawSectionTitle();
}
/**
* Get a Title pointing to the section, if available.
* @return Title
*/
public function getTitleWithSection() {
$title = $this->event->getTitle();
if ( $title === null ) {
throw new BadMethodCallException( 'Event #' . $this->event->getId() . ' with no title' );
}
$section = $this->getParsedSectionTitle();
if ( $section ) {
$fragment = substr( Parser::guessSectionNameFromStrippedText( $section ), 1 );
$title = $title->createFragmentTarget( $fragment );
}
return $title;
}
/**
* Get truncated section title, according to user's language.
* You should only call this if EchoPresentationModelSection::exists returns true.
* @return string|false
*/
public function getTruncatedSectionTitle() {
return $this->language->embedBidi( $this->language->truncateForVisual(
$this->getParsedSectionTitle(),
EchoEventPresentationModel::SECTION_TITLE_RECOMMENDED_LENGTH,
'...',
false
) );
}
}
class_alias( EchoPresentationModelSection::class, 'EchoPresentationModelSection' );