mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-12-01 02:46:46 +00:00
bc3dabf828
assertEquals() does not compare the type. It can not only be a float, it can even be a string. E.g. 9 and '9' are considered equal. Worst case scenarios are: * 0 is considered equal to any "falsy" value, including the empty string. * 1 is considered equal to true. assertSame() does not have any of these confusing edge-cases. Change-Id: Ib6af0fefbbd8856adcf27844bb8ddd8e33ed3f9d
183 lines
5.1 KiB
PHP
183 lines
5.1 KiB
PHP
<?php
|
|
|
|
use Wikimedia\Rdbms\IDatabase;
|
|
|
|
/**
|
|
* @covers EchoUserNotificationGateway
|
|
*/
|
|
class EchoUserNotificationGatewayTest extends MediaWikiUnitTestCase {
|
|
|
|
public function testMarkRead() {
|
|
// no event ids to mark
|
|
$gateway = new EchoUserNotificationGateway(
|
|
User::newFromId( 1 ),
|
|
$this->mockMWEchoDbFactory(),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertFalse( $gateway->markRead( [] ) );
|
|
|
|
// successful update
|
|
$gateway = new EchoUserNotificationGateway(
|
|
User::newFromId( 1 ),
|
|
$this->mockMWEchoDbFactory( [ 'update' => true ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertTrue( $gateway->markRead( [ 2 ] ) );
|
|
|
|
// unsuccessful update
|
|
$gateway = new EchoUserNotificationGateway(
|
|
User::newFromId( 1 ),
|
|
$this->mockMWEchoDbFactory( [ 'update' => false ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertFalse( $gateway->markRead( [ 2 ] ) );
|
|
}
|
|
|
|
public function testMarkAllRead() {
|
|
// successful update
|
|
$gateway = new EchoUserNotificationGateway(
|
|
User::newFromId( 1 ),
|
|
$this->mockMWEchoDbFactory( [ 'update' => true ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertTrue( $gateway->markAllRead( [ 2 ] ) );
|
|
|
|
// null update
|
|
$gateway = new EchoUserNotificationGateway(
|
|
User::newFromId( 1 ),
|
|
$this->mockMWEchoDbFactory( [ 'update' => false ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertTrue( $gateway->markAllRead( [ 2 ] ) );
|
|
}
|
|
|
|
public function testGetNotificationCount() {
|
|
// unsuccessful select
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'selectRowCount' => 0 ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertSame( 0, $gateway->getCappedNotificationCount( DB_REPLICA, [ 'event_one' ] ) );
|
|
|
|
// successful select of alert
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'selectRowCount' => 2 ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertSame( 2, $gateway->getCappedNotificationCount( DB_REPLICA, [ 'event_one', 'event_two' ] ) );
|
|
|
|
// there is event, should return 0
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'selectRowCount' => 2 ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertSame( 0, $gateway->getCappedNotificationCount( DB_REPLICA, [] ) );
|
|
|
|
// successful select
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'selectRowCount' => 3 ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertSame( 3, $gateway->getCappedNotificationCount( DB_REPLICA, [ 'event_one' ] ) );
|
|
}
|
|
|
|
public function testGetUnreadNotifications() {
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'select' => false ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$this->assertEmpty( $gateway->getUnreadNotifications( 'user_talk' ) );
|
|
|
|
$dbResult = [
|
|
(object)[ 'notification_event' => 1 ],
|
|
(object)[ 'notification_event' => 2 ],
|
|
(object)[ 'notification_event' => 3 ],
|
|
];
|
|
$gateway = new EchoUserNotificationGateway(
|
|
$this->mockUser(),
|
|
$this->mockMWEchoDbFactory( [ 'select' => $dbResult ] ),
|
|
$this->mockConfig()
|
|
);
|
|
$res = $gateway->getUnreadNotifications( 'user_talk' );
|
|
$this->assertEquals( $res, [ 1 => 1, 2 => 2, 3 => 3 ] );
|
|
}
|
|
|
|
/**
|
|
* Mock object of User
|
|
*/
|
|
protected function mockUser( $group = 'echo_group' ) {
|
|
$user = $this->getMockBuilder( User::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$user->expects( $this->any() )
|
|
->method( 'getID' )
|
|
->will( $this->returnValue( 1 ) );
|
|
$user->expects( $this->any() )
|
|
->method( 'getOption' )
|
|
->will( $this->returnValue( true ) );
|
|
$user->expects( $this->any() )
|
|
->method( 'getGroups' )
|
|
->will( $this->returnValue( [ $group ] ) );
|
|
|
|
return $user;
|
|
}
|
|
|
|
/**
|
|
* Mock object of MWEchoDbFactory
|
|
*/
|
|
protected function mockMWEchoDbFactory( array $dbResult = [] ) {
|
|
$dbFactory = $this->getMockBuilder( MWEchoDbFactory::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$dbFactory->expects( $this->any() )
|
|
->method( 'getEchoDb' )
|
|
->will( $this->returnValue( $this->mockDb( $dbResult ) ) );
|
|
|
|
return $dbFactory;
|
|
}
|
|
|
|
protected function mockConfig() {
|
|
return new HashConfig( [
|
|
'UpdateRowsPerQuery' => 500,
|
|
] );
|
|
}
|
|
|
|
/**
|
|
* Returns a mock database object
|
|
* @return \Wikimedia\Rdbms\IDatabase
|
|
*/
|
|
protected function mockDb( array $dbResult = [] ) {
|
|
$dbResult += [
|
|
'update' => '',
|
|
'select' => '',
|
|
'selectRow' => '',
|
|
'selectRowCount' => '',
|
|
];
|
|
$db = $this->createMock( IDatabase::class );
|
|
$db->expects( $this->any() )
|
|
->method( 'update' )
|
|
->will( $this->returnValue( $dbResult['update'] ) );
|
|
$db->expects( $this->any() )
|
|
->method( 'select' )
|
|
->will( $this->returnValue( $dbResult['select'] ) );
|
|
$db->expects( $this->any() )
|
|
->method( 'selectRow' )
|
|
->will( $this->returnValue( $dbResult['selectRow'] ) );
|
|
$db->expects( $this->any() )
|
|
->method( 'selectRowCount' )
|
|
->will( $this->returnValue( $dbResult['selectRowCount'] ) );
|
|
$numRows = is_array( $dbResult['select'] ) ? count( $dbResult['select'] ) : 0;
|
|
$db->expects( $this->any() )
|
|
->method( 'numRows' )
|
|
->will( $this->returnValue( $numRows ) );
|
|
|
|
return $db;
|
|
}
|
|
|
|
}
|