mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-12-19 03:11:29 +00:00
7b1a9582b2
In EventMapperTest, suppress notifications created by calling getExistingTestPage. So far, this test only worked because the existing test page is created in addCoreDBData (and not inside the test), but this will no longer be the case after core change I308617427309815062d54c14f3438cab31b08a73. Clear the PageSaveComplete hook handlers to prevent that. DiscussionParser has a static cache of revision data that can become stale when data is deleted between tests (because revision IDs can be reassigned to different pages, similar to T344124). This cache seems needed, and converting the class to a service seems hard, so add the page title to the cache key to try and avoid collisions. This can still break if two tests are using the same page, which is hopefully quite unlikely. Change-Id: Ic4cbd8ff424e1260544ff9754e0c89dd4bb2f733
163 lines
3.7 KiB
PHP
163 lines
3.7 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Extension\Notifications\DbFactory;
|
|
use MediaWiki\Extension\Notifications\Mapper\EventMapper;
|
|
use MediaWiki\Extension\Notifications\Model\Event;
|
|
use Wikimedia\Rdbms\IDatabase;
|
|
|
|
/**
|
|
* @group Database
|
|
* @covers \MediaWiki\Extension\Notifications\Mapper\EventMapper
|
|
*/
|
|
class EventMapperTest extends MediaWikiIntegrationTestCase {
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$this->tablesUsed[] = 'echo_event';
|
|
$this->tablesUsed[] = 'echo_notification';
|
|
$this->tablesUsed[] = 'echo_target_page';
|
|
}
|
|
|
|
public static function provideDataTestInsert() {
|
|
return [
|
|
[
|
|
'successful insert with next sequence = 1',
|
|
[ 'insert' => true, 'insertId' => 1 ],
|
|
1
|
|
],
|
|
[
|
|
'successful insert with insert id = 2',
|
|
[ 'insert' => true, 'insertId' => 2 ],
|
|
2
|
|
]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideDataTestInsert
|
|
*/
|
|
public function testInsert( $message, $dbResult, $result ) {
|
|
$event = $this->mockEvent();
|
|
$eventMapper = new EventMapper( $this->mockDbFactory( $dbResult ) );
|
|
$this->assertEquals( $result, $eventMapper->insert( $event ), $message );
|
|
}
|
|
|
|
/**
|
|
* Successful fetchById()
|
|
*/
|
|
public function testSuccessfulFetchById() {
|
|
$eventMapper = new EventMapper(
|
|
$this->mockDbFactory(
|
|
[
|
|
'selectRow' => (object)[
|
|
'event_id' => 1,
|
|
'event_type' => 'test',
|
|
'event_variant' => '',
|
|
'event_extra' => '',
|
|
'event_page_id' => '',
|
|
'event_agent_id' => '',
|
|
'event_agent_ip' => '',
|
|
'event_deleted' => 0,
|
|
]
|
|
]
|
|
)
|
|
);
|
|
$res = $eventMapper->fetchById( 1 );
|
|
$this->assertInstanceOf( Event::class, $res );
|
|
}
|
|
|
|
public function testUnsuccessfulFetchById() {
|
|
$eventMapper = new EventMapper(
|
|
$this->mockDbFactory(
|
|
[
|
|
'selectRow' => false
|
|
]
|
|
)
|
|
);
|
|
$this->expectException( InvalidArgumentException::class );
|
|
$eventMapper->fetchById( 1 );
|
|
}
|
|
|
|
/**
|
|
* @return Event
|
|
*/
|
|
protected function mockEvent() {
|
|
$event = $this->createMock( Event::class );
|
|
$event->method( 'toDbArray' )
|
|
->willReturn( [] );
|
|
|
|
return $event;
|
|
}
|
|
|
|
/**
|
|
* @param array $dbResult
|
|
* @return DbFactory
|
|
*/
|
|
protected function mockDbFactory( $dbResult ) {
|
|
$dbFactory = $this->createMock( DbFactory::class );
|
|
$dbFactory->method( 'getEchoDb' )
|
|
->willReturn( $this->mockDb( $dbResult ) );
|
|
|
|
return $dbFactory;
|
|
}
|
|
|
|
/**
|
|
* @param array $dbResult
|
|
* @return IDatabase
|
|
*/
|
|
protected function mockDb( array $dbResult ) {
|
|
$dbResult += [
|
|
'insert' => '',
|
|
'insertId' => '',
|
|
'select' => '',
|
|
'selectRow' => ''
|
|
];
|
|
$db = $this->createMock( IDatabase::class );
|
|
$db->method( 'insert' )
|
|
->willReturn( $dbResult['insert'] );
|
|
$db->method( 'insertId' )
|
|
->willReturn( $dbResult['insertId'] );
|
|
$db->method( 'select' )
|
|
->willReturn( $dbResult['select'] );
|
|
$db->method( 'selectRow' )
|
|
->willReturn( $dbResult['selectRow'] );
|
|
|
|
return $db;
|
|
}
|
|
|
|
public function testFetchByPage() {
|
|
$user = $this->getTestUser()->getUser();
|
|
// Do not create a notification for the edit made by getExistingTestPage.
|
|
$this->clearHook( 'PageSaveComplete' );
|
|
$page = $this->getExistingTestPage();
|
|
|
|
// Create a notification that is not associated with any page
|
|
Event::create( [
|
|
'type' => 'welcome',
|
|
'agent' => $user,
|
|
] );
|
|
|
|
// Create a notification with a title
|
|
$eventWithTitle = Event::create( [
|
|
'type' => 'welcome',
|
|
'agent' => $user,
|
|
'title' => $page->getTitle()
|
|
] );
|
|
|
|
// Create a notification with a target-page
|
|
$eventWithTargetPage = Event::create( [
|
|
'type' => 'welcome',
|
|
'agent' => $user,
|
|
'extra' => [ 'target-page' => $page->getId() ]
|
|
] );
|
|
|
|
$eventMapper = new EventMapper();
|
|
|
|
$this->assertArrayEquals(
|
|
[ $eventWithTitle->getId(), $eventWithTargetPage->getId() ],
|
|
$eventMapper->fetchIdsByPage( $page->getId() )
|
|
);
|
|
}
|
|
|
|
}
|