wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Echo/includes
History
Edward Chernenko 87053b91a6 Be compatible with third-party extensions that use NewMessagesAlert 
1. Preamble:
Currently Extension:Echo unconditionally suppresses NewMessagesAlert,
because "You have new messages" is replaced by Echo notification.

2. Problem:
Some third-party extensions (such as Extension:Moderation) can use
GetNewMessagesAlert hook to inject their own notification, which must
not be suppressed.
By returning "false" from GetNewMessagesAlert hook, Echo stops those
third-party extensions from showing their notifications too.

3. Solution:
Allow those third-party extension to tell Echo "don't suppress this"
by returning false from the hook EchoCanAbortNewMessagesAlert.
This change has no impact on situations when no such third-party
extensions are installed.

4. How it was handled before this change:
Old solution for those extensions was to remove the hook of Echo from
$wgHooks, which was a dirty hack and is not compatible with T240307.

Change-Id: I433e30c5f639b5f20838804e8fa7c94a4bcf5349
2020-04-21 10:12:51 +03:00
..
api build: Updating composer dependencies 2020-02-19 20:20:29 +00:00
cache build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
controller Don't call mediawikiservices::getMainWANObjectCache if not needed 2020-03-08 10:00:28 +00:00
exception
formatters Add getter for EventPresentationModel::$distributionType 2020-04-05 19:00:16 +00:00
gateway Remove global usage in UserNotificationGateway 2019-08-30 22:58:41 +02:00
iterator build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
jobs Remove duplicate private property from NotificationDeleteJob 2019-10-31 18:18:08 +00:00
mapper build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
model Merge "Replace deprecated User::isAllowed with PermissionManager" 2020-03-24 21:00:09 +00:00
ooui build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 2020-01-14 05:09:44 +00:00
special Use WebRequest::getInt for limit parameter 2019-12-13 22:29:07 +01:00
AttributeManager.php Make use of the PHP 7 ?? operator where it makes sense 2019-05-09 15:57:16 +00:00
Bundleable.php Add strict "array" type hints to code expecting arrays 2019-10-24 15:18:58 +00:00
Bundler.php Add strict "array" type hints to code expecting arrays 2019-10-24 15:18:58 +00:00
DataOutputFormatter.php build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
DeferredMarkAsDeletedUpdate.php Merge "Make "@… array" type hints more specific" 2018-08-16 00:57:12 +00:00
DiscussionParser.php Replace deprecated User::isAllowed with PermissionManager 2020-03-14 19:14:37 +00:00
EchoArrayList.php Fix multiple PHP class declarations in one file 2018-01-21 21:17:53 +00:00
EchoCachedList.php Convert caching to WANObjectCache 2019-02-28 21:56:38 -08:00
EchoContainmentList.php Make "@… array" type hints more specific 2018-08-13 09:27:37 +02:00
EchoContainmentSet.php Convert caching to WANObjectCache 2019-02-28 21:56:38 -08:00
EchoDbFactory.php Add strict "array" type hints to code expecting arrays 2019-10-24 15:18:58 +00:00
EchoDiffGroup.php Make "@… array" type hints more specific 2018-08-13 09:27:37 +02:00
EchoDiffParser.php build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
EchoHooks.php Be compatible with third-party extensions that use NewMessagesAlert 2020-04-21 10:12:51 +03:00
EchoOnWikiList.php build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
EchoSummaryParser.php Replace two regular expressions with cheap string manipulations 2018-10-11 10:59:04 +02:00
EmailBatch.php build: Updating mediawiki/mediawiki-phan-config to 0.9.0 2019-12-29 11:59:32 +00:00
EmailFormat.php HTML email formatter using presentation model 2016-05-12 09:29:24 -04:00
EmailFrequency.php HTML email formatter using presentation model 2016-05-12 09:29:24 -04:00
EventLogging.php Code improvements for includes/ **only** directory 2019-03-05 18:58:52 +01:00
ForeignNotifications.php Use php null coalesce operator ?? 2019-03-12 21:04:00 +01:00
ForeignWikiRequest.php build: Updating mediawiki/mediawiki-phan-config to 0.8.0 2019-11-18 20:03:13 +01:00
Notifier.php build: Updating mediawiki/mediawiki-phan-config to 0.8.0 2019-11-18 20:03:13 +01:00
NotifUser.php Remove global usage in UserNotificationGateway 2019-08-30 22:58:41 +02:00
ResourceLoaderEchoImageModule.php Remove non helpful (auto-generated) comments 2019-10-23 12:31:35 +02:00
schemaUpdate.php Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass 2020-02-09 11:58:49 +01:00
SeenTime.php SeenTime: Do not set the cache key to Unix epoch 2019-10-18 14:23:28 +02:00
UnreadWikis.php Fix IDatabase::upsert() call with bad unique key parameters 2020-02-19 13:20:40 -08:00
UserLocator.php Remove usage of deprecated Revision class in Echo 2019-05-08 19:50:58 +01:00