mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-24 07:54:13 +00:00
5aaf6d26d8
When we are viewing a certain read state filter ('read' or 'unread')
the visibility of items should correspond to that state even when
the user marks a specific item as read/unread. That means that the
system should remove these items from view when the action is taken.
In this commit:
* The controller makes the judgment of whether to remove items when
read/unread action is taken, based on whether a filter is set.
* We clean up the terminology of discard - no more 'remove' - to
make sure we have consistency in the code.
* Related: The 'discard' event is now scoped within the hierarchy;
meaning, lists emit 'discard' when an item is removed, grouplist
emits 'discard' when a group is removed, and the manager emits
'discard' when an entire notification model is removed. This
means we can actually have proper hierarchy and organization with
a single event, and not worry about clashing between the intentional
'discard' action and the event 'remove' that is also used while
resorting happens.
* The model manager emits a discard event when a model is removed
so that the general list can listen to the manager and remove an
entire batch of items if needed.
* The pagination model now updates the count for the current page
rather than some vague notion of the last page. This is also
updated when the controller removes items, so we can get an
accurate count in the page for the number of notifications that
are displayed.
Bug: T136891
Change-Id: I247c618042ef256fadf09922f7b83bd1ad361f64
|
||
|---|---|---|
| db_patches | ||
| i18n | ||
| images | ||
| includes | ||
| maintenance | ||
| modules | ||
| scripts | ||
| tests | ||
| .csslintrc | ||
| .gitignore | ||
| .gitreview | ||
| .jscsrc | ||
| .jshintignore | ||
| .jshintrc | ||
| .mailmap | ||
| .rubocop.yml | ||
| autoload.php | ||
| composer.json | ||
| COPYING | ||
| Echo.alias.php | ||
| Echo.php | ||
| echo.sql | ||
| Gemfile | ||
| Gemfile.lock | ||
| Gruntfile.js | ||
| Hooks.php | ||
| jsduck.external.js | ||
| jsduck.json | ||
| jsduck_custom_tags.rb | ||
| Makefile | ||
| package.json | ||
| phpcs.xml | ||
| Rakefile | ||
| RELEASE_NOTES | ||
| Resources.php | ||