mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-12 09:26:05 +00:00
2142be10b0
* Reduce responsibility of resolve() methods to only supplying
the resolves values.
Moved logic for populating the cache and clearing the queue
to the base class, and made 'lookups' private.
* The second parameter to LocalCache::add() is unused, and never passed.
Removed to avoid confusion.
* The getTargets() method is unused. Removed.
* The getLookups() method is unused. Removed.
* The internal 'lookups' member was being used both for its keys and its
values, but never at the same time. This seemed risky, especially in
EchoRevisionLocalCache::resolve() where the associative array was passed
directly to the 'where' clause of IDatabase::select(), which shouldn't
espect keys when creating the 'IN' clause.
Using only values would keep value types flexible, but would require
use of the less efficient in_array().
Keeping both keys and values and calling array_values() would work.
Using only keys also works and is simpler, so long only ints are used.
* The tests were swapping 'targets' MapCacheLRU with a HashBagOStuff.
Following-up
|
||
---|---|---|
.. | ||
api | ||
cache | ||
controller | ||
exception | ||
formatters | ||
gateway | ||
iterator | ||
jobs | ||
mapper | ||
model | ||
ooui | ||
special | ||
AttributeManager.php | ||
Bundleable.php | ||
Bundler.php | ||
DataOutputFormatter.php | ||
DeferredMarkAsDeletedUpdate.php | ||
DiscussionParser.php | ||
EchoArrayList.php | ||
EchoCachedList.php | ||
EchoContainmentList.php | ||
EchoContainmentSet.php | ||
EchoDbFactory.php | ||
EchoDiffGroup.php | ||
EchoDiffParser.php | ||
EchoHooks.php | ||
EchoOnWikiList.php | ||
EchoSummaryParser.php | ||
EmailBatch.php | ||
EmailFormat.php | ||
EmailFrequency.php | ||
EventLogging.php | ||
ForeignNotifications.php | ||
ForeignWikiRequest.php | ||
Notifier.php | ||
NotifUser.php | ||
ResourceLoaderEchoImageModule.php | ||
schemaUpdate.php | ||
SeenTime.php | ||
UnreadWikis.php | ||
UserLocator.php |