mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-11-24 16:04:35 +00:00
06f0a7a6d5
This cache was only used so that, if we're told to clear the newtalk flag and we already know there are no edit-user-talk notifications, we won't try to delete them. But that's not a good justification for such a confusingly-written cache that would have been hard to convert to getWithSetCallback(), and I'm concerned that using cached data to make this decision could lead to inconsistencies. Also remove the notifCountHasReachedMax() check, which made no sense: if the user has >99 notifications, that is no justification for not marking their user talk notifications as read when they visit their user talk page. Whether the displayed notification count will change has no bearing on whether these notifications should be marked as read (and now that bundled notifications are counted individually, the displayed count actually could change). Bug: T164860 Change-Id: I3ff5c9b31307839b9336bd8856015db9baa52fad |
||
|---|---|---|
| db_patches | ||
| i18n | ||
| images | ||
| includes | ||
| maintenance | ||
| modules | ||
| scripts | ||
| tests | ||
| .eslintrc.json | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .phpcs.xml | ||
| .stylelintrc.json | ||
| CODE_OF_CONDUCT.md | ||
| composer.json | ||
| COPYING | ||
| Echo.alias.php | ||
| echo.sql | ||
| extension.json | ||
| Gruntfile.js | ||
| jsduck.external.js | ||
| jsduck.json | ||
| jsduck_custom_tags.rb | ||
| Makefile | ||
| package.json | ||
| RELEASE_NOTES | ||