wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-01 10:56:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
6194 commits 13 branches 19 tags 77 MiB
Commit graph

6194 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 7dbc4f6ce8 TalkPageFunctionalTest: Only count our own events 
We're working on code in DiscussionTools that generates Echo events for
adding talk page comments (I7e0996843cdd70141e19d5c7ce66122204efa1b7),
and it was causing this test to fail.

Change-Id: I3099473a3113962911b9c77ede290142857a51b2
 2021-03-04 16:29:57 +00:00
Translation updater bot 571437ec99 Localisation updates from https://translatewiki.net. 
Change-Id: I0a204af8356fa9d4e243f49399230fbc8e9574c4
 2021-03-04 08:38:05 +01:00
jenkins-bot c6e2651688 Merge "Set icon size in bundle to exactly 20x20" 2021-03-03 23:49:21 +00:00
Ed Sanders 2bbae62aa3 Set icon size in bundle to exactly 20x20 
1.5em would render as 21px in Vector and 19.05px in monobook.

Bug: T276114
Change-Id: Ie31f83e849ae5a4b17f28dfe6ccabc8a2005c919
 2021-03-03 23:19:44 +00:00
vladshapik 92d41cac00 Avoid using User::isBlocked 
Remove using of User:isBlocked since this method will be hard-deprecated. Now it is soft-deprecated

Bug: T276371
Change-Id: Ibcb9071ce2df2733ee5bd87e077b3c0d034d1212
 2021-03-03 21:39:10 +02:00
jenkins-bot 150fdba4cf Merge "Avoid using User ::getCanonicalName" 2021-03-01 20:16:02 +00:00
jenkins-bot 55942a49d2 Merge "Remove deprecated User method getGroups" 2021-03-01 19:59:35 +00:00
vladshapik e0d64d00d0 Avoid using User ::getCanonicalName 
Remove using of User::getCanonicalName since this method will be hard-deprecated. Now it is soft-deprecated

Bug: T275030
Change-Id: Id708800bc709de175bc7c6acc422368a734b00f1
 2021-03-01 19:50:14 +00:00
vladshapik 325f542d9c Avoid using User::addGroup 
Remove using of User::addGroup since this method will be hard-deprecated. Now it is soft-deprecated

Bug: T276094
Change-Id: Ib074ca906d31a02ca241296b32416ffb30e90e4f
 2021-03-01 17:01:31 +02:00
Translation updater bot 0b16eff940 Localisation updates from https://translatewiki.net. 
Change-Id: I289db7594067f16c9296a877d9cdd469dd884bec
 2021-03-01 08:51:32 +01:00
Jeena Huneidi 008ad5afe1 Remove deprecated User method getGroups 
Replaces the deprecated user method getGroups with
UserGroupManager->getUserGroups.

Bug: T275148
Change-Id: Ie6215886c911382008b667e8e5b3298facfcd6a2
 2021-02-26 21:47:58 -08:00
jenkins-bot ac8d21d2a1 Merge "Make AttributeManager a service" 2021-02-26 23:45:26 +00:00
Jeena Huneidi 596729d852 Make AttributeManager a service 
Adds AttributeManager to EchoServices so that dependencies of
AttributeManager can be injected.

Bug: T275148
Change-Id: I4fa5084d72914d16b6d218e7dd3521f5a1919b80
 2021-02-26 12:58:23 -08:00
Translation updater bot 73103f6e11 Localisation updates from https://translatewiki.net. 
Change-Id: Ic2bed633329cdbfc0f6f72a548641ded5a150ad7
 2021-02-26 08:56:12 +01:00
Translation updater bot 9428ab3e77 Localisation updates from https://translatewiki.net. 
Change-Id: I7dd9bdc0ba1fcf6ab702e996e974ca5b4ad6a3df
 2021-02-25 08:38:27 +01:00
vladshapik 107c0dfccd Avoid using User::IsIP 
Remove using of User::isIP since this method will be hard-deprecated. Now it is soft-deprecated

Bug: T275602
Change-Id: Ic1749cbad92bfe0eeae40736403fd5ceb6d504e8
 2021-02-24 15:31:50 +02:00
Translation updater bot fca6b71a44 Localisation updates from https://translatewiki.net. 
Change-Id: I255ba10e2585165e11b1c55fcdd8436d55e19632
 2021-02-24 08:51:21 +01:00
Ed Sanders c5aba7e62c UserLocator::locateUsersWatchingTitle: Avoid confusing re-use of variable name 
Change-Id: I5826fe7c4ecd15907dc63c5afd6e777637d32c8a
 2021-02-23 16:36:17 +00:00
Translation updater bot 9f13424ecc Localisation updates from https://translatewiki.net. 
Change-Id: I37935a35867dda68a5a65101b009f2444617807c
 2021-02-23 08:48:11 +01:00
Translation updater bot b3160603a2 Localisation updates from https://translatewiki.net. 
Change-Id: I091c82046f9b157cc788084986e61e37d0b91ce3
 2021-02-22 08:51:44 +01:00
Kosta Harlan 0805daf1c2 Echo::create: Convert UserIdentityValue to plain User 
Bug: T275161
Change-Id: I28c8494ee557a67ea54dcab2ea9955561e8c2472
 2021-02-18 20:31:35 -08:00
vladshapik aac1986c3b Clean up Title deprecated methods 
Replace hard deprecated getPreviousRevisionID method with RevisionLookup::getPreviousRevision method

Bug: T274151
Change-Id: Ia6ec1a4765ba5849b53919a6e9d73df7e839f6ed
 2021-02-18 14:45:20 +02:00
Translation updater bot 9ac3c667ba Localisation updates from https://translatewiki.net. 
Change-Id: I1acc88f793a493e39a91e59904155167663c5250
 2021-02-18 08:42:45 +01:00
Kosta Harlan 294ed3c2cb ForeignWikiRequest: Guard against bad response 
See also I4dde4e3bb4ff2ea8b7669bb18b2689410e5e7713

Bug: T274408
Change-Id: I3ab7d0a4b58a150fe940bc8441b5fb127142ad9f
 2021-02-17 10:11:10 +01:00
Translation updater bot e147f4fa5c Localisation updates from https://translatewiki.net. 
Change-Id: Ib2f4073cf980367efd1eb019e0de159ffcc1f31a
 2021-02-15 10:05:01 +01:00
Translation updater bot 492842eb31 Localisation updates from https://translatewiki.net. 
Change-Id: Id332ebf3f7ecaf35fc3335f747a085c7865e3ff0
 2021-02-12 08:51:30 +01:00
Translation updater bot e7599387e8 Localisation updates from https://translatewiki.net. 
Change-Id: I4fafbf6162815e081589649002e639c3111ef26d
 2021-02-11 08:38:38 +01:00
Translation updater bot 1d6a2bc5c7 Localisation updates from https://translatewiki.net. 
Change-Id: I1a478f4849c3d75d514040656b2c03cf137aaa86
 2021-02-08 08:40:36 +01:00
Translation updater bot 4c282cad25 Localisation updates from https://translatewiki.net. 
Change-Id: Ib9aec51910b5506f9f653db09a68bed426b194cd
 2021-02-05 08:46:53 +01:00
jenkins-bot ebad6f972a Merge "Remove wrong return null from function documentation" 2021-02-05 02:51:28 +00:00
Translation updater bot 9211924c81 Localisation updates from https://translatewiki.net. 
Change-Id: I5cc73e725e5d6320c739ba1099f1a643771605c1
 2021-02-04 08:39:23 +01:00
jenkins-bot fd61cf3082 Merge "Replace use of newMutableRevisionFromArray within new MutableRevisionRecord" 2021-02-03 22:52:56 +00:00
Umherirrender ddf5b4bd24 Remove wrong return null from function documentation 
Change-Id: I1a702bbdd4378a35216641ec73fbe318f02bde69
 2021-02-03 21:59:07 +01:00
jenkins-bot a517f9ed2a Merge "Use monitored getTestUser() in tests if possible" 2021-02-03 14:37:30 +00:00
jenkins-bot d833955062 Merge "eslint: Fix warnings" 2021-02-03 14:35:45 +00:00
Martin Urbanec 36c65d8fa8 Log ApiEchoUnreadNotificationPages bad responses 
ApiEchoUnreadNotificationPages::getUnreadNotificationPagesFromForeign we
sometime erroneous responses from the foreign wiki. We silently ignore
them since d8a4b6ba9, this add logging of the response payload.

Bug: T273479
Signed-off-by: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Change-Id: I4dde4e3bb4ff2ea8b7669bb18b2689410e5e7713
 2021-02-03 10:47:32 +01:00
jenkins-bot a44277aaf5 Merge "Add missing isset() check to ApiEchoUnreadNotificationPages" 2021-02-03 07:49:15 +00:00
jenkins-bot 4029279de1 Merge "Echo: Remove redundant cast" 2021-02-03 07:46:21 +00:00
Translation updater bot 2967f6cb45 Localisation updates from https://translatewiki.net. 
Change-Id: Id009de7bada31dbdfbf809c8f9fdfa56c81f6262
 2021-02-03 08:39:07 +01:00
Thiemo Kreuz d8a4b6ba91 Add missing isset() check to ApiEchoUnreadNotificationPages 
…::getUnreadNotificationPagesFromForeign().

I'm not 100% sure if this fixes the code in a way it is
supposed to work. However, I see that getFromForeign() is
called 3 times in existing code, and 2 of these places
already do an isset() check. It looks like it was just
forgotten here.

Even if there is another issue to fix here, this patch:
a) silences the error, and
b) gives us more useful debug output.

Bug: T273479
Change-Id: I257620f646196c0554b9d86c849a02f5a8b9519c
 2021-02-03 06:42:26 +00:00
Ammarpad 5b032f5589 Echo: Remove redundant cast 
User::getId() is typehinted to return int and so this cast is causing
Phan failure.

Note the method is deprecated but this patch is not meant to fix that.

Change-Id: I3b7ad419d7c28c3ad7144b8005f2fa387af58b0d
 2021-02-03 07:39:38 +01:00
Peter Ovchyn f352b3406c Replace use of newMutableRevisionFromArray within new MutableRevisionRecord 
Bug: T272560
Change-Id: I171537c3346a7dd4aeb4fc612d7dd9fba5d64679
 2021-02-02 22:42:06 +02:00
Ed Sanders bb1bd02bd6 eslint: Fix warnings 
* Load wikimedia/jsduck rules
* Add inline disables for compat
* Fix shadowed variables

Change-Id: I42234ab74f5007c16ff3960309335e715da76c1c
 2021-02-01 21:02:46 +00:00
Translation updater bot 025cd0f3ac Localisation updates from https://translatewiki.net. 
Change-Id: I755f87c17a936ef7c2e3db84024123abd333cc85
 2021-02-01 08:47:35 +01:00
jenkins-bot 0a93747175 Merge "build: Updating dependencies" 2021-01-29 19:12:49 +00:00
Thiemo Kreuz df6d65a6cf Use monitored getTestUser() in tests if possible 
Change-Id: I584d8883f14b2651927890d353b738a02771abea
 2021-01-29 18:00:57 +00:00
Thiemo Kreuz 0f954929a7 Remove comments that literally repeat the code 
This also fixes a remaining `var` that should be `private`.

Change-Id: Ifa37a097a9d60bd22a16bc626d4b4271b8df2da7
 2021-01-29 13:55:41 +01:00
libraryupgrader b49cebf8cb build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
  The following sniffs are failing and were disabled:
  * MediaWiki.Commenting.FunctionComment.WrongStyle

* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1
  The following rules are failing and were disabled:
  * compat/compat

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: Icc5ae88b205d4b122efef7aef2826eb334b27820
 2021-01-29 10:19:37 +00:00
Translation updater bot c6f29042bc Localisation updates from https://translatewiki.net. 
Change-Id: I6d2ebba04320b87bba0ee0a606c72dc137d4ac23
 2021-01-29 08:37:36 +01:00
jenkins-bot 8ef19fb332 Merge "Improve function and property documentation in tests" 2021-01-28 09:57:19 +00:00