New preference added so that user can set
* Displaying (n) total unread count in the title
* Displaying notification snippet for incoming notification
Bug: T229732
Change-Id: I35eb68dedf1e087b4668bfec404935f1244b3d0b
We didn't have any error handling for this scenario previously, but the
recent refactor of this code made it more obvious that it was missing.
Change-Id: I146de3ed2cde1a9bd553fc4825c0e4e06130de65
It became unused and was deprecated in 1ac72cc01a.
That was almost 4 years ago, back when these definitions were
in PHP instead of JSON.
Change-Id: Icbd5ee8df1fc339ffb2df9f05c35a9dcd545a3d1
As now polling is used to update the notification count on header icons.
If there are any new notifications then a snippet containing the header
part of the notification will appear using mw.notify().
Bug: T226130
Change-Id: Id38c8ebedebd4c68b9cef0635043d6f9304784dd
There's no real reason for these to be in MakeGlobalVariablesScript
because they don't really depend on the request context: they were being
omitted if the user was not logged in, but we can just check the user's
logged-in status in JS instead.
Bug: T221151
Change-Id: I2df6d7e061545d342bc3068dccd5ce2f6e85fe78
Remove wgEchoMaxNotificationCount and wgEchoPollForUpdates from the
startup module and put them in the ext.echo.init module.
Change-Id: I03f9a3953aa97ead1a29c13a992a02404a6d0b68
The hook (SpecialMuteModifyFormFields) is used to append
the option to mute/unmute echo notifications from a specified user.
Special:Mute handles posting and saving the fields, the only
requirement is that the field name is the same as the property
that wants to be modified, in this case 'echo-notifications-blacklist'
Bug: T220163
Depends-On: I2b3eee0802cb086091f35ecce13ae77a8e7d518d
Change-Id: I77b3ccfdce9b501eb8ecd58c0d7bbecb78029a7e
RevisionRecord::getComment() can return null. When it does, accessing
->text on it fails.
Bug: T226681
Change-Id: I069cd5d5bef51a3e2b8f4e7b50d478cf47f65e00
We currently poll for the count of notifications after some fixed amount of time even when the user is not using it.
There is no need to poll at same rate in that case and we can poll at slower rate.
The rate now is decreased by 5 times.
Bug: T227501
Change-Id: Id53a88e0d5659edb0dac77dd3e346e2d88e95f94
On certain special pages, either notification count in the title is not displayed or is displayed in an improper format.
This was because mediawiki.jqueryMsg is not loaded. This patch adds mediawiki.jqueryMsg as a dependency to ext.echo.init module
Bug: T225259
Change-Id: I6b76742b326d66ca08b4bf5c53ab95c4919249e7
There's no need to laod test classes, phpunit finds them
and it just makes $wgAutoloadClasses in production bigger with no value.
Also it makes moving tests around harder
Change-Id: I59ed7bb55cf6d57bdaf614476cf6db7640b1143b
Changed `selenium-daily` npm script to only run tests tagged `@daily`
and removed `it.skip` on tests failing in beta cluster.
Bug:T227009
Change-Id: Id2edbfd941df098d326fa30ed9dc9f68e228f021
* Adds notification count(alert+messages) to the title
* The count is updated immediately when notification count changes
* This functionality is feature flagged(wgEchoPollForUpdates)
Bug: T225259
Change-Id: Ic92c50d9885b0e4325b253338023d37adf8d35d0
Due to using ooui, and a lot of the styles being a lot more generic
in general these days for wider skin support, most of the skin
styles still included with Echo are no longer necessary or may even
be actively breaking things.
Remove a bunch of that, including some of the stuff for T226594 etc,
as we now have a more elegant solution in the skin itself.
Bug: T226684
Bug: T226594
Depends-On: I0ed21a78feb1b1298c30b969a1c80a4323e74043
Change-Id: Id3193a07f023eb0abc30fa24afe10da042fea876
Just reuse MonoBook's ui.overlay styles. Both skins are doing the
same thing with this regardless, hence why they have the same
problem without these styles.
Bug: T184295
Change-Id: Ide06d00a55f7f546462af951d97c73a649ebcc0b
Due to using ooui, and a lot of the styles being a lot more generic
in general these days for wider skin support, most of the skin
styles still included with Echo are no longer necessary or may even
be actively breaking things.
For Modern, basically just remove everything; nothing here seems to
apply anymore. Also frees us up to just fix the badge positioning
in the skin itself, and leave future maintenance up to the skin
maintainers, if anyone cares.
Bug: T226684
Change-Id: Id28bbc01b3b344dfeb39be1380a64c1368924289
As it stands currently, every language that uses different numerals than
English does has to override the echo-badge-count message to provide
their own version of "99+". If a language doesn't do that, numbers up to
99 will display using the correct numerals, but "99+" will be displayed
verbatim. Some affected languages have overridden this message, but most
haven't.
Instead, use "{{formatnum:99}}+" in the English message. This is a no-op
in English and other languages that use the same numerals as English,
but automatically converts the number 99 in languages that use different
numerals. This way the only languages that need to override the message
are ones that use a different symbol than "+" for expressing "or more".
Change-Id: I247260ed9bbb40cff88e5ab873072269221b0ad4
A positive text-indent causes horizontal scrollbars, so just hide the
screenreader text by making it transparent, and accept that we're going
to have the hover tooltip issue (T161302) in Monobook.
Bug: T226594
Change-Id: I6cb9ec146c2b469cbfb1fdc57937794d237e46db
