Commit graph

78 commits

Author SHA1 Message Date
Roan Kattouw d0714b2928 NotifUser: Simplify function signatures for getNotificationCount() and friends
The $cached and $dbSource parameters are now unused, so remove them.
This affects get{Notification,Alert,Message}Count and
getLastUnread{Notification,Alert,Message}Time.

There are some callers in other extensions and in skins, but none of
them pass any parameters (except one, which I fixed in Ice42930280da).

Change-Id: If6f10c4f163ecb1def5a150656a60d1ab5f44d52
2018-06-05 01:07:23 +00:00
Umherirrender b2b6d8b420 Change DO_MAINTENANCE to RUN_MAINTENANCE_IF_MAIN
As suggested in 26505b170adb24a6ae68945920db322c9382e470 for better
readability. Also the sniff now knows about the maintenance script

Change-Id: If3ab122c1fc12fcfbce777881ca21ecd99fb2a70
2018-03-17 21:55:20 +01:00
Stephane Bisson ca27299f51 Format user-rights reason as plain text
Format user-rights reason as plain text
in both web and email since links
in notification body are not supported.

Bug: T172636
Change-Id: Ief5ff0aff18aad070f4388e075b5aae072d8f101
2018-01-09 08:41:21 -05:00
Amir Sarabadani 30a5b88ea1 Use ExtensionRegistry instead of class_exists
Bug: T183096
Change-Id: I963704cdcfdbc97727f435eb16998c16c692ed01
2017-12-29 00:12:30 +01:00
jenkins-bot 0c5694802b Merge "Update for deprecation of selectFields() methods" 2017-10-30 23:20:37 +00:00
David Barratt 019d10b69d Use centralIdsFromNames() method to get central ids.
The centralIdsFromNames() includes optimizations and error checking
that was not in the original version.

Bug: T178313
Change-Id: I3d6334f2e81f3cee66b36690734f70958fdcefdb
2017-10-16 18:14:31 -04:00
Brad Jorsch 93136b71ac Update for deprecation of selectFields() methods
Various selectFields() methods were deprecated in MediaWiki core change
Idcfd1556, replaced with getQueryInfo() methods.

Change-Id: I5d62ad76fdb64a9c6efd228f27e9b5f512f17d5e
Depends-On: Idcfd15568489d9f03a7ba4460e96610d33bc4089
2017-10-12 16:04:15 -04:00
Antoine Musso 2034f73f33 updatePerUserBlacklist wfWaitForSlaves()
Commit a live hack. Master branch would have to be updated.

Bug: T173475
Bug: T177437
Change-Id: I80bec4ed0d92e04eed311b4e0d906ead7432abe8
2017-10-09 20:09:43 +00:00
David Barratt a7cc2c4827 Use main Database Connection for Maintenance Script
To access user_properties in the WMF cluster, we must use the standard database connection instead of the echo connection.

Bug: T173475
Change-Id: Ic7344e4521b30055f7986aefd61712e6c6a0052c
2017-10-05 16:45:02 -04:00
David Barratt 3ba76f7faa Use User Ids instead of User Names for Echo Mute
The echo mute list uses user names which are not stable. User ids should be used instead.

Bug: T173475
Change-Id: I947bcf37a8f85aaa105776d368dbd0ab76823aeb
2017-10-02 19:39:40 -04:00
libraryupgrader 7a23ddf4b0 build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
Change-Id: I7b19fab3b1100c4973600ec95ee24160e141c5ac
2017-09-24 09:49:43 +00:00
Kunal Mehta aaf061c725 build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ExtraParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment

Change-Id: I8401abf121a7413fa191d7bc535e0ddd6cf8c3f7
2017-06-22 14:13:28 +00:00
Stephane Bisson 577d6b39b8 Fix generation of sample 'reverted' notifications
Follow-up to Id539a7db8d8f5e902177845bd212b4d6c2500f89

Pass the revision id instead of populating the request
object.

Change-Id: I4567d8b08999558d86c48aea5912de0e52bcf241
2016-12-21 12:29:04 -05:00
James D. Forrester 8c810dff48 build: Update mediawiki/mediawiki-codesniffer to 0.7.1
Also added "composer fix" command.

Change-Id: I25cb61b3b92798f1259d1575a336e2b056d5764f
2016-12-05 15:54:30 -08:00
Justin Du a0fe35a95d Update Maintenance scripts to use $this->requireExtension()
* Also added $this->mDescription to removeInvalidNotification

Bug: T152139
Change-Id: I146405a3b6e81680b0ee1fb081486170d914a2b1
2016-12-05 15:54:30 -08:00
Reedy 0cf447f20c Replace ArticleSaveComplete hook usage
Bug: T147559
Change-Id: Ia020095ff17c993b579ada9717bf1feb43ddb8ff
2016-10-06 17:23:09 +01:00
Stephane Bisson b3c07eedeb Remove etp_user
Target page entries used to exist for each user
that was notified for an event. They were
removed as the notifications were marked as read.

Now they remain so that the association between
pages and events can be used for moderation
regardless of the notifications read status.

This patch removes everything about
echo_target_page.etp_user from sql and php code.

Bug: T143959
Change-Id: Ib57510e6b0e9202a7e035f8ea59955dca8a0b24a
2016-09-09 09:32:28 -04:00
Matěj Suchánek 23f243a9a6 Generate sample notifications for Wikibase
Bug: T110604
Change-Id: I6e6817f80bbf8a8c28cfa59efdf424f736bb4e33
2016-08-04 16:49:06 +00:00
Stephane Bisson c24e029378 Generate sample notifications: Education Program
Change-Id: I1ca832d181ba8704a200fee78a84b3ec70106bed
2016-07-29 11:52:17 -04:00
Stephane Bisson c62c334ee2 Generate sample events: add 'reason' to user-rights
Change-Id: I7f8370816f57f26aafde7d46ea36253f7f4ee96e
2016-07-28 16:56:23 +00:00
jenkins-bot 68f8f589a3 Merge "Generate notifications: fix rollback session failure" 2016-07-19 21:23:15 +00:00
Matthew Flaschen ed626af0ad backfillUnreadWikis: Skip updateCount if race condition detected
Related doc fixes

Change-Id: I1b7545d2f86ec87e9701811ac5f4db0fec690681
2016-07-18 20:58:48 -04:00
Stephane Bisson 4e8e5a794f Generate notifications: fix rollback session failure
Change-Id: Ifbd90549accdbd0edeb979d27583e8f03f1366e5
2016-07-12 09:20:58 -04:00
Matthias Mullie 620d50f23f Change wfWikiId (lowercase d) to wfWikiID (uppercase D)
PHP can handle incorrect capitalization, but we should use the correct function
name.

Change-Id: I6db9bb90a8573f65cde503b771c9539faf38e75e
2016-06-29 15:11:21 +02:00
jenkins-bot 2eabf079f8 Merge "Clean up and fix updateEchoSchemaForSuppression.php" 2016-06-23 20:38:04 +00:00
Roan Kattouw 1d05d9298c backfillUnreadWikis.php: Add rebuild mode
In rebuild mode, we only process users who already have
a row in the euw table. This reduces the number of users
we have to process significantly. Thanks to Stephane
for this idea.

Also, don't force a recache of the alert and message counts,
it's OK to fetch them from cache. We also don't need to invalidate
any caches in this script, because the transition flag from
Ibcc8ac102 will ensure that the cached global counts are
correct.

Change-Id: I69c54cac47468647df2778b2d82f1b5dd9e574d3
2016-06-17 16:02:01 +01:00
Catrope 2771b94af7 Revert "Implement backfillUnreadWikis.php in terms of resetNotificationCount()"
Better idea: invalidate caches in this script, and write
a separate script to recompute existing euw rows.

This reverts commit c83af257d2.

Change-Id: I57bccfb726eada646cb318206d9091a20d59dcf5
2016-06-17 13:43:29 +00:00
Stephane Bisson 8520074d28 Maintenance script generates edit-thank notifications
Bug: T120152
Change-Id: I896fc133b781180b3bb8f1fbd2addaa99f9dc653
2016-06-16 17:46:51 +01:00
Stephane Bisson e8bc56e5d9 Don't set title for user-rights notifications
Same as I584c1150e4c98bb814e30bf6a6d3eb3e49ef6408
for the notifications generation script.

Change-Id: I3b13db662671a9e57f944171108a3b48544f784a
2016-06-14 10:38:41 -04:00
jenkins-bot d3e1846666 Merge "Implement backfillUnreadWikis.php in terms of resetNotificationCount()" 2016-06-11 15:54:55 +00:00
jenkins-bot 59473cc73a Merge "Add script to remove orphaned event rows" 2016-06-09 17:09:56 +00:00
Roan Kattouw c83af257d2 Implement backfillUnreadWikis.php in terms of resetNotificationCount()
This causes it to update the notification count cache as well.
Should we perhaps rename it to recacheNotificationCounts.php?

Bug: T132954
Change-Id: I540c4296f4fbadcf2267d77b53f71ee5c2eb8b52
2016-06-08 16:16:37 +02:00
Roan Kattouw 4c6cadfb27 Add script to remove orphaned event rows
Bug: T136425
Change-Id: Id42a893be81176f37d9d5e3fd7e850d3a6d42e10
2016-06-07 23:34:53 +02:00
Stephane Bisson 5072e87c0b backfillReadBundles.php: Use sub-select to target rows to update
UPDATE based on (user,display_hash) index

Bug: T136368
Change-Id: If3348c2e663517b632c9ff3194dd4a197c74159b
2016-06-07 14:01:32 +00:00
Roan Kattouw 99377e5525 Clean up and fix updateEchoSchemaForSuppression.php
This script was supposed to be run in production in 2013, but that
never happened. It was also never added to update.php.

* Use makeTitleSafe instead of newFromText, for correctness
* Fetch the columns that the update generator needs
* Replace wrapper for private method with closure
* Make the maintenance script logged

Bug: T136427
Bug: T50059
Change-Id: I6c2972120189f035483b5ca49610c008c4ba2c88
2016-06-06 23:56:28 +02:00
Roan Kattouw ca598c3420 backfillUnreadBundles.php: Use the correct database
Change-Id: Id2706b3baa410b7f42b8c7febdb96cd142558988
2016-06-06 21:11:19 +02:00
Stephane Bisson b3d168964c Maintenance: Backfill read timestamp on bundled notifications
This maintenance script sets the correct read_timestamp
on notifications that have been read as part of a
bundle.

Bug: T136368
Change-Id: I735fb230a14f95e0a983e733ec160eb8811b3197
2016-06-02 13:42:09 -04:00
Roan Kattouw 0807c3c5ad NotifUser: Refactor getNotificationCount() and friends, add caching for global counts
Previously, getNotificationCount() only looked at local notifications,
and foreign notifications were added in separately by getMessageCount()
and getAlertCount(). This didn't make any sense and resulted in
counter-intuitive things like I4d49b543.

Instead, add a $global flag to getNotificationCount(). If $global=false,
the local count is returned as before, but if $global=true, the
global count (=local+foreign) is returned. If $global is omitted,
the user's cross-wiki notification preference determines which is returned.

Update getLastUnreadNotificationCount() in the same way, since it had
the same issues.

Also add caching for global counts and timestamps, using a global
memc key.

Bug: T133623
Change-Id: If78bfc710acd91a075771b565cc99f4c302a104d
2016-05-02 16:16:57 -07:00
Stephane Bisson 9d6e6528ba Support generating sample notifications by types
Also added the force (-f) option to
bypass the confirmation. Very useful
when using the script in a loop.

Change-Id: I98c3e0408033903f8e2fb0afab773d4952a4e6d3
2016-03-02 15:04:56 -05:00
Stephane Bisson 74879c39fb Truncate secondary link labels
Bug: T121822
Change-Id: I3e36a6cd4bc8da96879158e1d7b65fd3a1d582fb
2016-02-18 06:55:36 -05:00
Stephane Bisson 467eeaf2e9 generateSampleNotifications.php: Generate OpenStackManager notifications
Change-Id: Iaddfa08e42735fd6befbe4c7b3e54b3f4e7f62d9
2016-02-15 19:55:47 +00:00
Stephane Bisson 88b16a0c81 Generate bundled page-linked notifications in test script
Change-Id: I6414c920e3a29ea5048819433aa86f41d8f54e69
2016-02-12 14:45:32 -05:00
jenkins-bot 9c7c869a29 Merge "Generate CX notifications in maintenance script" 2016-02-12 19:38:12 +00:00
Stephane Bisson 442f812774 Add subject to email notification body
Bug: T121831
Change-Id: Ib1a9212202d2c84de8d968d043f65e24b2d94fae
2016-02-10 12:34:26 -05:00
Stephane Bisson 522a79393d Generate CX notifications in maintenance script
Change-Id: Iec2f4b9d0815da1bf8ccdd5610f403133eeb4262
2016-02-08 10:37:49 -05:00
Stephane Bisson cbe602ee64 Generate sample notifications
Maintenance script that generates sample
notifications for Echo.

Change-Id: I5c88920a417a04cfd06d281f23b4c77368091776
2016-01-28 10:45:57 -05:00
Roan Kattouw 9f7fba935f Add progress markers to backfillUnreadWikis.php
Change-Id: I43fe3d9998b5ebf3ddbec9ced0394c70293b6f18
2016-01-18 19:14:34 -08:00
jenkins-bot 027e9b7431 Merge "Backfill echo_unread_wikis table" 2016-01-11 22:31:38 +00:00
Aaron Schulz 576303e03a Use Maintenance DB transaction methods
Change-Id: I0acde61f57240c95d8f2b8afd55bffbe7b5b98fb
2015-12-31 15:12:05 -08:00
Matthias Mullie ecd150888e Backfill echo_unread_wikis table
Bug: T119523
Change-Id: I13a7d349e7e3a66eb4e9ea3b26578fdd877e83a6
2015-12-16 19:52:16 +01:00