Commit graph

2316 commits

Author SHA1 Message Date
Roan Kattouw 0feccf98f8 Comment out presentation model for mentions since it fatals on deleted pages
Bug: T116888
Change-Id: I93361fb0fc809e9fd4173710d86d824c0a6adefe
2015-10-27 23:44:57 -07:00
jenkins-bot 412a7f9145 Merge "Fix page-linked notifications" 2015-10-28 01:37:53 +00:00
Kunal Mehta 20be6beb7c Fix page-linked notifications
This hook is now executed through the job queue, so $wgUser will not
accurately be set.

This depends upon I083736a174b6 in MediaWiki core to actually work.

Bug: T116485
Change-Id: I176fec492d136b097ada79a308e6822832705472
2015-10-27 16:17:25 -07:00
Translation updater bot 3af620871e Localisation updates from https://translatewiki.net.
Change-Id: Ia47ccd3df69c8fb08e142e1b6de510c9d3a23719
2015-10-27 21:31:59 +01:00
Translation updater bot f09140a9ad Localisation updates from https://translatewiki.net.
Change-Id: I73005ab74fa9c0e521aca7d04d450466d756bf6f
2015-10-26 21:02:51 +01:00
jenkins-bot af48842013 Merge "API: Remove pre-1.25 compat code" 2015-10-26 17:53:24 +00:00
jenkins-bot c0c4e20a2c Merge "ApiEchoNotifications: Remove unused variable" 2015-10-26 17:53:21 +00:00
jenkins-bot 8c8ba6e49f Merge "Don't use $wgLang in DataOutputFormatter" 2015-10-26 17:50:50 +00:00
jenkins-bot c9448290c5 Merge "Require $user parameter in DataOutputFormatter::formatOutput()" 2015-10-26 17:47:19 +00:00
Kunal Mehta 1a72434c62 API: Remove pre-1.25 compat code
We already require at least 1.26.

Change-Id: I09ca09fd06fdbf0b367f8a454898c6b7992be42d
2015-10-26 08:41:57 -07:00
Kunal Mehta c8329a728e ApiEchoNotifications: Remove unused variable
Change-Id: I4fe3b7b162c552d8db0ac5bba8b431339cdd137f
2015-10-26 08:39:34 -07:00
Kunal Mehta 1f366807d6 Don't use $wgLang in DataOutputFormatter
Require callers to pass it in.

Change-Id: I94ec940495a681151b289294186121462d4b5b5c
2015-10-26 08:37:57 -07:00
Kunal Mehta f40ef7019f Require $user parameter in DataOutputFormatter::formatOutput()
All callers already pass it.

Change-Id: Ic99893f53d6379a3fbbc2a45193e6804264ff7b7
2015-10-26 08:34:51 -07:00
Translation updater bot 7083c0ebfa Localisation updates from https://translatewiki.net.
Change-Id: I35b9f14b1f756c280eaab50e241a09b558789d9f
2015-10-25 22:03:52 +01:00
jenkins-bot 0beefa78c3 Merge "Clean up and refactor formatting system" 2015-10-23 23:20:00 +00:00
Stephane Bisson ba2d072255 Browser tests: using mw_selenium 1.5 because 1.6 is broken
mw_selenium errors out with undefined method `last_session_ids='
when run in jenkins.

Bug: T114368
Change-Id: Ie4d1b15be3b12694d9adba8747f1457f43ead57c
2015-10-23 11:53:34 -04:00
Translation updater bot c8054b2bcb Localisation updates from https://translatewiki.net.
Change-Id: I38f6cdd32ee2a2757c4bf96a4134f791029a953a
2015-10-22 21:59:45 +02:00
Kunal Mehta 7f6f6536ed EventLogging: Make sure eventId is an integer
Bug: T116205
Change-Id: Ifb9119cbd24b58f24a0eaa0a17a1345220374a4a
2015-10-21 11:08:50 -07:00
Translation updater bot 4bb180103b Localisation updates from https://translatewiki.net.
Change-Id: I10382d49cd182b0aee3722a77f0a0911ed43a5f2
2015-10-20 22:46:41 +02:00
Translation updater bot 31110911ea Localisation updates from https://translatewiki.net.
Change-Id: Ie889ecee7bd344d34dfb6485e3f709d5deaa3e35
2015-10-19 22:15:20 +02:00
Kunal Mehta 56c4b95087 Clean up and refactor formatting system
The workflow to format a notification is
* Get EchoEvent, User, and Language
* Get EchoEventFormatter implementation for notification type
** EchoEventFormatter returns structured data about each part of the
notification (header, body, primary link, secondary link(s))
* Each output type will have a formatter class (e.g.
EchoSpecialNotificationsFormatter, EchoPlainTextEmailFormatter) which
takes a EchoEventPresentationModel and generates whatever it wants
(HTML, plain-text email, etc).

Included is an example conversion of the user-rights and mention
formatters. The previous infrastructure will remain in place for
backwards compatability until other extensions can be updated.

Bug: T107823
Change-Id: I4397872a7ec062148dfcb066ddd8ab83f40486ac
2015-10-19 10:00:23 -07:00
Translation updater bot 7a7f0495ff Localisation updates from https://translatewiki.net.
Change-Id: Icd7f653507a8b52d044ff101a1cabffd1cc82dfa
2015-10-18 21:54:33 +02:00
Kunal Mehta 8cfb10766b SECURITY: Handle suppressed usernames in non-revision based events
We only track revisions for some notification types, others still
reference usernames, but don't check for suppression status. If no
revision is available, use User::isHidden() to check whether
EchoEvent::getAgent() has been hidden.

Bug: T110553
Change-Id: I31e635e365bbb0f6c6ac63be2bdb07e5e2d67c96
2015-10-16 14:56:43 -07:00
Translation updater bot 28348f2f9c Localisation updates from https://translatewiki.net.
Change-Id: I7d131c25b9fcb1aa6665aeed9e58565ab6b33e94
2015-10-15 21:31:33 +02:00
Translation updater bot 2667e50538 Localisation updates from https://translatewiki.net.
Change-Id: I72d88c3955e9e55e95d4a02ba3df728f4220df24
2015-10-15 09:41:27 +02:00
Translation updater bot 164dd2a886 Localisation updates from https://translatewiki.net.
Change-Id: I37689ce4a5b10397e777847ae983bd6eae5f6c5f
2015-10-14 21:51:55 +02:00
Translation updater bot 1000402461 Localisation updates from https://translatewiki.net.
Change-Id: Ibefb3d256666cc778eaca6394f9ea909efa077e3
2015-10-13 22:10:28 +02:00
jenkins-bot 14a5bc371d Merge "Add browser test for notifications in Echo" 2015-10-13 17:29:02 +00:00
Paladox 3dbe5bb0ec Add composer.json
This add php parallel lint test. Can be triggered using the entry
point:

 composer test

That ease Jenkins integration and let developers add more testing
utilities as needed.

Change-Id: I2bf0dbea9f559267001eb727c7ecfeb103717464
2015-10-13 09:48:03 +00:00
jenkins-bot 49ec566a10 Merge "Support UserMerge into anonymous user" 2015-10-12 20:26:44 +00:00
Translation updater bot 66605c8696 Localisation updates from https://translatewiki.net.
Change-Id: I4f03b22a4074893c260dc2766860ddc14852223b
2015-10-12 21:04:03 +02:00
Edward Chernenko 5189fc0ff2 Support UserMerge into anonymous user
When UserMerge is used to merge an account into anonymous user,
we shouldn't attempt to operate on MWEchoNotifUser for $newUser,
as it would cause an exception.

Change-Id: I726e6115d2c30e1579dae55e57cc800aa61d9d7c
2015-10-12 18:34:01 +03:00
Translation updater bot 49a2a325e8 Localisation updates from https://translatewiki.net.
Change-Id: Ifa9acd68330ca07d40ed19bbacdb000a33515237
2015-10-11 21:22:39 +02:00
Kunal Mehta f0b5b64328 build: Updating development dependencies
* grunt-banana-checker: 0.2.2 → 0.4.0

Change-Id: I7e0eed45794f9188e8d537c60ac8fa04af6bf1f0
2015-10-11 11:43:43 -04:00
Translation updater bot 5b0e23b39e Localisation updates from https://translatewiki.net.
Change-Id: I8d29f328fc9bdb18ede71f090be61573a6bc6e27
2015-10-10 22:42:06 +02:00
jenkins-bot 8feb8212ce Merge "Override footer buttons hover color in Modern" 2015-10-09 06:29:22 +00:00
Moriel Schottlender 9f1bedda1c Override footer buttons hover color in Modern
In Modern, the hover color for links in the #p-personal bar is
white, which is unhelpful for the buttons in the popup. Override
that style for hover.

Bug: T114080
Change-Id: I8b739f2a46c3eb3ce9f61e92b5025751047a451d
2015-10-08 16:28:30 -07:00
Roan Kattouw 877e621a6a Fix various bugs in mw.echo.Logger and its callers
* Fix typo that caused logInteraction() to never do anything
* Fix incorrect context parameter passed by NotificationBadgeWidget
* Consistently use mw.Echo.Logger.static.context.* constants for the
  context parameter everywhere

Bug: T114833
Change-Id: I140e4222169ad9e78c6bf016d9765828513adcbb
2015-10-08 15:20:31 -07:00
jenkins-bot bb89634306 Merge "NotificationBadgeWidget: Fix alignment of actions buttons" 2015-10-08 21:49:24 +00:00
Ed Sanders 017ee20365 NotificationBadgeWidget: Fix alignment of actions buttons
Making padding equal on either side, and use display:block
to avoid extra space underneath.

Bug: T115052
Change-Id: Icddb755cfe8892422661712d35eda4f01441207d
2015-10-08 21:15:54 +00:00
Translation updater bot 935a935b2c Localisation updates from https://translatewiki.net.
Change-Id: I6dc070cb08bb96667cd63cc48ec7d2dd2292180e
2015-10-08 23:06:50 +02:00
Translation updater bot 010d32f6a9 Localisation updates from https://translatewiki.net.
Change-Id: I4a6806333cdcf9b3ebf0e8098909d71f7fdef41b
2015-10-07 21:59:52 +02:00
Roan Kattouw cacccc307a Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications
We have to account for the placeholder item, which doesn't have a
getModel method. We should ensure the real items and the placeholder
item implement a common interface so we don't need these kinds of
checks all over the place.

Bug: T114853
Change-Id: Iff6f0e85fb7737e09a34e72038b6b41681d95595
2015-10-07 08:20:35 -07:00
Roan Kattouw 983c7a2463 Follow-up f9e8c5057: fix JS error
Bug: T114833
Change-Id: I73d37a0688165125db56c1d6c088f215b19f421e
2015-10-06 18:24:14 -07:00
Moriel Schottlender f9e8c5057c Log notification impressions and clicks
This logging was taken out by accident during the split notifications
rewrite.

Bug: T114833
Change-Id: I7672c20bb12e06f3efc63763aacbe81fd0f34ece
2015-10-06 23:15:56 +00:00
Translation updater bot f8c68648f8 Localisation updates from https://translatewiki.net.
Change-Id: Ia36992b6947de6c67691b195a94ff663cd8d8dab
2015-10-06 22:01:13 +02:00
Translation updater bot 2f552b92ee Localisation updates from https://translatewiki.net.
Change-Id: I0028e5c88021d10b6c3be2b390ad134cddc30027
2015-10-05 22:14:38 +02:00
Paladox cb0b254915 Remove jshint from package.json
We use grunt-contrib-jshint for jshint.

Change-Id: I83e96471a3253a635107d351fc8f8f2f3d8c6286
2015-10-05 12:16:47 +00:00
Moriel Schottlender 8b2c6355cc Add browser test for notifications in Echo
This browser test checks that mentions go to alerts and talk page
messages go to messages popup. This also upgrades the MW-Selenium
version in Echo tests to 1.6.1.

Depends on MW-Selenium version 1.6.1 (See T114061)

Bug: T113081
Change-Id: I40a17500cdfb838420c04dc0b9268ba56515cc2c
2015-10-04 22:23:51 -07:00
Translation updater bot 2e08292733 Localisation updates from https://translatewiki.net.
Change-Id: I3ec74fded21338e39abc43789058e4fb590b0e6b
2015-10-04 22:17:57 +02:00