Commit graph

7049 commits

Author SHA1 Message Date
Thiemo Kreuz df6d65a6cf Use monitored getTestUser() in tests if possible
Change-Id: I584d8883f14b2651927890d353b738a02771abea
2021-01-29 18:00:57 +00:00
Thiemo Kreuz 0f954929a7 Remove comments that literally repeat the code
This also fixes a remaining `var` that should be `private`.

Change-Id: Ifa37a097a9d60bd22a16bc626d4b4271b8df2da7
2021-01-29 13:55:41 +01:00
libraryupgrader b49cebf8cb build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
  The following sniffs are failing and were disabled:
  * MediaWiki.Commenting.FunctionComment.WrongStyle

* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1
  The following rules are failing and were disabled:
  * compat/compat

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: Icc5ae88b205d4b122efef7aef2826eb334b27820
2021-01-29 10:19:37 +00:00
Translation updater bot c6f29042bc Localisation updates from https://translatewiki.net.
Change-Id: I6d2ebba04320b87bba0ee0a606c72dc137d4ac23
2021-01-29 08:37:36 +01:00
jenkins-bot 8ef19fb332 Merge "Improve function and property documentation in tests" 2021-01-28 09:57:19 +00:00
Translation updater bot 66ae6adafb Localisation updates from https://translatewiki.net.
Change-Id: If78ecd712f317ab8de73f72ac721749d431fe994
2021-01-28 08:35:45 +01:00
mainframe98 d426e6fb54 Provide notifications icons through content navigation
Ia1451e3e802441162eecfc5b7f6a7ba2ae72f377 introduced
the notifications content navigation, which allows skins
to choose where they want notifications to be positioned,
rather than requiring them to manually extract them from
the personal tools.

Bug: T266613
Depends-On: Ia1451e3e802441162eecfc5b7f6a7ba2ae72f377
Change-Id: I7badfd9bf9257b2537596e9f2e93248f52e4bd82
2021-01-27 17:36:24 +01:00
Translation updater bot f111dd9f60 Localisation updates from https://translatewiki.net.
Change-Id: I2af220037d6e638819a3fcbbe519982632106248
2021-01-27 08:34:16 +01:00
Translation updater bot 737a002378 Localisation updates from https://translatewiki.net.
Change-Id: I621d1ca3dd15512769a217ea39d35fd45e13a35e
2021-01-25 08:53:26 +01:00
Umherirrender fba5bcec19 Improve function and property documentation in tests
Change-Id: I90a0c9e7b1ac17edeed5f706a8f968f6d67df56f
2021-01-23 12:54:27 +01:00
Translation updater bot 7ec57872fe Localisation updates from https://translatewiki.net.
Change-Id: I7f4b24720e9063ca1ab05934619d3d2ad8881117
2021-01-22 08:30:33 +01:00
Translation updater bot 7823fb5c41 Localisation updates from https://translatewiki.net.
Change-Id: I334b05d38c6f69a139b29394dc86f81a5a7446b3
2021-01-21 08:31:39 +01:00
Translation updater bot 21963b88be Localisation updates from https://translatewiki.net.
Change-Id: I40957a12484298cda2c098295227e819784ee591
2021-01-18 08:37:44 +01:00
Translation updater bot da149c856b Localisation updates from https://translatewiki.net.
Change-Id: I67bc95cbee399bb29fbd6d2a61aa286ba4befb42
2021-01-15 08:39:07 +01:00
Translation updater bot 945526799a Localisation updates from https://translatewiki.net.
Change-Id: I4ad8113437ac5274bc74492b5ba095e9af3c333a
2021-01-14 08:50:10 +01:00
Translation updater bot 4591374302 Localisation updates from https://translatewiki.net.
Change-Id: I945025bd52e5ae1f19ff2bc3714c0999f039e179
2021-01-13 08:36:17 +01:00
Translation updater bot 2be4751ba1 Localisation updates from https://translatewiki.net.
Change-Id: I20ec252abf9e1257c30bd8bbaf3ef983ed5b0950
2021-01-12 08:37:28 +01:00
Translation updater bot e4b94a847c Localisation updates from https://translatewiki.net.
Change-Id: I6c2324e25917dafc0efb8e524ea45d15078fbce7
2021-01-11 08:34:12 +01:00
Translation updater bot 4aa9662221 Localisation updates from https://translatewiki.net.
Change-Id: I19d9a31d85aef9601c251f462a4d69488e311660
2021-01-05 08:27:46 +01:00
Translation updater bot c5ab03ed0a Localisation updates from https://translatewiki.net.
Change-Id: I803e346bafbaf8a79a2e979632b79886ad2d2a73
2021-01-04 08:43:11 +01:00
jenkins-bot c5ff8a20d1 Merge "Use Maintenance::set/getBatchSize in maintenance scripts" 2020-12-31 23:20:47 +00:00
Translation updater bot 9973c22664 Localisation updates from https://translatewiki.net.
Change-Id: Iec633689227ceb2922bd36041d2d84ee689e55ad
2020-12-30 10:13:49 +01:00
Translation updater bot 0a8dda9386 Localisation updates from https://translatewiki.net.
Change-Id: I4dde3aa8e9bfa9a291dc2823b0771ab6f4ad64b5
2020-12-28 10:38:11 +01:00
jenkins-bot 6042d6e389 Merge "Prefer UserIdentity::isRegistered over isAnon" 2020-12-23 08:25:04 +00:00
Translation updater bot bb8308b417 Localisation updates from https://translatewiki.net.
Change-Id: I7a9d7bb1778fbcce7e12f7c81733e4658118c100
2020-12-23 08:32:12 +01:00
Thiemo Kreuz c9797db768 Prefer UserIdentity::isRegistered over isAnon
isRegistered is part of the slick UserIdentity interface, i.e.
it's the more "canonical" form. This change makes it a bit
easier to move away from using the huge (4000+ LOC) User class
everywhere, in favor of the UserIdentity interface, where
possible.

This patch is meant as a small step towards this goal. I tried
to replace some usages of User type hints already, but prefer
to go in small, incremental steps.

Change-Id: I039c7a18672dfb6ea9507752bce9ea754babd690
2020-12-23 07:15:30 +00:00
Translation updater bot 998eccffe0 Localisation updates from https://translatewiki.net.
Change-Id: I3d70ce079da9fbf125aadd752e9a6c0d99578b35
2020-12-22 08:30:53 +01:00
Translation updater bot 5bb4551d0a Localisation updates from https://translatewiki.net.
Change-Id: Icdd77c4bf35e372f10c7c858638735588e2cc383
2020-12-21 08:38:51 +01:00
libraryupgrader 21ced85a6b build: Updating mediawiki/mediawiki-phan-config to 0.10.6
Change-Id: I0b6a32ccb5aca0640a7a9914e16f537221f66997
2020-12-19 14:05:27 +00:00
jenkins-bot 8f9b1b9cba Merge "Move Vector-specific top:-5px badge offset to Vector style file" 2020-12-18 20:26:58 +00:00
James D. Forrester eec3ac85bb Use User->isRegistered(), not deprecated isLoggedIn()
Bug: T270450
Change-Id: Ieb3f78a7e5f71fc28f31c01d981d246cdd895581
2020-12-17 18:32:42 -08:00
Umherirrender ceac7e38d7 Use Maintenance::set/getBatchSize in maintenance scripts
No need to define own class property

Change-Id: I9c71eaee6086b3d079648ee8dba41b7600c464a1
2020-12-18 00:28:32 +01:00
Umherirrender d7556b1d96 Add missing @var and improve documentation
Change-Id: I729d5ff5afd4d45022fa0a4e42d060d35543b567
2020-12-17 20:55:49 +01:00
Umherirrender 1a922d4443 Remove unused SpecialNotificationsMarkRead::$eventId
Change-Id: I37b647fb1bb35b13d72c56619db6d4007db61f82
2020-12-17 19:05:58 +01:00
Translation updater bot 3f68ee2d66 Localisation updates from https://translatewiki.net.
Change-Id: I5615432241ad7de7ca15ec0b183e71bfa2890c5c
2020-12-17 08:54:58 +01:00
Isarra 4ab34ada4f Move Vector-specific top:-5px badge offset to Vector style file
Essentially: force the badges, when the personal menu is displayed
inline, to align correctly with the rest of the line instead of
hovering slightly above the line for no apparent reason.

This should fix nearly every other skin that doesn't already have
its own local fix, as 20px is already pretty well-centered with
normal-sized fonts when doing sane things with padding/margins/
line-heights. (Vector is not doing sane things with padding/
margins/line-heights in the personal menu, but hopefully forking
Vector went out of vogue ten years ago and people have quit doing
this by now, yes?)

This may also not be ideal for mobile skins. Breaks Timeless,
because I just completely gave up on trying to get this to behave
there and put it in its own little timeout box. Oops.

Change-Id: I73067bbc3c930ebf20aa492b53a4a5fe4259b607
2020-12-16 19:22:40 +00:00
Translation updater bot d8d41536a3 Localisation updates from https://translatewiki.net.
Change-Id: Ifc6d7e7c31db5bf2194f076e175d14ef5240f902
2020-12-14 08:41:34 +01:00
libraryupgrader 0e6ca8085b build: Updating ini to 1.3.8
* https://npmjs.com/advisories/1589

Change-Id: Idefd9a24b89fb50250568b3ebfe801b28634d733
2020-12-13 02:22:38 +00:00
Translation updater bot 415a7100f4 Localisation updates from https://translatewiki.net.
Change-Id: I5112820d6123875afbd51e8c7df1baa5e373fccf
2020-12-11 08:35:14 +01:00
jenkins-bot 07307692ee Merge "build: Updating mediawiki/mediawiki-phan-config to 0.10.5" 2020-12-10 21:20:10 +00:00
libraryupgrader b391178348 build: Updating mediawiki/mediawiki-phan-config to 0.10.5
Change-Id: I8892cea01993f0ae51eebabaaf40685889124943
2020-12-10 18:20:15 +00:00
Translation updater bot de49359608 Localisation updates from https://translatewiki.net.
Change-Id: Ic26389a4e2b674df4f8a1e9acbda06f3671233e3
2020-12-10 08:34:38 +01:00
jenkins-bot 3c65102fc2 Merge "Remove padding from popup heading" 2020-12-09 10:13:09 +00:00
Translation updater bot 2ba0e78ce8 Localisation updates from https://translatewiki.net.
Change-Id: Ib6c4275c810d57ba9ff9e1aa29696d4cf54a0ea4
2020-12-09 08:41:45 +01:00
Ed Sanders 7170698d68 Remove padding from popup heading
Fixes regression from OOUI update.

Change-Id: I0f2cca3417a2217f350032b8aed2f517e8ed35b7
2020-12-08 22:05:08 +00:00
Translation updater bot 7141d54813 Localisation updates from https://translatewiki.net.
Change-Id: Id3652577b047c6ee81b171ee356d5581759cdced
2020-12-08 08:21:10 +01:00
Translation updater bot c28d898487 Localisation updates from https://translatewiki.net.
Change-Id: I9b3bdb3a4bbdf527b9fa43dcd819b2345bab789a
2020-12-07 08:44:34 +01:00
libraryupgrader fc961b033a build: Updating mediawiki/mediawiki-codesniffer to 34.0.0
Change-Id: I0cfe504c9d20c93d5cfa82551923bc3c25ee4f74
2020-12-06 06:45:47 +00:00
Translation updater bot 21a34cbf2c Localisation updates from https://translatewiki.net.
Change-Id: I2fade4adbcaf6f83acbee981284bb05762995dfe
2020-12-04 08:33:04 +01:00
Translation updater bot e44c2cf482 Localisation updates from https://translatewiki.net.
Change-Id: I1ca3562696d5c93fa20acc1e3253dc63c93b3829
2020-12-03 08:32:18 +01:00