Thiemo Mättig
e205992d0b
Remove unused code and fix missing/broken documentation
...
General code cleanup as reported by the PHPStorm static code
analysis. I hope it's not a problem that I made a lot of very
different (but all very tiny) changes in a single patch. If you
want to merge this but you think it's better to split it into
several patches first, please tell me.
Change-Id: I2e2c4bb47f8d20e038d28e236e2ff813b30504af
2014-06-04 04:54:00 +00:00
kaldari
f1e0a73abd
Add logging support for mobile boolean flag in EchoInteraction
...
See also: I8db8d3c4eb2bb396195c42073a95ac8530fe869d
Change-Id: I3cb6b9cff91a927b03d30e5f3fec9984cf3f790b
2013-12-24 19:45:51 +00:00
kaldari
08fc83b6de
Cleaning up Echo 'base' module.
...
Removing unused functions and declaring correct dependencies.
Targetting to desktop and mobile so it can be used by both.
Also removing dismiss-related code from the formatter.
Change-Id: Icccce64cfb3c564ab468a93ccdba9c5a61687fd5
2013-09-23 11:29:49 -07:00
Krenair
ab592dad6f
Cleanup JS
...
* Add missing spaces after 'function'
* Remove underscores from identifiers
* Don't use typeof for undefined with local variables and object properties
* API ok/err is deprecated since MediaWiki 1.20 (< 1.22-alpha), use .done and .fail
Change-Id: I5ca3403ee263a0c3e6709618e48e896340952337
2013-06-23 01:25:29 +01:00
Krenair
7da252eec4
Use mediawiki.api instead of $.ajax
...
Change-Id: Iea98b6cb338c8b7ebbf244073bb8fe481e5e7655
2013-06-19 21:31:38 +01:00
bsitu
01e244c8a3
Remove quote around javascript object property name
...
Change-Id: I5cc7f4179066ab694a67d4c578ed4a562f533ade
2013-06-12 10:51:55 -07:00
bsitu
6ffc1cac4b
Add clickthrough eventlogging to Echo
...
Change-Id: I3d05d1aeca92f9a0265a522cc5027ae18394c5b4
2013-06-11 10:46:41 -07:00
Siebrand Mazeland
d440540cf8
Add .jshintrc
...
Per https://www.mediawiki.org/wiki/CC/JS#Linting . Update a few files to
bring the tests closer to passing.
Change-Id: I08b190e8b44dbdbeb56de5c380d0ed4a8394aca2
2013-04-18 00:36:08 +02:00
kaldari
5b10fdf14b
A bunch of Echo style tweaks per Vibha
...
Change-Id: I1317b1dd670c8f7a33b62bb7d86a6d25d841c6a1
2013-03-26 18:03:46 -07:00
Kaldari
fcb5d99b37
Fixing dismiss functionality for new checkmatrix system and categories
...
Change-Id: I3b64c4853587d4d2d8f04fc97c9b3ddb15b520ed
2013-03-07 15:11:46 -08:00
bsitu
9f62f5fe36
Remove trailing comma from javascript object literal
...
Change-Id: I629a21eeeae810fe7d6bf805cfbaa61225e00963
2013-03-05 17:14:32 -08:00
Kaldari
8357f4bd75
Implementing new prefs system for Echo
...
Change-Id: Id745ed6cf1c92695569597fab6ea662bac8c76c0
2013-03-05 12:20:17 -08:00
Kaldari
35cf44e4a6
(bug 45016) make sure dismiss works across all supported types
...
Change-Id: Id9bf0c785a8fe429c6ec04c427330395d30bf68c
2013-02-15 14:09:39 -08:00
Kaldari
16331eab92
Adding dismiss functionality to flyout overlay.
...
Change-Id: Ibfbdb2a9f170e1d9b30b50e8639aee25101e71d6
2013-02-14 11:01:03 -08:00
Siebrand Mazeland
3a43ea2e05
Maintenance for Echo extension.
...
* Update docs.
* Remove unused local variables.
* JSLint/JSHint suggested updates.
* Merge CSS lines.
Change-Id: Ib2a2e8129d5ff8aca6c612a39d22698f078df9d5
2012-10-06 19:31:31 +00:00
Siebrand Mazeland
950f74eba8
Follow-up I2c10cb69: Auto-formatted using IDE.
...
Change-Id: Iedeaca3c31195a5cf7df8dd38d6332cfabffcc67
2012-08-31 23:50:46 +02:00
Krenair
9559105b59
Use whitespace between function parameters and the brackets.
...
Change-Id: I2c10cb69f1f1726b63d25579c6a35c882cc1fe7e
2012-08-30 17:04:39 +01:00
Andrew Garrett
efb463cca9
Echo: Refactor various code to allow for XMPP and badge notifications.
...
Change-Id: Ic372756501ad3438ab67a5c96791ba2ffe70c886
2012-07-31 14:19:15 -07:00
