Commit graph

164 commits

Author SHA1 Message Date
Volker E b680244f8a Fix navigation controls wrapping on Notifications page
Fixing regression from a8ef5fe765c1.

Bug: T210487
Change-Id: I914b94515398d9fa388e8a8984b22f52e3507c86
2018-11-27 09:27:52 -08:00
Volker E d0d222cc3a Fix two layout regressions from OOUI ButtonSelectWidget change
Fix the regressions from being able to wrap items on narrow screens
in I2102f6d33979b. We don't want wrapping in affected cases.

Bug: T208930
Change-Id: I748d5b455bef15067205b49824386d2ab5dfdc07
2018-11-07 04:06:02 +00:00
Ed Sanders 0f7afb1e5d Convert SpecialHelpMenuWidget to a customised DropdownWidget
Replace the handle with a button widget.

Also remove the unused PendingElement mixin.

Bug: T178387
Change-Id: Iec3afea6c6a8fdb49e17750af7bada42b7ed4b70
2018-05-30 18:57:07 +01:00
jenkins-bot b926673987 Merge "Sticky toolbar: Add missing vendor prefix" 2018-04-30 22:56:43 +00:00
jenkins-bot 4538925597 Merge "Conditionally rearrange date and button in notif list" 2018-04-13 18:25:38 +00:00
Moriel Schottlender 8b84ed2a3b Conditionally rearrange date and button in notif list
When there isn't enough space for both date and button,
separate them each on its own line.

Bug: T146288
Change-Id: I7ad022da82503f35ae630d171faeed1815c97f7a
2018-03-28 16:19:47 +03:00
jenkins-bot 2cf4bd1df3 Merge "Align Notifications popup header/footer with OOUI's default size" 2018-03-27 21:03:38 +00:00
jenkins-bot bc511b4af2 Merge "NotificationsOptionWidget: Fix icon alignment" 2018-03-27 21:00:26 +00:00
Ed Sanders 0fd6d64a29 Fix DOM structure of mw.echo.ui.MenuItemWidget
* Inherit from DecoratedOptionWidget as it comes with
  an icon mixin.
* Keep the DOM structure as similar to its parent as
  possible, to avoid breaking upstream child selectors.
* To this end, replace <a> wrapping hack with override
  of getTagName to set this.$element to <a>.

Change-Id: Ifde70785a1bc996eb09e581b06ed30708323e9f7
2018-03-27 12:33:40 +01:00
Volker E 77021e370c Align Notifications popup header/footer with OOUI's default size
Bug: T190397
Change-Id: I41ad96bbc7d3922772ecb026cb251476882601c7
2018-03-26 20:13:08 -07:00
Volker E cc3df57d71 NotificationsOptionWidget: Fix icon alignment
Change-Id: Ieb5c9a8e378608e096e921fdb6795949a119c8a8
2018-03-26 02:15:36 -07:00
Ed Sanders 15a3443384 Use updated bell/tray icons from OOUI 0.26
As these are smaller canvases, fix positioning
hacks accordingly.

Change-Id: I472f8cdd5887243c3fd86ab1431532a99dba1ce9
2018-03-24 15:06:47 +00:00
Ed Sanders 17be84ec51 Sticky toolbar: Add missing vendor prefix
Change-Id: Ib1a68298295e7c0ae276a1cec92c5c67adb7b643
2018-02-04 21:26:06 +00:00
jenkins-bot e63b9f9ac0 Merge "Fix help menu icon placement for monobook" 2018-01-19 18:44:00 +00:00
jenkins-bot f321dc1250 Merge "Align the icon in the popup action sub menus" 2018-01-19 18:38:39 +00:00
jenkins-bot d0550c9f6c Merge "Truncate page name in the sidebar and organize into table view" 2018-01-18 11:43:47 +00:00
Volker E 4bb614b5fd Use “OOUI” as unified name for code comments
Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
2018-01-16 23:30:18 -08:00
Moriel Schottlender aecacd9443 Align the icon in the popup action sub menus
Also bring the icon rules up to a rule that actually
overrides ooui ruleset.

Bug: T185046
Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
2018-01-16 16:40:46 -08:00
Moriel Schottlender 1e9f4a106c Fix help menu icon placement for monobook
Bug: T184023
Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
2018-01-16 14:09:58 -08:00
Moriel Schottlender df4aa8ea0b Truncate page name in the sidebar and organize into table view
Organize into table view for consistency and truncate the title.

Bug: T184143
Change-Id: I0ae3105ea60dcc2ae6c0f7f2545368a5f86cb2c4
2018-01-16 12:09:01 -08:00
petarpetkovic 309ea8e936 Fix "Mark as read" button icon on no-JS
Bug: T182167
Change-Id: I2c386e1ab2c95d2d1034c8d366d39c12827b3d22
2018-01-03 15:50:45 +01:00
Bartosz Dziewoński 7cc225ca33 mw.echo.ui.MenuItemWidget: Override OOUI styles harder
Bug: T183435
Change-Id: I949de77ac8221bdc4bb35ae7b75e3df91d861d07
2017-12-27 14:07:53 +00:00
jenkins-bot 010bb75603 Merge "Move the popups to the overlay" 2017-12-21 18:14:50 +00:00
Moriel Schottlender 77acb5b3ee Move the popups to the overlay
This will solve multiple issues with the design having to overcome
the theme-based design for the #p-tools.

Bug: T156080
Change-Id: Ibfcdfeea649e566059fd88485e146fbad2201016
2017-12-20 15:44:27 -08:00
Albert221 c6388532c0 Better color to represent read notifications
Replace color of read notification background
in notifications list with Base 80, also
slightly increase opacity of timestamp to
be more visible.

Bug: T78594
Change-Id: I93e26a9eb7e01a8b46bcac8b7ed72ddf06a63f30
2017-12-09 02:11:08 +01:00
petarpetkovic 41a4cc4ae6 Add left padding to PageNotificationsOptionWidget
Bug: T177065
Change-Id: I71a9bafe520faf04e59c093761ed1303b13861bb
2017-11-28 16:05:01 +01:00
Volker E 738524da4a Equal CrossWiki/BundleNotificationItemWidget group's padding
Follow-up I18c0caea2438399d6f97e59c47177691cb43816d.

Bug: T177723
Change-Id: Iaa7a19d3d2064d3258bdd161056976fc0ebc781e
2017-11-09 11:43:05 -08:00
jenkins-bot e25e8b1231 Merge "Use position:sticky for toolbar floating" 2017-10-18 23:01:56 +00:00
Bartosz Dziewoński 6fa38a985c mw.echo.ui.PageNotificationsOptionWidget: Fix CSS after changes in OOjs UI
We have to override 'position: absolute' and increase the specificity
of the selector to override 'display: block'.

Bug: T178439
Change-Id: Icd09e8302f124524779553eae3536d875f2e1227
2017-10-18 20:56:27 +02:00
Ed Sanders cfa130cc13 Use position:sticky for toolbar floating
Avoids any scroll-based DOM changes which slow down scroll events.
Removes floating in browsers without sticky support (mostly IE).

Change-Id: If75e2a90d76644296fe3db5ef8bd9b26de4e7b0c
2017-10-17 15:22:26 +01:00
jenkins-bot 3460faa930 Merge "Fix CrossWiki-/BundleGroup layout" 2017-10-17 01:44:02 +00:00
Volker E 6a74084e01 Fix CrossWiki-/BundleGroup layout
Fixing CrossWiki-/BundleGroup layout after OOUI button height,
which is used as header in this case, has been increased.
Also removing `border-bottom`, `box-shadow` and
`border` of next item respectively notification footer are
sufficient and result in the groups being less crowded.

Bug: T177723
Change-Id: I18c0caea2438399d6f97e59c47177691cb43816d
2017-10-16 18:29:12 -07:00
jenkins-bot bab8145f06 Merge "Align popup message color to toast message in MinervaNeue" 2017-10-12 19:19:12 +00:00
jenkins-bot b2b7547877 Merge "Replace vendor prefixed box-shadow with central mixin" 2017-10-10 21:16:49 +00:00
Volker E 4b3782a46a Replace subtle greys with WikimediaUI color palette ones
Bug: T177723
Change-Id: Iceafe2f3e702667e0ee68b79ddcb6aa4d8fd0010
2017-10-08 10:26:43 -07:00
Volker E d4682c9f14 Align popup message color to toast message in MinervaNeue
Toast messages carry now `#222`. This should be used here as well.

Bug: T177723
Change-Id: I7e1f6c2e1937353b0485ed0b5c2737742c62e770
2017-10-08 09:55:18 -07:00
Volker E 1a46e0f06f Replace vendor prefixed box-shadow with central mixin
Replacing vendor prefixed `box-shadow` with LESS mixin out of
mediawiki.mixins.less. This also removes obsolete `-moz-box-shadow`
saving some bytes.

Change-Id: I336ee7340bc518fef74762a8381495265dd3eb4b
2017-10-08 09:50:09 -07:00
Kaldari 4381dbbe8a Fix gap between notification pop-up header and notifications
Change-Id: I12261ad8033af7286d426933df19611b8163d9c9
2017-09-26 18:44:56 -07:00
Moriel Schottlender 9e320bac6a Fix 'unread' dot top padding regression
All frameless buttons seemed to have recieved a generous padding-top
in the latest OOUI release. This fix overrides that.

Bug: T173059
Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
2017-08-21 11:21:39 -07:00
Volker E d7ebaf8c8b Replace outdated border-radius value with WikimediaUI one
Change-Id: Iebfd55c8e7f52f207f45dc547fccaf89107e8a32
2017-08-17 17:22:57 -07:00
Roan Kattouw 0bf4861d92 Fix layout regression in notification popup footer
Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
2017-07-21 13:04:51 -07:00
Roan Kattouw 4cf17a6712 Fix alignment of the "Mark all read" button
Bug: T169019
Change-Id: Ie63e74bef594e9c21c8a9bb615454c4a526276c2
2017-06-27 14:46:19 -07:00
jenkins-bot 2de9b411c7 Merge "Follow-up 739847c20: don't adjust the popup anchor position" 2017-05-02 18:39:02 +00:00
Roan Kattouw dd2bdd64af Follow-up 739847c20: don't adjust the popup anchor position
We used to need to center the anchor, but I375a76a49337d3b on oojs-ui
makes popup anchors center themselves, so this is now harmful.

Bug: T163993
Change-Id: I345727ae4175fd9d3cea024f43df802bcd401838
2017-05-02 10:55:02 -07:00
Roan Kattouw 2691d94e0f Don't truncate notification header messages in bundles
Bug: T163518
Change-Id: I569aeba7b8f87ca46a81ffb5a56c241342dc3d21
2017-05-02 10:50:13 -07:00
Moriel Schottlender ebbe2e81af Make date headings a proper semantic <h2> heading
To support accessibility, make sure the titles in Special:Notifications
are <h2> headings.

Bug: T149955
Change-Id: I4f15694efb04896e9bd7b026d297891047759644
2017-04-13 22:39:28 +00:00
Mooeypoo 84d34a3901 Revert "Do not use fancy styled badge on Modern and CologneBlue"
This reverts commit 08d224e955.

Causes bugs in Vector when displaying the badges.

Bug: T162173
Change-Id: I9e92c304b47ce9204d7a7d2fba67118e67b1bdc9
2017-04-04 18:40:09 +00:00
Bartosz Dziewoński 08d224e955 Do not use fancy styled badge on Modern and CologneBlue
Just show the textual "Alerts (1)" and "Notices (1)".

Updated NotificationBadgeWidget to use that internally as label,
same as the PHP-generated list item does after d4d325e7.

Bug: T141944
Change-Id: I468c67b0866530e21c9af32cd02816075a3693a1
2017-04-01 14:57:34 +02:00
Roan Kattouw 739847c20f Fix RTL popup alignment for OOjs UI 0.19.5
Popup alignment corrections are now done with margins on the anchor,
not directly on the popup. Setting "left" also didn't have any effect,
because it was being overridden by inline styles set by the new
PopupWidget/FloatableElement code.

Bug: T159999
Change-Id: I7738edee7ae096fcc116a79e71a591a2287ea34f
2017-03-08 15:39:50 -08:00
jenkins-bot 14f261a2fc Merge "Revert "Remove FloatableElement hack, no longer needed"" 2017-03-08 01:48:27 +00:00