6 commits

Author	SHA1	Message	Date
Timo Tijhof	46484e8b53	tests: Use native QUnit.test.each(), ES5, and other cleanups ... * Declare variables inline, as per the current code conventions. * Convert ad-hoc cases objects into native QUnit.test.each(). This makes for shorter and cleaner code, as well as for more detailed test reporting, and removes the need to manually construct assertion messages based on test case prefix string etc. * Start adopting ES5 Array.forEach in a few places where otherwise ESLint would complain about variable name clashes. * Future proof the test module names, by stripping the global variable namespace that some classes still use, matching packageFiles convention as used for NotificationBadge.js and its tests already, by specifying only the bundle name and the exported class name. Note that the QUnit UI does fuzzy matching so filtering works the same either way, e.g. "echodmfilter" will match "ext.echo.dm - FilterModel". Change-Id: I49858dd2c95d0869f2cd15693f05c38312a9f710	2022-05-13 19:18:28 +01:00
Ed Sanders	bb1bd02bd6	eslint: Fix warnings ... * Load wikimedia/jsduck rules * Add inline disables for compat * Fix shadowed variables Change-Id: I42234ab74f5007c16ff3960309335e715da76c1c	2021-02-01 21:02:46 +00:00
Ed Sanders	17126b2ab1	Remove obsolete aliases from closures ... Bug: T208951 Change-Id: If51fc6d50b9755c779fd0bf1be7bb0fe276539ea	2018-11-12 13:56:38 +00:00
Ed Sanders	2c089e075d	build: Update linters ... Change-Id: I9747097fdf725992710f97d4ce4ea49fd611df1b	2018-09-11 23:46:52 +01:00
Ed Sanders	c8d24ebd17	build: Replace jscs/jshint with eslint ... Change-Id: Iee1d1b20ed31e636bfb8fc8cf9b18ff328bf608c	2016-11-23 15:25:59 -08:00
Moriel Schottlender	7b4bb11c2a	Add proper QUnit tests ... Change-Id: I7a4abf068a32d9cf65eb464eb036f72f319c54ff	2016-09-29 15:28:30 -07:00