wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 16:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
5480 commits 164 branches 0 tags 74 MiB
Commit graph

84 commits

Author SHA1 Message Date
Umherirrender 4c991af59f Use WebRequest::getInt for limit parameter 
This avoids that the default value is casted to string
and than back to int

Change-Id: I66ef8bc3a8e89b43aa5eff79bc371659e86af174
 2019-12-13 22:29:07 +01:00
jenkins-bot 6e48f16af6 Merge "Use READ_LATEST constant and fix a soft type hint" 2019-10-24 18:37:13 +00:00
Thiemo Kreuz d79dd00e01 Use READ_LATEST constant and fix a soft type hint 
Change-Id: I2123c5efe01a5b42daeec9c7b0eefce089864657
 2019-10-23 12:45:51 +02:00
Thiemo Kreuz 229c3d0fdd Remove non helpful (auto-generated) comments 
None of these comments explains anything that wouldn't be obvious
from the code itself.

Change-Id: Ibcf50d401999ae76f315df2d2d27097a39f41bbd
 2019-10-23 12:31:35 +02:00
Kosta Harlan ccab496734 Remove PhanTypeMismatchArgument from call to appendContent 
Breaking in
https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/16324/console

Change-Id: I9a6b06158d9083317aea46510c0c47980a25e50a
 2019-10-16 10:53:12 +02:00
Derick Alangi f402ecd31f Echo: Fix case mismatch for function/method calls 
PHP doesn't care much about the name (in terms of case sensitivity)
but I think we should make sure the names of the method should be as
they're in their definition.

Change-Id: I6e38d8be64efaec4200471f2d3007275d7ddecec
 2019-06-11 22:46:24 +01:00
jenkins-bot 21354c66a2 Merge "Remove badgeicon module, use OOUI icon instead." 2019-06-05 19:08:33 +00:00
shivanshbindal9 c86a1a5cf3 Remove badgeicon module, use OOUI icon instead. 
Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module.

Bug: T139779
Change-Id: I8218530ed2cdd2d81c1fc24509f36ea2b6742bd9
 2019-06-05 12:29:17 +05:30
Roan Kattouw 95172c2c7e Remove per-type notify-type-availability (make it category-only) 
Bug: T221264
Depends-On: I74f660e88d18d5a27cc1e74f39316bb27aec1cbb
Change-Id: I12cc0312dbfd9a6923b64117e001841a7bfaaf17
 2019-04-26 17:36:10 -07:00
jenkins-bot 3dbfbfb670 Merge "Add phan" 2019-04-10 17:29:04 +00:00
Daimona Eaytoy e21e3b4a8d Add phan 
Change-Id: I65ae6adc10941c05a2646e551b1baa829e4e8654
 2019-04-10 18:51:59 +02:00
Shivanshbindal9 a09db3ea59 Add visible help link for Special:Notifications 
Bug: T200184
Change-Id: Iaf321f88322e8a9686be62eb9b055c6544cf0ad6
 2019-04-09 10:27:40 -04:00
Umherirrender a10978b7af Pass IContextSource to parent in NotificationPager 
It is already called with a context in SpecialNotifications
Set context on SpecialNotificationsMarkRead and pass title to html form
to pass texts

Change-Id: I24eb85648580ac1a4df5e7587806bad57c141785
 2019-03-07 17:57:34 +00:00
Umherirrender 1b5308ba81 Use explicit columns and avoid SELECT * 
Change-Id: Ibde033784aee5adc13fae6f1d395d9464f54fefd
 2019-03-02 22:39:53 +01:00
Umherirrender 81183a6d86 Add method scope visibility 
Change-Id: Id4fe59155d6e0fa2ef1ccf4dc46ee1f109265246
 2018-11-02 18:47:39 +01:00
Alangi Derick 873df84e49 Fix php tag in SpecialDisplayNotificationsConfiguration.php 
Change-Id: Ib95e906ae9659e7613cd78ae24225cc5e4350758
 2018-10-08 18:49:06 +01:00
Brian Wolff 983a01bdff Build: Make pass phan-taint-check 1.5.0 
Disable some errors related to different members of an array
having different taints, and phan-taint-check conflating them.

Bug: T202383
Change-Id: Ic6c2c5bb7c6092d581e646358d836f55d5cf3222
 2018-09-14 02:04:03 +00:00
Bartosz Dziewoński 4b8916c405 Fix HTML escaping on Special:DisplayNotificationsConfiguration 
The labels for individual options are treated as HTML, not as text.

Change-Id: I5c2ae2d3a1dcaa3b85a2b47ed05952db28ea508e
 2018-09-03 21:16:37 +02:00
Umherirrender a0ad95b63f Split long lines over 200 chars 
This makes the code easier to read even on big screens

Change-Id: Iebc2ca785690abc6e7998c6f6078daf0bd01ccf8
 2018-08-23 10:33:25 +02:00
jenkins-bot af2b92856f Merge "Fix missing/mismatching type hints PHPDoc tags" 2018-08-16 08:39:29 +00:00
Thiemo Kreuz 2d7096bcff Fix missing/mismatching type hints PHPDoc tags 
This fixes some issues I found while updating this code base, e.g.
this removes types a method really does not return.

Change-Id: I19457e7bf88945eec958bf53e0b76a7585715a45
 2018-08-16 07:07:20 +00:00
jenkins-bot ef233becf5 Merge "Make "@… array" type hints more specific" 2018-08-16 00:57:12 +00:00
Umherirrender e499631a37 Escape message used in html 
Change-Id: Iee1c2bebec8756c5672e36c837fe9c2065479673
 2018-08-15 20:19:51 +00:00
Thiemo Kreuz c1c3c7b672 Make "@… array" type hints more specific 
There are about 200 of such generic "array" type hints in this code base,
the majority in @param tags. I started with what I found most relevant:
@var and @return tags. I might continue working on this later, but
wanted to stop for now to keep this patch moderately small.

Change-Id: Iff0d9590a794ae0f885466ef6bb336b0b42a6cd3
 2018-08-13 09:27:37 +02:00
Umherirrender dbfcd23b3b Pass correct IContextSource to HTMLForm 
The special page is only a MessageLocalizer, not a IContextSource.
Its implements all methods of IContextSource, but are delegated to the
underlayed IContextSource. So pass it directly make phan happy, while
the current code works as expected

Change-Id: Ia9d83f2f71a466a2ba74540f96f165c96fb7ca00
 2018-08-11 05:44:52 +00:00
Thiemo Kreuz cb282251a8 Avoid counting where not necessary 
Change-Id: I0abbdced4474dabbdecd3bbfae194e79b7c29db1
 2018-06-26 07:10:38 +00:00
Umherirrender b166664efc Fix parameter docs 
Change @param to @var
Add |null to nullable arguments
Removed comment out code

Change-Id: I535ad4d544284c1e0fb6f39c254761f0810b4cc7
 2018-04-06 08:17:17 +00:00
Ed Sanders 34e3d5feba Replace double-check with checkAll from OOUI 
checkAll was specifically designed as a
replacement for double-check.

Change-Id: Ibdd6865213107650b9004ab40e12c6a7453b6251
 2018-03-22 21:23:33 +00:00
libraryupgrader 83bdf90eb5 build: Updating mediawiki/mediawiki-codesniffer to 16.0.0 
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.MissingCovers.MissingCovers

Change-Id: I2a48e5c27a7307b3982d11875180fc11f2a125d9
 2018-02-15 09:51:55 +00:00
Kunal Mehta 0209f4eb2f Don't use deprecated SpecialPage::getTitle() 
Change-Id: I20c7d058bb25207705c08fe293800a6d1e0aab0e
 2018-02-04 18:53:08 +00:00
Thiemo Mättig 2e9a27558c Minor cleanups to PHPDoc blocks 
Change-Id: I5890144521b6b54c798b1590ab8d102d74ada26a
 2017-12-15 15:42:38 +01:00
libraryupgrader 7a23ddf4b0 build: Updating mediawiki/mediawiki-codesniffer to 13.0.0 
Change-Id: I7b19fab3b1100c4973600ec95ee24160e141c5ac
 2017-09-24 09:49:43 +00:00
jenkins-bot e74713a3ba Merge "Add 'Mark all as read' button" 2017-08-13 16:19:56 +00:00
mdew192837 e88185c54e Add 'Mark all as read' button 
Currently, the 'Mark all as read' button exists only for JS users.
This patch adds the button for no-JS users as well.

Bug: T96061
Change-Id: I1a62c56306597209540ffd694c8fb7b2a92885c9
 2017-08-13 10:55:46 -05:00
Umherirrender 5b4730c9bc Improve some parameter docs 
Change-Id: Ie71fb080926781f2905e6264be060203c56185ea
 2017-08-09 17:21:10 +02:00
Kunal Mehta aaf061c725 build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ExtraParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment

Change-Id: I8401abf121a7413fa191d7bc535e0ddd6cf8c3f7
 2017-06-22 14:13:28 +00:00
Stephane Bisson c46d56b018 Special:Notifications show unread by default if there's unread notifications 
Bug: T162927
Change-Id: Ibdfaca90803eb8b12b12eb1781b0692e7336b7d9
 2017-04-19 15:20:12 -04:00
James D. Forrester 8c810dff48 build: Update mediawiki/mediawiki-codesniffer to 0.7.1 
Also added "composer fix" command.

Change-Id: I25cb61b3b92798f1259d1575a336e2b056d5764f
 2016-12-05 15:54:30 -08:00
Roan Kattouw ed613f2e26 Fix missing doublecheck icon on Special:Notifications on mobile 
Bug: T146706
Change-Id: I918beabb1bcbe4a66c4252a795d379e2ff6591a9
 2016-11-23 16:31:23 -08:00
Moriel Schottlender 97a7d44190 Clean up Special:Notifications output 
Transform the php output to OOUI widgets.

Bug: T129172
Change-Id: I65cb5f2a016fc2a3c33a0b1cd2f3f88ed963ab02
 2016-09-01 13:38:06 -07:00
Roan Kattouw ff2c58cdc4 Follow-up 8eda2aa3f: actually render the nojs message on Special:Notifications 
Change-Id: Id0d931f8465c2abfa41b1053ec2b2d0a632037ed
 2016-08-22 16:16:41 -07:00
Matthew Flaschen f36d20ba4d Fix special page visit logging 
'version' was missing, making the event invalid, causing it to
not reach the database.

Factor out this field to logEvent

Bug: T121939
Change-Id: I9e4bb5574d69495cb5f53830047c68104c6ad10f
 2016-08-22 16:35:50 -04:00
Moriel Schottlender 8eda2aa3fa Include the 'no notifications' message in nojs div 
...So it can be hidden if JS is loading.

Bug: T142451
Change-Id: Idd70bdacb79cb45e759b30e711178721db5f80bd
 2016-08-16 17:25:14 -07:00
Leszek Manicki ab2bf21ce5 Check if logging is enabled before logging EchoInteraction 
Adds a check before logging a visit to Special:Notifications
added in Icfe63fb8daa8e8fba029e22b4de3e4f65517c448

Bug: T143092
Change-Id: I9e58ba35eef6a25a78e96a76facc04819cef37da
 2016-08-16 14:39:02 +02:00
jenkins-bot dc397a9ec4 Merge "Log Special:Notifications page visits" 2016-08-16 00:23:31 +00:00
Moriel Schottlender 015acb5407 Log Special:Notifications page visits 
Bug: T121939
Change-Id: Icfe63fb8daa8e8fba029e22b4de3e4f65517c448
 2016-08-15 17:10:56 -07:00
Stephane Bisson a0cca6c127 Output wgNotificationsSpecialPageLinks js var even if no local notifications 
Bug: T142148
Change-Id: Id9225b9aa95a7a8ee8602282ed0d4619c7ce2bf5
 2016-08-05 09:26:35 -04:00
jenkins-bot 834c240948 Merge "Adjust mobile view for the new settings cog menu" 2016-07-25 20:12:38 +00:00
Moriel Schottlender 1dd3af10bb Adjust mobile view for the new settings cog menu 
Now that we have the cog menu, it should be placed correctly in
mobile and the "preferences" link should be hidden.

Since MobileFrontend doesn't have the personal toolbar, and we
can't cheat by using jQuery and grabbing the url of preferences,
we have to get SpecialNotifications.php to output the urls
to a wg variable and reading it from there.

Bug: T115528
Change-Id: I6a69823d6f75c376c04e9a21d79916321e417178
 2016-07-25 19:30:44 +00:00
Stephane Bisson bfcfdded40 Special:Notifications (no-js): filter out deleted events 
Change-Id: Ie2e6b3ba388650f28ddc050624a52c410248fbd8
 2016-07-25 12:21:14 -04:00