Commit graph

1894 commits

Author SHA1 Message Date
jenkins-bot 5f93e4defe Merge "QA: more rubocop updates" 2015-02-20 16:57:10 +00:00
Cmcmahon 60a0e05c7c QA: more rubocop updates
No change to function at all

Change-Id: I150aed4379c75f716633cc4904cb9d8f388c9d45
2015-02-20 09:54:06 -07:00
jenkins-bot 1ae16a6358 Merge "QA: update for rubocop offenses" 2015-02-20 16:52:11 +00:00
Cmcmahon fcd695a076 QA: update for rubocop offenses
No change to function, just cleaning up

Change-Id: I1b0b4fe8e4f785cbeebc2d1415a45f831dc75f5c
2015-02-20 09:49:38 -07:00
Translation updater bot 18b22e5d5a Localisation updates from https://translatewiki.net.
Change-Id: I3b41496a08ca3d2b755479f82e5c4f18c70df980
2015-02-19 22:06:33 +01:00
Translation updater bot 873ea5eeb2 Localisation updates from https://translatewiki.net.
Change-Id: I3234f11c96b0ed6aa95152297a74e01031402eb5
2015-02-18 22:02:56 +01:00
jenkins-bot bf0378e57a Merge "Fixed CPB flyout notification count" 2015-02-18 04:33:41 +00:00
Divya 562168b261 Fixed CPB flyout notification count
Added ext.echo.updateNotificationCount to notify other extensions
about updates to the notification count.

Bug: T67178
Change-Id: I7f4e34f2c1808b249db010018dd1b49a8dde246a
2015-02-18 04:31:34 +00:00
Erik Bernhardson 91abb657c8 More gracefully handle unavailability of ParserFunctions in phpunit
Change-Id: I375c13e937892062b061940b2b9ac5bdd832ac9d
2015-02-17 14:53:51 -08:00
Matthias Mullie 0dee3d3587 Pass title along to signature parser
* Parser generates signature to compare against
* Signature can be overwritten per wiki, in NS_MEDIAWIKI
* Such overwritten default can be different depending on
  page the signature is on[1]
* Our comparison signature generation was page-agnostic
  (always from Title::newMainPage)
* Signatures didn't match up on own talk pages, where
  default signature is different

Also added 2 new tests cases & improved tests by also
setting the page

1: https://en.wikipedia.org/w/index.php?title=MediaWiki%3ASignature&diff=176507985&oldid=176229132

Bug: T78424
Change-Id: Ice151d4d16236a5d1556ef62805b61310c7beb85
2015-02-17 10:24:12 -08:00
Translation updater bot d503ae5932 Localisation updates from https://translatewiki.net.
Change-Id: I47aadb602ff969167b92cab5730341ad80b64a17
2015-02-16 21:53:08 +01:00
Translation updater bot 5337b46bbe Localisation updates from https://translatewiki.net.
Change-Id: Ib6f19c027e3cacbf7145a79cf2eabc4030153de2
2015-02-12 21:33:01 +01:00
Chad Horohoe 4a09f730e3 Remove obvious function-level profiling
Change-Id: I498d79d99ab6016cadf502f4c606a7a911470250
2015-02-10 14:32:58 -08:00
Cmcmahon 46f2d7c46d QA: robustify Notification no-javascript test
Identify the first heading better

Change-Id: Idb029c43b20915022f4d566a7795c3e0ec55cea2
2015-02-09 13:48:02 -07:00
Cmcmahon f5052ed4ef QA: update Ruby gems for mediawiki-selenium
This should get around the error with later Firefox versions

Change-Id: I879b39d2b1ee83f307c2efa2c82b5832eec38dc0
2015-02-09 13:38:16 -07:00
Translation updater bot c08d8cc02d Localisation updates from https://translatewiki.net.
Change-Id: I236e219249f5f60f59560941a066db08cc444bfb
2015-02-08 21:47:23 +01:00
Translation updater bot 5c3b460878 Localisation updates from https://translatewiki.net.
Change-Id: I80e8448122f24954451583f9b43a3939256e070f
2015-02-07 21:46:06 +01:00
jenkins-bot 6f4d2b68fb Merge "Add tests for generateEventsForRevision" 2015-02-06 13:49:16 +00:00
Matthias Mullie 682eff7022 Add tests for generateEventsForRevision
Change-Id: I54d6904c613d6f58beaa4d8202a07f1bf5850e7e
2015-02-06 14:37:58 +01:00
jenkins-bot d3bfc5a5b9 Merge "Improve signature detection" 2015-02-06 01:21:27 +00:00
Translation updater bot cfc4e5389b Localisation updates from https://translatewiki.net.
Change-Id: I2f9c4a8c383d3f7a466121351a2f12346c5bdd9f
2015-02-05 23:05:35 +01:00
Matthias Mullie 58e1c765d6 Improve signature detection
Previously, there were a couple of hacks in play.
It was also not picking up ~~~ (signature without timestamp)
And it relied an a nasty regular expression which, although
based on Parser, may some day get out of date.
And it relied heavily on a specific signature format, which
isn't guaranteed (it's an i18n msg)

This patch changes the approach: it will use a very simple
regex to match links, and will send those through Parser to
generate the signature anew. My reasoning is that that should
be exactly the same as what Echo just received (should've
also gone through parser)

Biggest discomfort of this approach is that it's much stricter.
It should still match whatever it generated from a ~~~ or ~~~~,
but no longer the e.g. not-real signatures we were doing in
our tests. Also had to update our tests, because signatures
change depending on anon. So I had to generate all the users.
And fix some of the signature formats used in the tests.

Bug: T75426
Bug: T87852
Bug: T75366
Bug: T78424
Change-Id: Ibeff36397129fdd5d376f3668a23a45f9a014525
2015-02-05 20:45:19 +01:00
Translation updater bot 7408aba1ca Localisation updates from https://translatewiki.net.
Change-Id: I34227f2ec5788b338a3d3861fa8b0e4bb2f4d2e0
2015-02-03 22:54:03 +01:00
bearND e359b304db Make current Echo overlay tab dark gray and bold
mw-ui-quiet gets dark gray and bold.
This way it is easier to see which is the current tab.

Bug: T71929
Change-Id: Ie7e21cd71a385d216402d393344cf76d3ed45d23
2015-02-02 15:22:59 -07:00
Translation updater bot f6421760b1 Localisation updates from https://translatewiki.net.
Change-Id: I1722701309784bf0c78c255d7eac70514877561d
2015-02-02 22:26:43 +01:00
jenkins-bot d53857c7c3 Merge "Add 'license-name' matching SPDX conventions" 2015-01-31 23:54:18 +00:00
jenkins-bot 028388aa6c Merge "Bug: Fails signature detection with extra long signature" 2015-01-31 01:13:43 +00:00
Kunal Mehta 3e94bfac8b Start tests for the built-in notification types
* Only covers EchoHooks::onUserRights right now, more
  patches to follow

Change-Id: Ie93eff0a9a75a4a9816c81d57b7530149a14bb7a
2015-01-30 18:09:04 +00:00
jenkins-bot df2d335261 Merge "Rework broken echo test to make less assumptions" 2015-01-30 00:50:27 +00:00
Erik Bernhardson bf5ff9b8ea Rework broken echo test to make less assumptions
Change-Id: Id73794e3555ef18e5dde0c40b8f9ab8eba53eb96
2015-01-29 16:45:05 -08:00
Translation updater bot 4d05657b6d Localisation updates from https://translatewiki.net.
Change-Id: Ia667160b7a5c58e434de1e6afb906abc5e66cfd1
2015-01-29 23:00:11 +01:00
Ricordisamoa 01773a6d97 Add 'license-name' matching SPDX conventions
References:
http://spdx.org/licenses/
https://www.mediawiki.org/wiki/Manual:$wgExtensionCredits#license-name

Change-Id: I3debc1db6b821efeca07be05e1795f223d2fa621
2015-01-29 14:58:20 +01:00
jenkins-bot 6c8e3a0c3a Merge "Clarify alert/messages meaning" 2015-01-27 21:57:38 +00:00
Translation updater bot 75f1435462 Localisation updates from https://translatewiki.net.
Change-Id: I647c0bf62b6579f9f3b2e4c00fc3c96f76296378
2015-01-27 22:14:51 +01:00
Translation updater bot d1e36cd038 Localisation updates from https://translatewiki.net.
Change-Id: I5a0828d8bf22741bb90ef5179425126f18310206
2015-01-26 22:38:37 +01:00
Translation updater bot 85e844c51d Localisation updates from https://translatewiki.net.
Change-Id: I4dd7fe07a58631b45e316b910fac72bd04f87f6e
2015-01-25 21:46:02 +01:00
Translation updater bot 0e6be09906 Localisation updates from https://translatewiki.net.
Change-Id: I5b9f8d58e07e4fe3e69b9ccaba15f278cd72e83b
2015-01-23 22:25:57 +01:00
Translation updater bot c50c13eebf Localisation updates from https://translatewiki.net.
Change-Id: I5d813bd9984dea80d8e9345bd7b17c4cf25731ca
2015-01-21 22:19:46 +01:00
Translation updater bot 89b61ad4e7 Localisation updates from https://translatewiki.net.
Change-Id: I3261231613dc1ada471b1319c35e3233f9d434c8
2015-01-20 21:57:35 +01:00
Translation updater bot 851265edc2 Localisation updates from https://translatewiki.net.
Change-Id: I5948090ba055b4b2fec8e9029d6ae7ce2192c67f
2015-01-19 22:01:39 +01:00
Translation updater bot e6d3702434 Localisation updates from https://translatewiki.net.
Change-Id: I7c52991a193fc7e6d0451c61ff430f468e92a9e4
2015-01-18 22:17:17 +01:00
Translation updater bot cd1810d0bb Localisation updates from https://translatewiki.net.
Change-Id: I70994f4da0b20060281cf02e73295585edbc6445
2015-01-16 21:17:46 +01:00
Translation updater bot 1a1da10e69 Localisation updates from https://translatewiki.net.
Change-Id: I1f3eac902fcb1bede107951a26bdd1f9a3ff4f13
2015-01-15 22:47:11 +01:00
Translation updater bot 3d21abe511 Localisation updates from https://translatewiki.net.
Change-Id: If96219bacceb0f91cadb11fb9f89649877d7fd96
2015-01-12 22:37:09 +01:00
Translation updater bot 4db0c7ca94 Localisation updates from https://translatewiki.net.
Change-Id: Ic7b45d2662a107f8d91b4763cb5fa83f2b5a8346
2015-01-11 22:15:12 +01:00
Translation updater bot d2ed2faf13 Localisation updates from https://translatewiki.net.
Change-Id: I6a07d4d7edabddd52759dd2c06fde01b5d3fcc7f
2015-01-10 22:01:31 +01:00
Translation updater bot 8120175707 Localisation updates from https://translatewiki.net.
Change-Id: Ibc380b7f5b1a8221be330309d2eda43e050fff59
2015-01-09 22:07:42 +01:00
Amir E. Aharoni 91847e96c6 Fix the overlay chevron position for RTL
Bug: T78330
Change-Id: Ie438042bc24b8ace429eec68c8b75c09da56aa95
2015-01-09 17:50:51 +00:00
Amir E. Aharoni 94cb6103c2 Cleanup whitespace in modules/overlay/ext.echo.overlay.less
According to
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS

Change-Id: I361909fcea67fa5e0e3cbb69711ede91417c4e2e
2015-01-09 19:50:08 +02:00
Antoine Musso 7f5b0c1793 Fix EchoTitleLocalCacheTest::testGet corner case
EchoTitleLocalCache title cache resolution ends up querying the database
to resolve title id to Title object.

In some corner case, we might only have one page in the database (UTPage
as provided by MediaWikiTestCase), thus the id 2 would not resolve to a
Title breaking the test.

Use insertPage() to ensure we have a second page.

Bug: T78592
Change-Id: Ia9dbb256f566e489e1c81d89b6a6077831e07fc3
2015-01-09 13:54:08 +01:00