Commit graph

196 commits

Author SHA1 Message Date
jenkins-bot 6eee04f614 Merge "Fix layout of action buttons use display:flex" 2020-08-04 05:17:04 +00:00
Ed Sanders ee65e8b426 Remove text decoration on whole item widget when focused
Change-Id: I910b4cf3ef5503a4e38195cd588f327870e87d5e
2020-08-03 15:14:36 +01:00
Ed Sanders 5161a2c40e Fix layout of action buttons use display:flex
Bug: T258990
Change-Id: If0ece6e7ff6fef9abfcd4996a9158e86a5ffece0
2020-07-29 14:13:02 +01:00
Ed Sanders 6492fc380d Fix width of buttons-as-option-widgets
Change-Id: I7001815850a829a07c941e94548ea5a65d2fd1d5
2020-07-28 09:51:20 +00:00
Ed Sanders d43ceb8978 Merge in styles from Minerva
Drops some no-JS styles (.mw-echo-notification) which didn't do anything useful.

Bug: T258936
Change-Id: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
2020-07-27 23:19:51 +00:00
Ed Sanders eb0603c9af Fix layout of NotificationsInboxWidget on narrow screens
Bug: T258939
Change-Id: I17b968297baf630b71e832f6af0b0b534c9c08b4
2020-07-27 16:11:38 +01:00
Ed Sanders bc5b569719 Fix styling of action popup menu
* Fix icon position
* Fix border widths and colour

Change-Id: I06f45baa4c90e43d7e50eed83888d57ede69a517
2020-07-27 16:11:03 +01:00
Ed Sanders d22ca3b44c Fix popup font size in Minerva
Bug: T258937
Change-Id: I91ff2c49cfa7aa0805d7e0444c87599226c79291
2020-07-27 12:56:24 +01:00
jenkins-bot 34b8f1050e Merge "Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook" 2020-07-25 18:08:15 +00:00
jenkins-bot 833fcdfd1e Merge "Fix font size in monobook" 2020-07-25 00:00:11 +00:00
jenkins-bot 407e55dd00 Merge "Remove padding reset from markAllReadButton" 2020-07-24 23:59:51 +00:00
Ed Sanders 34c70f8501 Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook
Dummy icon is not position absolute in monobook, so hide it.

Change-Id: I24edfbc1afcb81da8ef4db6bb685792ee56bc49a
2020-07-24 23:31:45 +00:00
Ed Sanders 5b216bfad3 Fix font size in monobook
Content font size should be 12.7px and this can be achieved
by just applying the 127% from globalWrapper.

This matches the font sizes on Special:Notifications.

Change-Id: I5369231da52343029ea2cdbfc790296c2257807a
2020-07-24 23:31:35 +00:00
Ed Sanders 3ead305c27 Remove padding reset from markAllReadButton
Buttons should be positioned with margin, not padding,
as changing padding breaks hover and focus states.

In this case the position is already fine without
additional adjustment.

Change-Id: I8a7726b2e0988117084a1d0b060b4f649ba4cc75
2020-07-24 23:31:00 +00:00
Ed Sanders 2faa1fe512 Fix hover styles, remove link underline on special page
Change-Id: Ie144eed5295a8c8fa6239c28f7f2a15d493fd775
2020-07-24 20:34:43 +01:00
Ed Sanders ec87876f59 Set min-width on action buttons
Bug: T130109
Change-Id: I0a763aa7d73a84854daf43696d5751c58b3d067d
2020-07-23 18:19:34 +01:00
Ed Sanders e91e0c410b Simplify styling of notification bundles
Bug: T258714
Change-Id: Ia73fe2d2a96c070dacd8d9744242148ab4eca390
2020-07-23 18:19:34 +01:00
Ed Sanders 769d6579f9 Make MenuItemWidgets inherit from ButtonOptionWidgets
This gives them a consistent appearance with the expand/collapse
button. Only requires a small visual tweak to work in the popup
menu.

Bug: T258701
Bug: T258703
Change-Id: Ib3d074d1117e08d11136791354184e2e4b655290
2020-07-23 18:19:32 +01:00
Ed Sanders 3abe6b77bd Make mark as read/unread buttons properly focusable
Bug: T258710
Change-Id: I1ed9d386083d94bf6b5696bb71385169c0ccb807
2020-07-23 15:27:01 +01:00
Ed Sanders 42e2e5efbc Make NotificationItemWidget an <a> tag to fix focus issues
Bug: T258705
Change-Id: Ib44e04dd08e2818eb99ffb0cba73c775256d66d5
2020-07-23 15:27:01 +01:00
Ed Sanders d39d944bf0 Remove light background from dynamic-action hover state
Bug: T258703
Change-Id: I7b306b63c56da11ab7ce0492111f594f8b60593e
2020-07-23 14:02:34 +01:00
Roan Kattouw 7658e151d6 Fix positioning of the secondary actions menu
- Automatically flip the position if there's no room
- Always flip the position in bundled notifications
- Remove menuWidth and related hacks, they didn't work anyway
- Increase maximum label width a bit

Change-Id: I490a925b6265bfbb8bbedae11672fd19d4efba44
2020-06-03 04:41:13 +00:00
Volker E 9ee48977f1 Use '.text-overflow()' mixin from 'mediawiki.mixins'
And remove Echo's own mixin.

Depends-On: Ia8d6e7229b49598b0f4cb19dff463ffe2f11a43d
Change-Id: I68d5726f01484ef5b94a606de9669207944dff54
2020-04-23 18:16:01 -07:00
Volker E e85d881817 Replace static border radius value with var
In a distant future those might be replaced by core WikimediaUI Base
and this is a sane preparation for it.

Change-Id: I8907c8908f3b775be36b16a6782d7e9719e30c4c
2020-04-15 18:09:48 -07:00
Volker E 32c1c8e5f1 Amend Base10 color, add and amend WikimediaUI Base variables notation
Amending Base10 to slightly darker `#202122` to fulfill WCAG
requirements in connection to Accent50.
Also adding and amending WikimediaUI Base variables where in connection
with the color change.

Bug: T248393
Change-Id: I3b0c1666f7f883908a3778aa9e3fcbf51b57fefe
2020-04-15 18:02:21 -07:00
jdlrobson d7cc28fbcb Properly scoped style improvements to Echo OOUI dialog in desktop Minerva
This reverts commit ca5e5c85af and then
scopes the rules.

Bug: T241090
Bug: T242493
Change-Id: I0e6a4f6d235f34dc8f05a5e7ea5272d6465b80aa
2020-02-11 07:41:23 +08:00
Esanders ca5e5c85af Revert "Style improvements to Echo OOUI dialog in desktop Minerva"
This reverts commit 5b628b5109.

Bug: T241090
Bug: T242493
Change-Id: Id4a7ac9748ed7f934e9c47f4ade0c2f87da4488d
2020-02-10 20:24:17 +00:00
jdlrobson 5b628b5109 Style improvements to Echo OOUI dialog in desktop Minerva
* Make sure the badge for desktop when initialised points to the
right thing
* Make sure the dialog takes up the full screen and the Clippable bug
does not interfere with the display of the pane

Bug: T241090
Change-Id: I6c5588ee689633cef413ef27449aeeea341d7a97
2019-12-20 20:38:36 +00:00
Volker E 415b7b9851 hygiene: Make LESS imports non-ambigious
Some LESS parsers will get confused with the lack of file extension.
It's better to be explicit and in alignment with recent change in core
I379334d7729e587a2a00.
It was already weirdly mixed in this repo with some imports featuring
extension and some not.

Change-Id: Ib208607c850fa2492b13cd3d449c04ebc2c21a01
2019-10-25 13:53:39 -07:00
Isarra 0c0c0e596f MonoBook: Remove outdated skin styles and clean up some
Due to using ooui, and a lot of the styles being a lot more generic
in general these days for wider skin support, most of the skin
styles still included with Echo are no longer necessary or may even
be actively breaking things.

Remove a bunch of that, including some of the stuff for T226594 etc,
as we now have a more elegant solution in the skin itself.

Bug: T226684
Bug: T226594
Depends-On: I0ed21a78feb1b1298c30b969a1c80a4323e74043
Change-Id: Id3193a07f023eb0abc30fa24afe10da042fea876
2019-06-28 03:18:24 +00:00
Isarra 28dd2e0413 Modern: Remove outdated skin styles
Due to using ooui, and a lot of the styles being a lot more generic
in general these days for wider skin support, most of the skin
styles still included with Echo are no longer necessary or may even
be actively breaking things.

For Modern, basically just remove everything; nothing here seems to
apply anymore. Also frees us up to just fix the badge positioning
in the skin itself, and leave future maintenance up to the skin
maintainers, if anyone cares.

Bug: T226684
Change-Id: Id28bbc01b3b344dfeb39be1380a64c1368924289
2019-06-28 02:40:10 +00:00
Volker E c2dba98a9d build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I2789e3b93d1fc5743ea94b946fcd3e3ba8798e5e
2019-01-09 18:42:06 -08:00
Volker E b680244f8a Fix navigation controls wrapping on Notifications page
Fixing regression from a8ef5fe765c1.

Bug: T210487
Change-Id: I914b94515398d9fa388e8a8984b22f52e3507c86
2018-11-27 09:27:52 -08:00
Volker E d0d222cc3a Fix two layout regressions from OOUI ButtonSelectWidget change
Fix the regressions from being able to wrap items on narrow screens
in I2102f6d33979b. We don't want wrapping in affected cases.

Bug: T208930
Change-Id: I748d5b455bef15067205b49824386d2ab5dfdc07
2018-11-07 04:06:02 +00:00
Ed Sanders 0f7afb1e5d Convert SpecialHelpMenuWidget to a customised DropdownWidget
Replace the handle with a button widget.

Also remove the unused PendingElement mixin.

Bug: T178387
Change-Id: Iec3afea6c6a8fdb49e17750af7bada42b7ed4b70
2018-05-30 18:57:07 +01:00
jenkins-bot b926673987 Merge "Sticky toolbar: Add missing vendor prefix" 2018-04-30 22:56:43 +00:00
jenkins-bot 4538925597 Merge "Conditionally rearrange date and button in notif list" 2018-04-13 18:25:38 +00:00
Moriel Schottlender 8b84ed2a3b Conditionally rearrange date and button in notif list
When there isn't enough space for both date and button,
separate them each on its own line.

Bug: T146288
Change-Id: I7ad022da82503f35ae630d171faeed1815c97f7a
2018-03-28 16:19:47 +03:00
jenkins-bot 2cf4bd1df3 Merge "Align Notifications popup header/footer with OOUI's default size" 2018-03-27 21:03:38 +00:00
jenkins-bot bc511b4af2 Merge "NotificationsOptionWidget: Fix icon alignment" 2018-03-27 21:00:26 +00:00
Ed Sanders 0fd6d64a29 Fix DOM structure of mw.echo.ui.MenuItemWidget
* Inherit from DecoratedOptionWidget as it comes with
  an icon mixin.
* Keep the DOM structure as similar to its parent as
  possible, to avoid breaking upstream child selectors.
* To this end, replace <a> wrapping hack with override
  of getTagName to set this.$element to <a>.

Change-Id: Ifde70785a1bc996eb09e581b06ed30708323e9f7
2018-03-27 12:33:40 +01:00
Volker E 77021e370c Align Notifications popup header/footer with OOUI's default size
Bug: T190397
Change-Id: I41ad96bbc7d3922772ecb026cb251476882601c7
2018-03-26 20:13:08 -07:00
Volker E cc3df57d71 NotificationsOptionWidget: Fix icon alignment
Change-Id: Ieb5c9a8e378608e096e921fdb6795949a119c8a8
2018-03-26 02:15:36 -07:00
Ed Sanders 15a3443384 Use updated bell/tray icons from OOUI 0.26
As these are smaller canvases, fix positioning
hacks accordingly.

Change-Id: I472f8cdd5887243c3fd86ab1431532a99dba1ce9
2018-03-24 15:06:47 +00:00
Ed Sanders 17be84ec51 Sticky toolbar: Add missing vendor prefix
Change-Id: Ib1a68298295e7c0ae276a1cec92c5c67adb7b643
2018-02-04 21:26:06 +00:00
jenkins-bot e63b9f9ac0 Merge "Fix help menu icon placement for monobook" 2018-01-19 18:44:00 +00:00
jenkins-bot f321dc1250 Merge "Align the icon in the popup action sub menus" 2018-01-19 18:38:39 +00:00
jenkins-bot d0550c9f6c Merge "Truncate page name in the sidebar and organize into table view" 2018-01-18 11:43:47 +00:00
Volker E 4bb614b5fd Use “OOUI” as unified name for code comments
Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
2018-01-16 23:30:18 -08:00
Moriel Schottlender aecacd9443 Align the icon in the popup action sub menus
Also bring the icon rules up to a rule that actually
overrides ooui ruleset.

Bug: T185046
Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
2018-01-16 16:40:46 -08:00