Commit graph

740 commits

Author SHA1 Message Date
Erik Bernhardson d49b9a5223 Remove dead code
While writing tests i noticed that this is dead code that will never be called. It
was originally used but several commits have piled up to cause its deprecation.
Upon review of the git history it seems the general idea behind content-* turned
into the 'payload' key. the commentText formatting was moved to payload for future
use, the i18n keys have been pruned.

Change-Id: I5ef360759db53d54a834afc8b71e9c8807de0284
2013-05-13 18:11:42 -07:00
jenkins-bot ceba6083ad Merge "Add new EventLogging schema: EchoMail along with code refactor" 2013-05-14 00:48:21 +00:00
bsitu 40d962bf33 Fix notification listing query.
In some rare cases, an event with a bigger event_id may have a smaller timestamp,
in such cases, those records will not get pulled by the existing query, since
it's always filtered by <= notification_timestamp AND < event_id

Change-Id: I61620a9b93331814ad42253ca380a31301555cda
2013-05-13 17:21:31 -07:00
jenkins-bot 1eb9fa3b18 Merge "(bug 48302) Trailing dot in link is ignored in plain text email" 2013-05-13 23:26:51 +00:00
jenkins-bot c1b200aee7 Merge "Make Echo talk page notification rely on enotifusertalkpages" 2013-05-13 23:25:17 +00:00
jenkins-bot 9a2f91e18f Merge "(bug 48054) Echo API should use a standard continue parameter" 2013-05-13 23:23:04 +00:00
bsitu a0de3295a8 Make Echo talk page notification rely on enotifusertalkpages
Instead of introducing a brand new option for this notification, we just
use the existing enotifusertalkpages

Change-Id: Ia63c9b1f4f52007004fa2860115b675aae4872fa
2013-05-13 15:39:02 -07:00
bsitu 792dc034e0 (bug 48302) Trailing dot in link is ignored in plain text email
A random link may contain trailing dot and it doesn't get linked

Change-Id: Ia7d3a4a437438ba473c24b3f4f98bb133cd52954
2013-05-13 15:24:20 -07:00
Translation updater bot 4fa98c664d Localisation updates from http://translatewiki.net.
Change-Id: I92fa33797c1e175e0ff24632013f402601492c3d
2013-05-13 19:40:48 +00:00
Translation updater bot 5e9ac96fc0 Localisation updates from http://translatewiki.net.
Change-Id: I02eeef03b715282a1e9a12ac6b5d773b0445e809
2013-05-11 19:37:07 +00:00
jenkins-bot e2deb779d1 Merge "Mention notif has wrong anchor for header with link" 2013-05-10 21:41:55 +00:00
bsitu 557c2eb26f Mention notif has wrong anchor for header with link
Bug: 47999
Change-Id: Id295c1b4129b68e7a16db94bc32d0d1b65177012
2013-05-10 14:40:26 -07:00
bsitu 97e5e0a92b (bug 48304) Add 'Feedback' link to the Notifications flyout
Change-Id: I86e7b5e6762557743752e433a6e2a007596b1891
2013-05-09 16:13:38 -07:00
Translation updater bot d1c18d01df Localisation updates from http://translatewiki.net.
Change-Id: Ia29df4d27966705a1a2bc41a336025715c98f44b
2013-05-09 20:30:36 +00:00
Translation updater bot 39d39640c1 Localisation updates from http://translatewiki.net.
Change-Id: I148ce18afe3d1d5190201b4e65c55748bfc04a6f
2013-05-08 20:18:43 +00:00
bsitu ce78c973f3 Add new EventLogging schema: EchoMail along with code refactor
Change-Id: I7f9ec99d27b69abb14aa89540e424f1e0bcd8160
2013-05-07 16:59:24 -07:00
Translation updater bot 4134306e28 Localisation updates from http://translatewiki.net.
Change-Id: If0aac076c4426f3daaa765cd3b3dea2b5ac2b7d7
2013-05-07 20:16:37 +00:00
ebernhardson f6209be60a Disable unavailable notification checkboxes
Updates usage of HTMLCheckMatrix to match recent refactor allowing
options to be forced on or off.  Instead of hiding unavailable
checkboxes now we show them greyed out and unchangable. Depends on
https://gerrit.wikimedia.org/r/#/c/61163/ in core.
Bug: 47743

Change-Id: I9284a2ad29de654062e54a78a76c10dd49c35ed7
2013-05-07 10:25:35 -07:00
jenkins-bot bdb4038ceb Merge "(bug 47910) Minor edit should not trigger talk page notif" 2013-05-06 20:50:36 +00:00
Translation updater bot cc00b289a4 Localisation updates from http://translatewiki.net.
Change-Id: I878aa245dbb9ad0f71545f4b902bf13860ad6645
2013-05-06 20:20:24 +00:00
bsitu f47349e303 (bug 47910) Minor edit should not trigger talk page notif
This patch makes Echo talk page notification mimic the existing Orange Bar and Email talk page notification
for minor edit.

For the Orange Bar, minor edit notification is sent if the editor does not have nominornewtalk
permission.

There are additional rules for the email, minor edit notification is sent if global $wgEnotifMinorEdit
is true and notification recipient has enotifminoredits option on.

Change-Id: Ib3835c4dd57a3686b227c44710a14ab06cded166
2013-05-06 10:31:55 -07:00
jenkins-bot 3c5052c642 Merge "New logic for how Echo interacts with new message alerts (OBOD)" 2013-05-06 17:17:30 +00:00
kaldari e1e62e691c New logic for how Echo interacts with new message alerts (OBOD)
Previously Echo prevented all user_newtalk data from being generated
for logged in users. This broke the hasmsg API and also prevented
anyone from being able to implement client-side growlers or alerts
based on this data. The new approach is more conservative - it allows
updates to the user_newtalk table, but prevents the alert itself
(orange bar of doom) from being displayed to logged in users. This
will provide more flexibility for future development regarding talk
page alerts (both for extensions and gadgets).

Note: This change is dependant on the new core change I2105bdd2.

Bug: 47962
Change-Id: I3f35a56b3f1795c2b21a6e4af8fc93b5e61b7d3c
2013-05-06 10:13:14 -07:00
jenkins-bot a94b489842 Merge "Add extra security check to Echo API to prevent vandalism" 2013-05-06 11:05:24 +00:00
Translation updater bot baf9db723b Localisation updates from http://translatewiki.net.
Change-Id: Icc8cb3630eb560c3791c1e4e95582dbe79c9ea7d
2013-05-05 21:08:17 +00:00
bsitu c130197682 Add extra security check to Echo API to prevent vandalism
1. Only trigger mark as read if the unread notification count is > 0
1. Add a limit to the number of notification that can be marked as read
2. Only update those records with read_timestamp = null

Change-Id: I12456c504787f45f594ef9283e98d98692956935
2013-05-04 19:58:37 -07:00
Translation updater bot 82522e0573 Localisation updates from http://translatewiki.net.
Change-Id: Iaf855deb05e110c129e21b5ea3652dbcb5221998
2013-05-04 20:22:34 +00:00
bsitu 11aa91f1a0 Fix the maintenance script
It should wait for slave during each batch update

Change-Id: Iba8b172016317236981c11b4f9af9bb1723516ec
2013-05-03 18:52:05 -07:00
bsitu a70208e8fe (bug 48054) Echo API should use a standard continue parameter
Change-Id: I1d5333db4a4d58a1ecfa8dfe562cda5a35093f8b
2013-05-03 18:15:46 -07:00
Krenair 9e2b948b66 Do not send notifications for page links when the page is a redirect
Bug: 48045
Change-Id: Ib61574732bde3f7a8aeec4a33a379cc3d1aab60b
2013-05-03 17:31:23 +01:00
jenkins-bot 17ff356648 Merge "Temporary fix for bug 47954 - keep section link in edit summary" 2013-05-03 01:33:18 +00:00
kaldari 5671947f78 Temporary fix for bug 47954 - keep section link in edit summary
Since talk page edits don't necessary belong to a seciton (or may
involve several sections), we'll need to be more clever in the
DiscussionParser to extract it for the long term solution. This
temporary solution will expose any section link in the edit summary
payload so that people can jump straight to the section if they
want to (same as existing behavior in the archive version).

Bug: 47954
Change-Id: I2745ba194ba1f9b5b7c446588da6586e87d35b31
2013-05-02 17:18:48 -07:00
jenkins-bot 1a7485aa34 Merge "Add extra db slave wait to digest email cron" 2013-05-03 00:08:38 +00:00
jenkins-bot a4ee5ce444 Merge "(bug 48011) notlimit parameter does not accept "max" as a value" 2013-05-02 23:26:50 +00:00
bsitu 5df153591d Add extra db slave wait to digest email cron
Change-Id: Iaa5fc89750b2a4bbe5d52bb9e75c2ac90fc3304b
2013-05-02 14:12:40 -07:00
jenkins-bot 4c99cdd60e Merge "Update metric group for welcome/page-linked/user-rights notif" 2013-05-02 20:54:20 +00:00
Translation updater bot 0b39389232 Localisation updates from http://translatewiki.net.
Change-Id: Ib0ad916107f0d1ef25951c28a7f6e169180af886
2013-05-02 20:47:11 +00:00
kaldari 90912b76a7 Merge "Allow mention notifications from project pages" 2013-05-02 18:47:54 +00:00
Krenair b19be6c4ca Fix API in XML format
We weren't setting the XML tag name used for notifications, so this was causing a fatal error.

Bug: 48009
Change-Id: I676f7e7fee1167d02ed35920719105d3ca260e74
2013-05-02 11:44:36 -07:00
kaldari 6e9138d55a Allow mention notifications from project pages
(Such as Wikipedia:AN, Wikipedia:AN/I, Wikipedia:RfA, etc.)

Bug: 47964
Change-Id: If4e404b4fc8f4e16800f340f9a1050f66f663213
2013-05-02 18:06:51 +00:00
bsitu 1394e39b10 (bug 48011) notlimit parameter does not accept "max" as a value
Change-Id: I6bb7272b5a3df5fe9ccd3cf78a24769ca38a3f20
2013-05-02 10:56:46 -07:00
jenkins-bot 68248ccd7f Merge "Link to the notifications FAQ from Preferences" 2013-05-02 00:19:45 +00:00
Erik Bernhardson 113fe8cd84 Link to the notifications FAQ from Preferences
Bug: 47094
Change-Id: I22c420ff31e8b54ea306effedac42e029d29250e
2013-05-01 17:15:37 -07:00
bsitu 729cd1d370 Category and File links should be namespace escaped
Bug: 47924
Change-Id: I912e9d2a35ff956fe7604c719b6ba9d2c3d2fd6d
2013-05-01 16:24:39 -07:00
Translation updater bot c171da0179 Localisation updates from http://translatewiki.net.
Change-Id: I4a328f5bc9d8d1a561a7169f8653348c66f4d598
2013-05-01 20:34:34 +00:00
jenkins-bot ae4d295dc8 Merge "Making sure IP users get orange bar notificaitons" 2013-05-01 17:10:58 +00:00
kaldari f6f287f4a2 Making sure IP users get orange bar notificaitons
Change-Id: Iec38c8458fad43997239ef8aea87b1166a481bb7
2013-05-01 09:57:39 -07:00
bsitu c640ef179a Update metric group for welcome/page-linked/user-rights notif
Change-Id: Ida63587200f972b7b6ec0f826eb4f85ea274b20d
2013-04-30 16:02:55 -07:00
kaldari 03382b6b18 Merge "Bumping Echo config version number for analytics" 2013-04-30 22:31:08 +00:00
kaldari 509f7bccc3 Merge "Make sure footer links don't break in Chrome when zooming" 2013-04-30 22:30:39 +00:00