Thiemo Kreuz
611d1610dd
Simplify testDiscussionParser code
...
I found this code while looking for possibly problematic count()s.
I noticed the line "$user = $pageData['revisions'][0]…", which means
the code assumes element [0] is always there. Therefore I droped the
"count() == 1" check.
The other count() got replaced with an isset().
Change-Id: Ic582c85d07db0cbed56512e3e381120b628f2288
2018-10-25 19:23:07 +00:00
Thiemo Kreuz
8c51f5bd45
Avoid count()ing where not necessary
...
If all the code needs to know is if an array is empty or not, using
count() creates more confusion than anything.
Change-Id: I253308505fe5af5b5c56d85169789271967298ba
2018-10-19 10:04:24 +02:00
Kunal Mehta
aaf061c725
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
...
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ExtraParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: I8401abf121a7413fa191d7bc535e0ddd6cf8c3f7
2017-06-22 14:13:28 +00:00
James D. Forrester
8c810dff48
build: Update mediawiki/mediawiki-codesniffer to 0.7.1
...
Also added "composer fix" command.
Change-Id: I25cb61b3b92798f1259d1575a336e2b056d5764f
2016-12-05 15:54:30 -08:00
Justin Du
a0fe35a95d
Update Maintenance scripts to use $this->requireExtension()
...
* Also added $this->mDescription to removeInvalidNotification
Bug: T152139
Change-Id: I146405a3b6e81680b0ee1fb081486170d914a2b1
2016-12-05 15:54:30 -08:00
James D. Forrester
852ddaf903
build: Enable phpcs rule 'MediaWiki.Usage.DirUsage.FunctionFound' and make pass
...
Change-Id: I05c9299944a5a8e215ecb2996f1a3846e257e12c
2015-10-29 12:57:40 +01:00
James D. Forrester
becbea0941
build: Enable phpcs rule 'Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect' and make pass
...
Change-Id: I9379c18263474ed13921791b920c7b06e58a84ad
2015-10-29 12:56:33 +01:00
Reedy
adffeae19d
Move maintenance scripts to maintenance directory
...
Left fixme comment
Change-Id: I30207558d21bb73c6caa6dd722016bc51b257395
2013-04-22 22:52:21 +01:00
