wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-01 02:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
5587 commits 13 branches 19 tags 77 MiB
Commit graph

11 commits

Author SHA1 Message Date
Stephane Bisson 754338fe48 Convert PresentationModelSection from trait to class 
This trait was using private fields from its host classes
($this->event, $this->language). It created a weird coupling
situation where the host class uses the trait and the trait
uses the host class. Effectively a circular dependency.

Also, phan is complaining about it in
I65ae6adc10941c05a2646e551b1baa829e4e8654

Change-Id: Ib2796b7ca62ecd7ece19583d7ca83e4252a5d878
 2019-04-05 16:57:48 -04:00
Matthew Flaschen 24a055c946 Correct license to MIT 
This extension overall is under MIT, per Echo.php, extension.json,
and COPYING.

Change-Id: I39d533b671bb9eff3ba2e9faf5fcf482374b8e61
 2017-06-20 20:32:39 -04:00
jenkins-bot f19d9156a2 Merge "Fix counting of bundled mention notifications" 2017-05-03 10:53:54 +00:00
WMDE-Fisch 620855d770 Fix counting of bundled mention notifications 
This patch will fix the notification counts in bundled mention notification
messages. The former method did not work at all due to false assumptions
what the getBundleCount method can be used for.

Since this is in the presentation only wrong messages should be fixed when
deployed

Bug: T164115
Change-Id: If316549a090c2d281a8d612e4985fd556eabc807
 2017-05-03 10:40:40 +02:00
Stephane Bisson dd77a46c1b MentionStatus: prefer failure-type 
In MentionStatusPresentationModel, prefer
extra['failure-type'] to event-type to determine
why the mention was not sent.

Bug: T144614
Change-Id: Id3b55e15a0c1a8f3fee19cbe07983c6e373b309e
 2017-04-20 12:21:02 -04:00
James D. Forrester 8c810dff48 build: Update mediawiki/mediawiki-codesniffer to 0.7.1 
Also added "composer fix" command.

Change-Id: I25cb61b3b92798f1259d1575a336e2b056d5764f
 2016-12-05 15:54:30 -08:00
Sébastien Santoro ad0cf6cda0 Fix MentionStatusPresentationModel::getSecondaryLinks return value 
Any class implementing EchoEventPresentationModel and overriding the
getSecondaryLinks method should return an array (while getPrimaryLink
could return a false boolean value).

This change fixes the following errors:

Warning: array_values() expects parameter 1 to be an array or collection
in …/extensions/Echo/includes/formatters/EventPresentationModel.php on line 494

Warning: array_filter() expects parameter 1 to be an array or collection
in …/extensions/Echo/includes/formatters/EventPresentationModel.php on line 494

This is a follow-up for commit b4b59ee4.

Bug: T145229
Change-Id: Ic66ca03b6979472495c9b748093d01f8f097d56a
 2016-09-09 19:59:09 +00:00
Moriel Schottlender eb98b21dfe Add 'canRender' check to EchoMentionStatusPresentationModel 
Change-Id: Ica338ff5810b62849d30e5b27709558f1b797c43
 2016-09-06 14:44:51 -07:00
WMDE-Fisch 272cb9a960 Bundle mention success and failure notifications 
Adds common bundling including messages and icons.
Bundling relates to revision now.
Changed order how notifications are generated. Now errors will
show first, since they are generated last.

Bug: T140224
Change-Id: I1069aeb5523db8710da4e8e21065bf447d031e3c
 2016-08-13 08:08:12 +00:00
WMDE-Fisch b4b59ee485 Remove secondary link in bundled messages for mention status notifications 
Change-Id: I76de1626c77831b09fe3bb410d17ce354783076a
 2016-08-03 18:22:04 +00:00
WMDE-Fisch 78632108fd Echo notifications for successful mentions 
Adds new notification type and icon for successful mentions.
Complements existing test to consider successful mentions.

Bug: T139623
Change-Id: I7a77b40e8b14c95cadb9023065ee916247feacf9
 2016-08-01 13:40:55 +02:00
Renamed from includes/formatters/MentionFailurePresentationModel.php (Browse further)