Commit graph

3736 commits

Author SHA1 Message Date
jenkins-bot 3be48f6f2b Merge "Added a period to "Notification-header-reverted"." 2016-08-16 13:47:29 +00:00
Leszek Manicki 975be8fb45 Flip the parameter name and its type in phpdoc of MWEchoEventLogging
Also adds a type hint to MWEchoEventLogging::actuallyLogTheEvent
parameter.

Change-Id: I7538083ec33b5c4538386da22550273d8e882a72
2016-08-16 15:01:57 +02:00
Pmlineditor 98bf9d269d Added a period to "Notification-header-reverted".
Bug: T142917
Change-Id: I38679de5e3fe1142b6b1660c747a573670f16643
2016-08-16 18:30:47 +05:30
Leszek Manicki ab2bf21ce5 Check if logging is enabled before logging EchoInteraction
Adds a check before logging a visit to Special:Notifications
added in Icfe63fb8daa8e8fba029e22b4de3e4f65517c448

Bug: T143092
Change-Id: I9e58ba35eef6a25a78e96a76facc04819cef37da
2016-08-16 14:39:02 +02:00
jenkins-bot 8947629f52 Merge "Changing "this" to "these" because it refers to plural criteria (filters)" 2016-08-16 00:45:09 +00:00
Quiddity f2c59363c7 Changing "this" to "these" because it refers to plural criteria (filters)
Change-Id: Ie309ccf4a6c7a8817c8ba162c595ba3b2e33c69f
Bug: T143072
2016-08-16 00:36:24 +00:00
jenkins-bot 14da4e33f9 Merge "Log the mark entire cross-wiki bundle as read action" 2016-08-16 00:33:14 +00:00
jenkins-bot dc397a9ec4 Merge "Log Special:Notifications page visits" 2016-08-16 00:23:31 +00:00
Moriel Schottlender 5fefbe4b03 Add a rasterized email icons to Echo modules for email
Make sure we send rasterized png emails instead of SVGs in the
email formatter.

Bug: T127794
Change-Id: Ia28757bda521ec182f75458c8e52d54847d15681
2016-08-16 00:21:13 +00:00
Moriel Schottlender 879ff56756 Log the mark entire cross-wiki bundle as read action
Bug: T127955
Change-Id: Iddff3592915c1f7d71622c1137abc725985fb3c2
2016-08-15 17:18:27 -07:00
Moriel Schottlender 015acb5407 Log Special:Notifications page visits
Bug: T121939
Change-Id: Icfe63fb8daa8e8fba029e22b4de3e4f65517c448
2016-08-15 17:10:56 -07:00
Moriel Schottlender 951f146b54 Emit sortChange only for read/unread actions
Do not emit sortChange for toggleSeen, because every sortChange
creates a fake widget with a flipped 'read' state. There is no
reason to emit the sortChange event in toggleSeen anyways so it
is safer when only emitted in togglRead.

Also, make sure the controller always updates the correct seenTime
from the API when fetching local notifications. This was done for
the special page method but was overlooked for the fetching of local
notifications. For the most part, it shouldn't be affecting too much
because the SeenTimeModel is initialized with wgEchoSeenTime (which
is local) but updating the controller with the API response is the
safe thing to do, and will also cover cases where a tab was open,
notifications were seen in a different tab, and now the popup was
reopened in a "stale" tab again.

Bug: T143067
Change-Id: Ie261e32db28926d04fe14f7badd9d287ddc52749
2016-08-15 16:53:09 -07:00
Roan Kattouw e1a276fe3d Take seentime into account in the CheckLastModified hook
Bug: T134855
Change-Id: Iee5b0365eba6b7aa13a231e906ed1eb5338d436f
2016-08-15 16:41:44 -07:00
jenkins-bot 6eb2743dae Merge "Make footer notice link blue in Monobook" 2016-08-15 23:06:21 +00:00
jenkins-bot 4f06c04476 Merge "Remove noisy logging of every single thank-you-edit notification" 2016-08-15 22:14:29 +00:00
Roan Kattouw 3bc168589a Remove noisy logging of every single thank-you-edit notification
This was good when we were debugging the feature, but
it's working fine now.

Change-Id: I8267cd798625de32d653d836cbb84212909c702f
2016-08-15 22:07:24 +00:00
Translation updater bot 95271b75fd Localisation updates from https://translatewiki.net.
Change-Id: I12516fb1ad4a7a08a6c6b38d145d5f8b257c196d
2016-08-15 22:58:37 +02:00
Roan Kattouw 8016c9628b Follow-up 4e64643eb: Count pageless notifications when counting pageless notifications
Bug: T137502
Change-Id: I9e861cf97d0d8850dcbe732da496e34d434e4554
2016-08-15 11:35:28 -07:00
Roan Kattouw a4caed52cd Make footer notice link blue in Monobook
We have to override a CSS rule that tries to make all <a>s blue,
but not override it so powerfully that the real link in the footer
notice isn't blue.

Change-Id: I5a91419aab7cf6d6fe10c8e707168b52c2451cd8
2016-08-15 11:13:01 -07:00
Roan Kattouw 7b71d734e1 Tweak badge styles
Bug: T141923
Bug: T142454
Change-Id: Id82681369ffcb41b18ea408fc8bdc7fdd7d65ec6
2016-08-15 11:12:24 -07:00
WMDE-Fisch c81e1b93d2 Fix mention failures not beeing sent.
While manual rebasing the bundle patch the wrong
line was removed.

Also improves tests to check for notifyAgent.

See I1069aeb5523db8710da4e8e21065bf447d031e3c

Change-Id: I33ddeccea153d6f6ae97e5c60e8b47dc24fb4833
2016-08-15 14:25:22 +02:00
Translation updater bot 1113d0b0f7 Localisation updates from https://translatewiki.net.
Change-Id: I794922d4849269598eca32604646ce9fbc049544
2016-08-14 22:26:44 +02:00
Translation updater bot 2fb8318e8a Localisation updates from https://translatewiki.net.
Change-Id: I48092558f2dea2cf6fd22bdf9a6e769e0bd3d88b
2016-08-13 22:28:33 +02:00
WMDE-Fisch 272cb9a960 Bundle mention success and failure notifications
Adds common bundling including messages and icons.
Bundling relates to revision now.
Changed order how notifications are generated. Now errors will
show first, since they are generated last.

Bug: T140224
Change-Id: I1069aeb5523db8710da4e8e21065bf447d031e3c
2016-08-13 08:08:12 +00:00
Translation updater bot cc35d64a23 Localisation updates from https://translatewiki.net.
Change-Id: I90e632be3b0b05b3e223882a79e054c6bba82471
2016-08-12 23:10:37 +02:00
addshore b5f0c435ec DiscussionParser stripSig from mention content
This will allow us to:
 1) Fix a bug involving showing the sig in the snippets
    of mentions (Something catrope mentioned to me but
    I do not know of a bug number for it)
 2) Send more accurate sameUser failure metrics to
    graphite as signature links would never be counted
    as a mention

Change-Id: I33677012673ae6e4665aaaf59d4f350602f7276a
2016-08-12 19:43:03 +00:00
jenkins-bot cf3e03edc9 Merge "Revert "Allow self mentions"" 2016-08-12 01:48:03 +00:00
Mattflaschen 59568789fa Revert "Allow self mentions"
This reverts commit 0e23463185.

Change-Id: I4389c7b93b2bbc117931a263b58a8f1cc30dca6c
2016-08-12 01:41:08 +00:00
jenkins-bot 989c89f237 Merge "Fix typo (<strogn>) in Dutch message" 2016-08-11 23:29:57 +00:00
jenkins-bot 6886c18c03 Merge "Revert "Hack around browser bug in IE breaking badge alignment in Monobook"" 2016-08-11 23:27:25 +00:00
Roan Kattouw 94fbf213f6 Fix typo (<strogn>) in Dutch message
Change-Id: I41b2f75e41d0c2a772d03751e29f71818c2b6aaf
2016-08-11 16:21:23 -07:00
Catrope 092c4c64fb Revert "Hack around browser bug in IE breaking badge alignment in Monobook"
Seems to be fixed by different changes, and now this change
is causing trouble, moving the badges up off-screen.

This reverts commit 0b7f8712a9.

Change-Id: Ia5a0a6b6be3698436a043aee111f251709c22f20
2016-08-11 23:15:15 +00:00
jenkins-bot 97e8e3b6a6 Merge "Browser tests: update to mw-selenium 1.7.2 and https" 2016-08-11 22:09:57 +00:00
Translation updater bot b50d62f1ae Localisation updates from https://translatewiki.net.
Change-Id: Ib9b6343e9f8cdd83453f7da3d585dcd4fe1732a6
2016-08-11 23:52:53 +02:00
jenkins-bot ccab1d8351 Merge "Log 'mark all read' button click actions" 2016-08-11 20:58:31 +00:00
Stephane Bisson f3874126b9 Browser tests: update to mw-selenium 1.7.2 and https
Bug: T129483
Change-Id: Id33398d0615da77be0136f8680e56edc13f4e635
2016-08-11 15:47:42 -04:00
WMDE-Fisch f43ac383ae Add bold names for mentions status notifications
Bug: T140224
Change-Id: If4737a627c884f358bdc619849d6c9a8e6d20009
2016-08-11 12:14:12 +02:00
Translation updater bot c4121e7ff8 Localisation updates from https://translatewiki.net.
Change-Id: I63fbca1fe62787d665d5d1ce19238d2190e39b37
2016-08-10 22:36:13 +02:00
Translation updater bot 904ed1ceb4 Localisation updates from https://translatewiki.net.
Change-Id: I0140647c6bbfce3b90b6c75c22181dee9817a16e
2016-08-09 22:29:29 +02:00
jenkins-bot 0932060a9d Merge "Update to final version of the success and failure messages" 2016-08-08 20:58:49 +00:00
jenkins-bot 7ee4ffd1f4 Merge "Reduce the amount of space between the badges a bit" 2016-08-08 20:52:45 +00:00
Translation updater bot 5d5cb5bd94 Localisation updates from https://translatewiki.net.
Change-Id: I9a47ffa4a5e978a224c1bd2652bc3145ea1bdad1
2016-08-08 22:30:54 +02:00
jenkins-bot 515d38fb85 Merge "Follow-up de795bdbc5: actually hide badge number in Monobook" 2016-08-08 18:39:36 +00:00
WMDE-Fisch 839b9d8674 Update to final version of the success and failure messages
Bug: T140224
Change-Id: Ifda4a63069be78f60e68521369d024f4d45f03a4
2016-08-08 16:42:57 +02:00
Translation updater bot 793c5725ca Localisation updates from https://translatewiki.net.
Change-Id: I9e321f9cc8456fdbc3c93316b424a53bfd9291cb
2016-08-07 22:37:30 +02:00
jenkins-bot 96f11311b7 Merge "Don't truncate bundled item content in mobile view" 2016-08-06 04:58:18 +00:00
jenkins-bot 65d4368860 Merge "Round timestamps to the day when displaying date titles in Special:Notifications" 2016-08-06 04:49:21 +00:00
jenkins-bot 4c9944f1b0 Merge "Generate sample notifications for Wikibase" 2016-08-06 03:47:39 +00:00
Roan Kattouw 68479f7442 Reduce the amount of space between the badges a bit
What this really does is:
* Change the forced width of the <a> to the width of the icon
  (rather than 1.25x the width of the icon)
* Change the alignment of the :before from 40% to 50% so it
  stays in the middle (1.25*40=50)

Change-Id: I0399a20fc84e59fcbcf69da509a4d8bfa9b54a08
2016-08-05 18:01:48 -07:00
Roan Kattouw a27d748f6a Follow-up de795bdbc5: actually hide badge number in Monobook
The color: transparent; hack was being overridden by a color rule
that's only in effect after the popup is opened.

Change-Id: I2f415619603ccadb625ed2482c25fde78765fee4
2016-08-06 01:00:33 +00:00