Commit graph

7302 commits

Author SHA1 Message Date
Bartosz Dziewoński 88a5a4cbc6 Use namespaced MessageSpecifier
Depends-On: I9ff4ff7beb098b60c92f564591937c7d789c6684
Change-Id: I44aa53990bc11d24afa02399dc6dfec7d0c10b9a
2024-07-28 21:59:25 +02:00
jenkins-bot 777c649f96 Merge "Use overrideConfigValue/overrideConfigValues instead of setMwGlobals" 2024-07-28 13:45:00 +00:00
jenkins-bot d396f44ff8 Merge "Use expression builder instead of raw sql" 2024-07-26 18:29:36 +00:00
Fomafix e03f7c3e82 Use overrideConfigValue/overrideConfigValues instead of setMwGlobals
Also use MainConfigNames.

Change-Id: I80d6b3ef9d7b857e35d8f93f424db1cfca1301f6
2024-07-26 12:47:09 +00:00
Translation updater bot 4ae776fa5d
Localisation updates from https://translatewiki.net.
Change-Id: I4e068f563525d5eb802f0cdbf6bb80acff861f56
2024-07-26 09:44:38 +02:00
Translation updater bot 52c2037277
Localisation updates from https://translatewiki.net.
Change-Id: I59d04886203824b16b1173eff597212285ff2205
2024-07-25 09:18:53 +02:00
Dr4goniez 68aa29fb80 Fix type error caused by spread operator on number
`groupItems[ i ].id` is of type number, and using the spread operator
on it results in a type error. This prevented users from marking
multiple cross-wiki notifications as read, with the associated button.

Bug: T368643
Change-Id: I53d404445956de288aeda8fbfe1bdd1256214839
2024-07-24 15:45:54 +00:00
Translation updater bot 90bf6ae253
Localisation updates from https://translatewiki.net.
Change-Id: I26a0cc6e88c41e20ded14691547a220d85b9c307
2024-07-23 09:45:13 +02:00
Translation updater bot ebe56f8ebf
Localisation updates from https://translatewiki.net.
Change-Id: I1477a2b63a7e50197327aaf7c80f3a20d3e0b010
2024-07-22 09:24:26 +02:00
Umherirrender 552f362cd5 Use expression builder instead of raw sql
Change-Id: I6516951fc855dc32e864a3f21187b0a73daba7c8
2024-07-21 22:52:17 +02:00
Translation updater bot df36e81d3b
Localisation updates from https://translatewiki.net.
Change-Id: I94a717f9bc1bcbeb7a5b30b6515c043f674e879c
2024-07-19 09:40:06 +02:00
Translation updater bot e7e1ea5493
Localisation updates from https://translatewiki.net.
Change-Id: I81096fe42391f28085ef5a972833a5c64b642c89
2024-07-18 09:22:47 +02:00
Translation updater bot 967d5ee2e9
Localisation updates from https://translatewiki.net.
Change-Id: I691f404503f6eb2d4fcc97fed1e50ba8bd24cdf8
2024-07-17 09:33:32 +02:00
Translation updater bot 1c6a3c0c70
Localisation updates from https://translatewiki.net.
Change-Id: I7c22d6fe9ff30416cf9e2cd14d26c3bb87b509c8
2024-07-16 09:39:53 +02:00
Translation updater bot 4327920d7a
Localisation updates from https://translatewiki.net.
Change-Id: I532b9f3abb3dcad5fb3a96c31f71306e0b3d33aa
2024-07-15 09:23:53 +02:00
jenkins-bot 518a787b74 Merge "selenium: Document when, how and why a test is skipped" 2024-07-11 15:25:05 +00:00
Translation updater bot 0d0d17cb8e
Localisation updates from https://translatewiki.net.
Change-Id: I1138bfb4bfe71e47546ae0bc878c15bd8106dccc
2024-07-09 09:42:55 +02:00
Željko Filipin 78fe1911a4 selenium: Document when, how and why a test is skipped
Bug: T280652
Change-Id: I835e86ad663d77d2623637a06a27c7a90e007cb6
2024-07-08 15:17:13 +02:00
jenkins-bot bc08edbcbf Merge "Test:Replace db with getDb method" 2024-07-08 09:30:44 +00:00
Translation updater bot e0291b8b69
Localisation updates from https://translatewiki.net.
Change-Id: Ibe82a761a3584a1e5cb6ae08a00a6469ee342975
2024-07-08 09:32:48 +02:00
thiemowmde 7845b5fab1 Fix mistake in gender support for user group changes
This was a mistake in I53c0283, sorry. There are two users involved:
The "agent" is the user (typically an administrator) that made the
user group change, while the "viewing user" is the user for which the
user group was changed. When the "agent" moves the "viewing user"
into a new user group, the "viewing user" is the one that's now
a member of that group. They are what dictates the gender for the
"group-…-member" message.

Is this mistake bad enough for a backport?

Bug: T368249
Change-Id: I4916de2fb171873b625e51ee8823811e0296d323
2024-07-05 20:18:56 +02:00
Wandji69 633682d56d Test:Replace db with getDb method
Bug: T316841
Change-Id: Ia135648c0666632165bfbe29b6587e6676082d54
2024-07-05 17:08:51 +01:00
agamyasamuel 9b0010d25e fixed typo: exists -> exist
Bug: T368278
Change-Id: I19cbd5e599315b53dd3c00d0a515b86cddedd8ba
2024-07-04 03:17:13 +05:30
Translation updater bot 211e0fe90c
Localisation updates from https://translatewiki.net.
Change-Id: I78554d5ccbf66fb7de1a8d58b68ae1b6a2895b8b
2024-07-03 09:26:18 +02:00
Translation updater bot d6b52e777b
Localisation updates from https://translatewiki.net.
Change-Id: Ief5e2daab54055f6bd946394e4edb6ae5e88f654
2024-07-02 09:49:31 +02:00
jenkins-bot 73c2f5b2a1 Merge "Fix incomplete gender support for user group changes" 2024-07-01 08:02:31 +00:00
Translation updater bot 4b9042a6ed
Localisation updates from https://translatewiki.net.
Change-Id: I26905c9c51af21f563a3eda9011ca4d816e9bbfb
2024-07-01 09:25:12 +02:00
thiemowmde eaa1fea890 Fix incomplete gender support for user group changes
This affects primarily the message
"notification-header-user-rights-add-only" which is very priminently
seen by every new editor that made their first few edits and gets
promoted to the next user group a few days later. Turns out the code
was just incomplete. All the information about the user and their
gender is already there, it was just not forwarded correctly.

Notice there are two messages:
* "group-…" messages don't have gender support. This is the (ideally)
  gender neutral name of the group. Meant to be used as e.g. section
  heading for a list of users.
* "group-…-member" is the same with gender support. To be used in all
  contexts that are about a single, specific user with known gender.
  Which is exactly what's happening here.

Turns out we can even use a neat convenience function from the
Language class that does exactly what we need.

I can't tell why but the array_values is apparently critical.
Originally added via I49b5fe5. It can't hurt so I keep it.

Bug: T368249
Change-Id: I53c028375d77c93f399538fd38aa8f8af30934b0
2024-06-28 11:49:10 +02:00
Translation updater bot 8b9e747966
Localisation updates from https://translatewiki.net.
Change-Id: Ia681222080e3543a8e3102bd63a98b2be9a05f0d
2024-06-28 09:41:25 +02:00
jenkins-bot b6868dbe70 Merge "Don't hold reference to MediaWikiServices instance in tests" 2024-06-27 07:52:41 +00:00
Translation updater bot 9a857c8c16
Localisation updates from https://translatewiki.net.
Change-Id: I32129b7af0c8dd41adcab046c01e8af69dc4aa0d
2024-06-27 09:20:38 +02:00
thiemowmde c246f71eb6 Remove unused param from notification-bundle-header-page-linked
The duplicated parameter $6 is unused since 2016, see Iabeaae7.
Nothing is left that uses the parameter. I also checked for local
on-wiki overrides via GlobalSearch.

Bug: T368249
Change-Id: I8a5975347756f2fd5f5e065112ddc38d829e89ed
2024-06-26 13:20:05 +00:00
Ed Sanders b75056fe82 build: Update jsdoc-wmf-theme to 1.1.0
Bug: T368081
Change-Id: Iac00e54ddb5e31ed34da513abf70196437d151c9
2024-06-26 11:31:52 +01:00
thiemowmde e87cf704f4 Don't hold reference to MediaWikiServices instance in tests
There is no guarantee the MediaWikiServices instance is still valid.
Other tests can reset it.

Bug: T368390
Change-Id: I92de60b2ba5fb66af957a800ce85773db58303cc
2024-06-26 11:27:22 +02:00
Wandji69 231ce97335 Use ObjectCacheFactory instead of ObjectCache method
Bug: T363770
Change-Id: I685ee42b11fab3bb56810af65a1334573d16da8a
2024-06-26 10:19:13 +01:00
Translation updater bot 1ebe4aa8e4
Localisation updates from https://translatewiki.net.
Change-Id: Id3abbe5591fa40d304114c8b6c01015e0c67dac6
2024-06-26 09:21:21 +02:00
bwang 8e635e0bca Fix dark mode issues on Special:Notifications
Bug: T358405
Change-Id: I3c7e1c1884484386df9ef8f54d48af06e9a6c2d2
2024-06-25 19:18:52 +00:00
jenkins-bot 6bff6d7c00 Merge "Fix copy-paste mistake in message documentation" 2024-06-25 10:57:07 +00:00
Translation updater bot 9d2aaba76d
Localisation updates from https://translatewiki.net.
Change-Id: Ic67e0b2504f66722005264306b1302b5c2d01dd4
2024-06-25 09:30:07 +02:00
thiemowmde b983ce7581 Fix copy-paste mistake in message documentation
This is a copy-paste mistake from the message directly below.
Happened in Ibe0092a not long ago.

Also add some comments to make it easier to find the places where
seemingly unused messages end being used.

Bug: T368249
Change-Id: I709c0f14978daad8c98f1f8edf52ef28029c6d40
2024-06-24 09:07:19 +00:00
Translation updater bot cfaeca26cb
Localisation updates from https://translatewiki.net.
Change-Id: I25fc39567e161d58e7d6fa7b68bcd0958f8b22a7
2024-06-24 09:25:13 +02:00
Novem Linguae 323f99060e rename .jsdoc.json to jsdoc.json
Bug: T368082
Change-Id: Icfca32a997ddb0acb2cd24d138729eb610d16eee
2024-06-22 07:45:21 -07:00
jenkins-bot d360544b4f Merge "Replace "the user talk page of" with "the talk page of user"" 2024-06-22 11:51:07 +00:00
jenkins-bot a7d03e3517 Merge "Improve messages that talk about "users" that aren't users" 2024-06-22 11:47:41 +00:00
thiemowmde cc8caffd22 Improve messages that talk about "users" that aren't users
The main motivation here is to make these messages easier to
localize. The English versions aren't necessarily wrong, but a bit
ambiguous and hard to localize in languages like German where the
word "user" needs to be gendered.

Note these are error messages.

Change-Id: I76d58120e86730ee69216a87349b08f94e7b979e
2024-06-22 00:43:14 +02:00
thiemowmde 6af8bb017a Replace "the user talk page of" with "the talk page of user"
The main motivation here is to make this easier to localize. For
example, in German the word "user" needs to be gendered depending
on the user's preference. But the user name appears only much later
in the sentence, after "of". It appears like this can easily be
improved and even the original English message reads better then,
doesn't it?

Change-Id: I055481edbd572334bd2fffdcad9da67376ca5464
2024-06-22 00:27:30 +02:00
thiemowmde 12dc657c79 Simplify "my user talk page" to "my talk page"
I believe that saying "my talk page" is canon and really more than
enough. Even less confusing, especially when compared with the other
messages that talk about "my user page".

An additional motivation here is to make this easier to localize.
This turns out to be especially relevant in languages like German
where "user" needs to be gendered. We can avoid this here entirely.

Change-Id: I6588032d2b54e3729200c3342d668fc445f46312
2024-06-22 00:22:17 +02:00
jenkins-bot b818832d4e Merge "Adjust notification popup arrow in small screens" 2024-06-21 19:07:21 +00:00
Sergio Gimeno 1d0b6052e6 Adjust notification popup arrow in small screens
Use the max width breakpoint from wikimedia-ui-base
to add or remove popup container padding. That is
because the container has no padding in small
screens (when Vector's header breaks in two rows).

Bug: T366672
Change-Id: Idb0f844189cc221009cbb3e06c8c3fe0096bd0c2
2024-06-21 18:17:32 +02:00
Translation updater bot b970f614c2
Localisation updates from https://translatewiki.net.
Change-Id: I89195eae380143f8bac44d582862e2294445c146
2024-06-21 09:41:48 +02:00