so that we could skip parameters escaping when formatting email
subject. This is not a great solution but works for now.
Probably should re-think all the use case of echo formatting and
refactor the formatter
Change-Id: Ic1f6aa0f72d637558466db5cb2ee8d36038dd0b2
* cache function result in local variables
* Update the logic of generating notification date header
Change-Id: I04c3ed853076f17c819da8f27bfdb169e99b2a3a
This was supposed to merge master into the two_tabs branch, but it was accidently done against master instead
This reverts commit 06ee936e92.
Change-Id: I98da735b7d5c103399a2478286d1420243df6ba4
* Shared function can be put in the abstract class and this also enforces some interface methods
* Initialize a default dbFactory when it's not passed to the mapper
Change-Id: I1033dafaa90a1f683fbe9ad69bed04f4844e357b
In some cases like I7e309c04bc2456f4f87554a3d70dd6c77ba22f71 we
only have a raw URL and not a Title object. This supports that
usecase as well.
Change-Id: Ie18698e3ef755ca5a2cecc1f1cfb4254184bb576
* Get rid of EchoBackend by separating responsibilities into smaller objects
* Move main fetchNotification logic from API to a more appropriate place
* Add more unit testing coverage
Change-Id: I42f4d7566543332588431c21c220c0d64d026b70
We will likely need the very last record when building a bundle
notification in some cases ( talk page diff, flow unread post etc ),
it's better just to have that logic in a method
Change-Id: I8121e0cbed2beb066e27953d79225bb99c550553
General code cleanup as reported by the PHPStorm static code
analysis. I hope it's not a problem that I made a lot of very
different (but all very tiny) changes in a single patch. If you
want to merge this but you think it's better to split it into
several patches first, please tell me.
Change-Id: I2e2c4bb47f8d20e038d28e236e2ff813b30504af
In some cases, we need to add wgLang->getDir() for icon patch, but
wgLang is not yet fully initialized
Bug: 58705
Change-Id: I72fcb8e4cff9437d66ff9b60669701f572060389
Makes Doxygen think the whole function is deprecated,
switched them to "@param $var type deprecated"
Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818
If a user is mentioned in an area that does not have a section
title (for example, the lead section of a talk page), use the new
'notification-mention-nosection' message, to avoid an awkward and
incorrect "[[Page#|]]".
Bug: 52507
Change-Id: I40628b76c460c79008053222c9780bb23549731d
So we can link to multiple edits at once. This should not
change any existing behavior since 'prev' is used if nothing
is set.
Change-Id: If79e041d1443d8360abdf60b513ce8c7c0c7e1f8
bundleTitle['message'] defaults to empty string, it would never
be null, should just check if the string is empty
Change-Id: I6b9dd8b8a94fed114c0799004848daed472daf3a
Removing unused functions and declaring correct dependencies.
Targetting to desktop and mobile so it can be used by both.
Also removing dismiss-related code from the formatter.
Change-Id: Icccce64cfb3c564ab468a93ccdba9c5a61687fd5
Also making sure that footer has some amount of separation from
the notification title even if there is no payload.
Change-Id: I85a1a7989539044a0b0b53e76e70ddee9bb7165c
If the job queue is not enabled to process web and email notifications,
there may be a replication delay in brand new link-from-page
Change-Id: I6e36e3fd015a582f4e85709282bdb70033fd1776
In theory, a notification could not need any contextual information
so there's no reason we should make it required.
Now, if the title-params are not provided in the notifcation
definition, it just sets the value to an empty array.
Change-Id: Iba5ce5cc56010101c5e64976c95b37a215dc99fa
The reason I'm splitting this is that, not only do I want to create
a link to the 'title', but also for another param (in my case: link
to the AFTv5 permalink page)
Change-Id: I834b50ca144e7d08db830726480da19e1b406a27
To test the HTML email:
1. install the latest version of php-mail and php-mail-mime package, they are required
by the core sendmail function to send HTML email
2. set $wgAllowHTMLEmail = true before loading Echo in LocalSetting.php
Change-Id: Ia4b98b14e135742b84f1b0e04589b0efdd24e954
