Replaced all occurrences of "iconURL" in the extension's repo with
"iconUrl" after spotting a typo in `mw.echo.dm.NotificationItem.js#13`,
"iconUrl" (find the correct "iconURL" in `mw.echo.Controller.js#394` in
the diff). Thankfully the typo was only in the documentation block, but
given the casing of other config object properties like "primaryUrl"
and "secondaryUrl", it would be best to make them all consistent to
prevent any bug that could happen in the future.
Change-Id: I56e6a1d2c7695204b35e767679a27ee22b3fe4bc
@private usually means "cannot be used outside of this class". But
this is used. I assume it's meant to be @internal as in "internal to
this codebase".
Change-Id: I9326e17f706af336ea0d4b7c0af95330ed575810
Before this patch, middle-clicking notifications would still mark them
as read, but the user would only find out upon closing and re-opening
the notification tray or reloading the page.
Bug: T340179
Change-Id: Ic29af0c70354087cf5f783b5a7370241a86b4bf3
`groupItems[ i ].id` is of type number, and using the spread operator
on it results in a type error. This prevented users from marking
multiple cross-wiki notifications as read, with the associated button.
Bug: T368643
Change-Id: I53d404445956de288aeda8fbfe1bdd1256214839
Use the max width breakpoint from wikimedia-ui-base
to add or remove popup container padding. That is
because the container has no padding in small
screens (when Vector's header breaks in two rows).
Bug: T366672
Change-Id: Idb0f844189cc221009cbb3e06c8c3fe0096bd0c2
This was broken when replacing `$.extend` by `Object.assign` in
I1e603647c161bf940690f85f676edd7ebde7917d (commit 47ea647).
`Object.assign` fails when the first argument is `undefined`, but
`$.extend` doesn't.
Bug: T368029
Change-Id: I13025a783c7f4d173dce096efa47f659273f0dd5
This reduces the sidebar to 15em using flexbox when required. This
keeps the layout as columns just slightly longer, when compressing
which especially on vector-2022 will happen quite a bit.
This required making the lines in the optionwidget flex as well,
so that the ellipsis doesn't depend on a fixed value any more.
Bug: T337954
Change-Id: I8aadb1799da33161abc703344e9ab90bb747c604
- convert @cfg to @param
- in mw.echo.dm.NotificationItem.js, add backticks around
a block of code in a docblock so that it renders nicely
in the generated /docs/
Bug: T138401
Change-Id: If7df2ab72fa835af662a8f01cc0c5edb1cb79c2b
Compared to the previous approach using table layouts, it is much
easier to control which elements are allowed to extend to maximum
available width, and to provide alternative layouts for mobile.
There should be no visual changes.
It doesn't require using `white-space: nowrap` to prevent elements
from being squished, which will help with T237244.
(These styles are only loaded on Special:Notifications, they don't
apply to the flyout.)
Bug: T237244
Change-Id: I09e692e427f61fabd53b3824a1ed7e4f8e76fad4
According to my testing, rulesets wikimedia/client-es6
and wikimedia/server already contain the ruleset
wikimedia/jsdoc. So I don't think it needs to be declared
twice.
Bug: T365047
Change-Id: I5d7fef0c9594cc4c8765877aa6f783543e8a00ed
Allows users to send notifications to themselves (T306211). For sending
notifications to others, a new permission is created (echo-create),
assigned only to bots by default. For now, only one user can be notified
in one API request.
If the email flag is set in the API params, the notification is also
sent as an email, provided the user hasn't disabled email notifications
for the "api-triggered" category.
This feature is behind a feature flag. Set $wgEchoEnableApiEvents = true
to use.
Adapted from If0267a38be7d454e3d284d30f93c93a828288dd7.
Co-authored-by: TheresNoTime <starling-ctr@wikimedia.org>
Bug: T58362
Bug: T306211
Change-Id: I94642bff5dcb075cb9db862206d59c19edad9fd1
Adds support for the night-mode theme in Minerva by
adding the `.skin-invert` class to the mobile overlay content.
Bug: T356425
Change-Id: I5ccb486d7af798a9e3da83c28246dafb49b72443
This update of 'svgo' dependency includes three optimizations on
converting path commands, which
- improves closing paths and how we determine if to use absolute or
relative commands.
- round arc or convert to lines based on the geometric sagitta
- convert cubic Bézier curves to quadratic Bézier curves where possible
Bug: T354875
Change-Id: Ia2e8e947c7d10fa754885c8d917dc0616708fbaf
If you click "Expand" on a notification bundle, the list of individual
notifications appears below. The list has a thin band of whitespace
around it (with grey background). Clicking inside that whitespace,
outside of the list items, would activate the bundle's primary link,
even though the cursor state did not show that would happen.
Change-Id: Id8c60503fa45f61df5bfaa07e0184634a5263c61
Follow-up to 00d6928144. I simplified
the styles too much :( They worked for cross-wiki notifications, but
not regular bundled notifications. I didn't realize they were styled
differently…
* Add the border to bundled non-cross-wiki notifs
(this requires changes in SortedListWidget.js to add a wrapper)
* Hide the border until the list loads
* Remove unnecessary margin
Change-Id: I30c5bec11ddb49defa5957f0917f01057a3c21e7
