From f5e9d4e37277d8c4999a0f4a6294342d5f56b93b Mon Sep 17 00:00:00 2001
From: Stephane Bisson <sbisson@wikimedia.org>
Date: Fri, 13 May 2016 16:35:54 -0400
Subject: [PATCH] Log warning on failure to fetch foreign notifications

Change-Id: I92bc0ea2aebc1992d43dc0cd560137090b4d5857
---
 includes/api/ApiEchoNotifications.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/includes/api/ApiEchoNotifications.php b/includes/api/ApiEchoNotifications.php
index cd458ba08..cddcca0aa 100644
--- a/includes/api/ApiEchoNotifications.php
+++ b/includes/api/ApiEchoNotifications.php
@@ -1,5 +1,7 @@
 <?php
 
+use MediaWiki\Logger\LoggerFactory;
+
 class ApiEchoNotifications extends ApiQueryBase {
 	/**
 	 * @var EchoForeignNotifications
@@ -379,6 +381,14 @@ class ApiEchoNotifications extends ApiQueryBase {
 				if ( $parsed && isset( $parsed['query']['notifications'] ) ) {
 					$results[$wiki] = $parsed['query']['notifications'];
 				}
+			} else {
+				LoggerFactory::getInstance( 'Echo' )->warning(
+					"Failed to fetch notifications from {wiki}. Response: {response}",
+					array(
+						'wiki' => $wiki,
+						'response' => $response['response']['body'],
+					)
+				);
 			}
 		}