From ecb7eea8919f073a813e019eaea0a7f11344bd3c Mon Sep 17 00:00:00 2001 From: Func Date: Tue, 9 Jan 2024 18:54:50 +0000 Subject: [PATCH] Revert "Set a fixed default for echo-email-format" This reverts commit f305c2d77847e1a34bb7e77ea2a7cf55ae33c962. Reason for revert: This is not the way of setting the default user option, the 'default' param for HTMLForm should be filled with the user's current option. Similar mistakes happened many times, maybe we should deprecate setting this param for any field types other than the 'info' type at the preferences form level. Bug: T350530 Change-Id: I1d0fce3db4a4228a6adcd9fe12dbc3da7ac0f710 (cherry picked from commit 00f464e0fee1c8dfc083d79fa31cb5dbc96213e7) --- includes/Hooks.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/Hooks.php b/includes/Hooks.php index ed3dfa2f2..9b119ee41 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -317,7 +317,6 @@ class Hooks implements // Email format $preferences['echo-email-format'] = [ 'type' => 'select', - 'default' => EmailFormat::HTML, 'label-message' => 'echo-pref-email-format', 'section' => 'echo/emailsettings', 'options-messages' => [