wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-09-23 18:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.ScopeMissing' and make pass

Browse source 
Change-Id: I96b295bba43185085631722e10a5e5cfa7ecf27f
This commit is contained in:
James D. Forrester 2015-10-29 12:35:14 +01:00
parent 7f7e6b8159
commit eb4e17f15d
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/DataOutputFormatter.php
View file

@ -8,7 +8,7 @@ class EchoDataOutputFormatter {
/** /**
* @var array type => class * @var array type => class
*/ */
static $formatters = array( protected static $formatters = array(
'flyout' => 'EchoFlyoutFormatter' 'flyout' => 'EchoFlyoutFormatter'
); );

1
phpcs.xml
View file

@ -6,7 +6,6 @@
<exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/> <exclude name="MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix"/>
<exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/> <exclude name="MediaWiki.VariableAnalysis.UnusedGlobalVariables"/>
<exclude name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/> <exclude name="MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect"/>
<exclude name="PSR2.Classes.PropertyDeclaration.ScopeMissing"/>
<exclude name="PSR2.Classes.PropertyDeclaration.VarUsed"/> <exclude name="PSR2.Classes.PropertyDeclaration.VarUsed"/>
<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/> <exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
</rule> </rule>

2
tests/NotificationsTest.php
View file

@ -8,7 +8,9 @@
class NotificationsTest extends MediaWikiTestCase { class NotificationsTest extends MediaWikiTestCase {
/** @var User $sysop */ /** @var User $sysop */
// @codingStandardsIgnoreStart
var $sysop; var $sysop;
// @codingStandardsIgnoreEnd
public function setUp() { public function setUp() {
parent::setUp(); parent::setUp();