wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 09:40:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing strict "array" type hints to DiscussionParser

Browse source 
This patch adds a few strict type hints on the language level, not
only on the PHPDoc level as my other patches do.

Change-Id: Ie66f9ebf80317dcaf13e2e96a93332a1a93cebbe
This commit is contained in:
Thiemo Kreuz 2018-08-13 09:30:23 +02:00 committed by Umherirrender
parent 15b15adcb3
commit e5546e50b6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/DiscussionParser.php
View file

@ -639,7 +639,7 @@ abstract class EchoDiscussionParser {
* @param array $actions * @param array $actions
* @return array converted actions * @return array converted actions
*/ */
static function convertToUnknownSignedChanges( $signedSections, $actions ) { static function convertToUnknownSignedChanges( array $signedSections, array $actions ) {
return array_map( function ( $action ) use( $signedSections ) { return array_map( function ( $action ) use( $signedSections ) {
if ( if (
$action['type'] === 'unknown-change' && $action['type'] === 'unknown-change' &&
@ -657,7 +657,7 @@ abstract class EchoDiscussionParser {
}, $actions ); }, $actions );
} }
static function isInSignedSection( $line, $signedSections ) { static function isInSignedSection( $line, array $signedSections ) {
foreach ( $signedSections as $section ) { foreach ( $signedSections as $section ) {
if ( $line > $section[0] && $line <= $section[1] ) { if ( $line > $section[0] && $line <= $section[1] ) {
return true; return true;