From deb5057dc6570f9206ba7afdfeddaaa6f07ba1db Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 26 Oct 2018 12:41:49 -0700 Subject: [PATCH] Avoid use of IDatabase::update return value Change-Id: I7f3a0f169cfac9190b796b45aabb1b9cb7670a9d --- maintenance/backfillReadBundles.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/maintenance/backfillReadBundles.php b/maintenance/backfillReadBundles.php index fa7067d68..4a0161047 100644 --- a/maintenance/backfillReadBundles.php +++ b/maintenance/backfillReadBundles.php @@ -52,7 +52,7 @@ class BackfillReadBundles extends Maintenance { $displayHash = $row->notification_bundle_display_hash; $readTimestamp = $row->notification_read_timestamp; - $result = $dbw->update( + $dbw->update( 'echo_notification', [ 'notification_read_timestamp' => $readTimestamp ], [ @@ -63,10 +63,6 @@ class BackfillReadBundles extends Maintenance { ] ); - if ( !$result ) { - $this->output( "Failed to set read_timestamp on notifications with bundle_display_hash: $displayHash\n" ); - } - $processed += $dbw->affectedRows(); }