wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Make phan ignore JsonSerializable redefinition"

Browse source 
This reverts commit 13956265c1.

The Wikimedia CI jobs running phan were installing mediawiki development
dependencies which might overlap with the dependencies from the
extension. Ultimately phan failed with:

includes/RemoteSchema.php:9
PhanRedefinedInheritedInterface
\RemoteSchema inherits abstract Interface \JsonSerializable declared at
internal:0 which is also declared at
../../vendor/jakub-onderka/php-parallel-lint/src/JsonSerializable.php:4.
This may lead to confusing errors.

If7171a6d46473b0bb05e3adaeb40229e7881c2b6 adjusts the CI configuration
to no more install MediaWiki core development dependencies and solely
relies on mediawiki/vendor.git. That prevents the duplicate interface
definition.

Bug: T223397
Depends-On: If7171a6d46473b0bb05e3adaeb40229e7881c2b6
Change-Id: I794fbffe59104f138802bc6ded1a9d9a58ba9437
This commit is contained in:
Hashar 2019-05-20 15:24:11 +00:00 committed by Antoine Musso
parent 34612122e3
commit e3ae1a62d0
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/formatters/EventPresentationModel.php
View file

@ -7,7 +7,6 @@ use Wikimedia\Timestamp\TimestampException;
* Class that returns structured data based * Class that returns structured data based
* on the provided event. * on the provided event.
*/ */
// @phan-suppress-next-line PhanRedefinedInheritedInterface
abstract class EchoEventPresentationModel implements JsonSerializable { abstract class EchoEventPresentationModel implements JsonSerializable {
/** /**