wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing isset() check to ApiEchoUnreadNotificationPages

Browse source 
…::getUnreadNotificationPagesFromForeign().

I'm not 100% sure if this fixes the code in a way it is
supposed to work. However, I see that getFromForeign() is
called 3 times in existing code, and 2 of these places
already do an isset() check. It looks like it was just
forgotten here.

Even if there is another issue to fix here, this patch:
a) silences the error, and
b) gives us more useful debug output.

Bug: T273479
Change-Id: I257620f646196c0554b9d86c849a02f5a8b9519c
This commit is contained in:
Thiemo Kreuz 2021-02-02 08:57:44 +01:00 committed by Ammarpad
parent 5b032f5589
commit d8a4b6ba91
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/api/ApiEchoUnreadNotificationPages.php
View file

@ -171,8 +171,10 @@ class ApiEchoUnreadNotificationPages extends ApiQueryBase {
protected function getUnreadNotificationPagesFromForeign() { protected function getUnreadNotificationPagesFromForeign() {
$result = []; $result = [];
foreach ( $this->getFromForeign() as $wiki => $data ) { foreach ( $this->getFromForeign() as $wiki => $data ) {
if ( isset( $data['query'][$this->getModuleName()][$wiki] ) ) {
$result[$wiki] = $data['query'][$this->getModuleName()][$wiki]; $result[$wiki] = $data['query'][$this->getModuleName()][$wiki];
} }
}
return $result; return $result;
} }