wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-11 17:00:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

schema: Drop foreign keys from table echo_push_subscription

Browse source 
MediaWiki does not use foreign keys in the database schema

Additional changes to the schema:
- Mysql and sqlite creates index for each foreign keys, keep the index
  to allow fast joins with this columns by explicit statement on new
  wikis
- Explicit create statement for the UNIQUE index on column
  eps_token_sha256 to make the index more visible on the sql file
- Rename existing index to match the prefix for existing indexes

Bug: T306473
Change-Id: I4bd29a6d0f9515e1a678c2a967799b90ef22f7b9
This commit is contained in:
Umherirrender 2022-04-19 23:01:10 +02:00
parent 0a387990a5
commit d35c502b60
4 changed files with 50 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/Hooks.php
View file

@ -238,12 +238,16 @@ class Hooks implements RecentChange_saveHook {
// 1.35
$updater->addExtensionTable( 'echo_push_provider', "$dir/echo_push_provider.sql" );
$updater->addExtensionTable( 'echo_push_subscription', "$dir/echo_push_subscription.sql" );
// 1.36
$updater->addExtensionTable( 'echo_push_topic', "$dir/echo_push_topic.sql" );
// 1.35 - order of tables needed for declaring references
$updater->addExtensionTable( 'echo_push_subscription', "$dir/echo_push_subscription.sql" );
// 1.39
if ( $dbType === 'mysql' || $dbType === 'sqlite' ) {
$updater->modifyExtensionTable( 'echo_push_subscription',
"$dir/$dbType/patch-cleanup-push_subscription-foreign-keys-indexes.sql" );
}
global $wgEchoSharedTrackingCluster, $wgEchoSharedTrackingDB;
// Following tables should only be created if both cluster and database are false.

14
sql/echo_push_subscription.sql
View file

@ -7,7 +7,7 @@ CREATE TABLE /*_*/echo_push_subscription (
eps_token BLOB NOT NULL,
-- SHA256 digest of the push subscription token (to be used as a uniqueness constraint, since
-- the tokens themselves may be large)
eps_token_sha256 CHAR(64) NOT NULL UNIQUE,
eps_token_sha256 CHAR(64) NOT NULL,
-- push provider ID, expected to reference values 'fcm' or 'apns'
eps_provider TINYINT UNSIGNED NOT NULL,
-- last updated timestamp
@ -15,11 +15,11 @@ CREATE TABLE /*_*/echo_push_subscription (
-- push subscription metadata (e.g APNS notification topic)
eps_data BLOB,
-- APNS topic ID, references a row ID (ept_id) from echo_push_topic
eps_topic TINYINT UNSIGNED,
FOREIGN KEY (eps_provider) REFERENCES /*_*/echo_push_provider(epp_id),
FOREIGN KEY (eps_topic) REFERENCES /*_*/echo_push_topic(ept_id)
eps_topic TINYINT UNSIGNED
) /*$wgDBTableOptions*/;
CREATE INDEX /*i*/echo_push_subscription_user_id ON /*_*/echo_push_subscription (eps_user);
CREATE INDEX /*i*/echo_push_subscription_token ON /*_*/echo_push_subscription (eps_token(10));
CREATE UNIQUE INDEX /*i*/eps_token_sha256 ON /*_*/echo_push_subscription (eps_token_sha256);
CREATE INDEX /*i*/eps_provider ON /*_*/echo_push_subscription (eps_provider);
CREATE INDEX /*i*/eps_topic ON /*_*/echo_push_subscription (eps_topic);
CREATE INDEX /*i*/eps_user ON /*_*/echo_push_subscription (eps_user);
CREATE INDEX /*i*/eps_token ON /*_*/echo_push_subscription (eps_token(10));

10
sql/mysql/patch-cleanup-push_subscription-foreign-keys-indexes.sql Normal file
View file

@ -0,0 +1,10 @@
-- Drop foreign keys from echo_push_subscription - T306473
ALTER TABLE /*_*/echo_push_subscription DROP FOREIGN KEY IF EXISTS /*_*/echo_push_subscription_ibfk_1;
ALTER TABLE /*_*/echo_push_subscription DROP FOREIGN KEY IF EXISTS /*_*/echo_push_subscription_ibfk_2;
-- Rename index to match table prefix
DROP INDEX IF EXISTS /*i*/echo_push_subscription_user_id ON /*_*/echo_push_subscription;
CREATE INDEX IF NOT EXISTS /*i*/eps_user ON /*_*/echo_push_subscription (eps_user);
DROP INDEX IF EXISTS /*i*/echo_push_subscription_token ON /*_*/echo_push_subscription;
CREATE INDEX IF NOT EXISTS /*i*/eps_token ON /*_*/echo_push_subscription (eps_token(10));

27
sql/sqlite/patch-cleanup-push_subscription-foreign-keys-indexes.sql Normal file
View file

@ -0,0 +1,27 @@
-- Drop foreign keys from echo_push_subscription and rename index to match table prefix - T306473
DROP TABLE IF EXISTS /*_*/echo_push_subscription_tmp;
CREATE TABLE /*_*/echo_push_subscription_tmp (
eps_id INT UNSIGNED NOT NULL PRIMARY KEY auto_increment,
eps_user INT UNSIGNED NOT NULL,
eps_token BLOB NOT NULL,
eps_token_sha256 CHAR(64) NOT NULL,
eps_provider TINYINT UNSIGNED NOT NULL,
eps_updated TIMESTAMP NOT NULL,
eps_data BLOB,
eps_topic TINYINT UNSIGNED
) /*$wgDBTableOptions*/;
INSERT INTO /*_*/echo_push_subscription_tmp
SELECT eps_id, eps_user, eps_token, eps_token_sha256, eps_provider, eps_updated, eps_data, eps_topic
FROM /*_*/echo_push_subscription;
DROP TABLE /*_*/echo_push_subscription;
ALTER TABLE /*_*/echo_push_subscription_tmp RENAME TO /*_*/echo_push_subscription;
CREATE UNIQUE INDEX /*i*/eps_token_sha256 ON /*_*/echo_push_subscription (eps_token_sha256);
CREATE INDEX /*i*/eps_provider ON /*_*/echo_push_subscription (eps_provider);
CREATE INDEX /*i*/eps_topic ON /*_*/echo_push_subscription (eps_topic);
CREATE INDEX /*i*/eps_user ON /*_*/echo_push_subscription (eps_user);
CREATE INDEX /*i*/eps_token ON /*_*/echo_push_subscription (eps_token(10));