wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-23 15:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused param from notification-bundle-header-page-linked

Browse source 
The duplicated parameter $6 is unused since 2016, see Iabeaae7.
Nothing is left that uses the parameter. I also checked for local
on-wiki overrides via GlobalSearch.

Bug: T368249
Change-Id: I8a5975347756f2fd5f5e065112ddc38d829e89ed
This commit is contained in:
thiemowmde 2024-06-24 09:23:25 +02:00 committed by Thiemo Kreuz (WMDE)
parent b75056fe82
commit c246f71eb6
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
i18n/qqq.json
View file

@ -170,7 +170,7 @@
"notification-body-edit-user-talk-with-section": "{{optional}}\nFlyout-specific format for displaying notification body of a user talk page being edited with a new section or new comment.\n\nParameters:\n* $1 - comment left on the user talk page.", "notification-body-edit-user-talk-with-section": "{{optional}}\nFlyout-specific format for displaying notification body of a user talk page being edited with a new section or new comment.\n\nParameters:\n* $1 - comment left on the user talk page.",
"notification-header-page-linked": "Notification header message for articles being linked.\n\nParameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page being linked\n* $4 - the page linked from\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}", "notification-header-page-linked": "Notification header message for articles being linked.\n\nParameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page being linked\n* $4 - the page linked from\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}",
"notification-compact-header-page-linked": "Notification compact header message for articles being linked.\n\nParameters:\n* $1 - the page linked from.\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}", "notification-compact-header-page-linked": "Notification compact header message for articles being linked.\n\nParameters:\n* $1 - the page linked from.\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}",
"notification-bundle-header-page-linked": "Bundled message for page-linked notification. Parameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page title\n* $4 - the page linked from\n* $5 - The number of other pages that link to this page, except that if the count is greater than 99, this value will be 100; uses standard number formatting and used for PLURAL\n* $6 - Unused\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}\n{{Related|Notification-bundle}}", "notification-bundle-header-page-linked": "Bundled message for page-linked notification. Parameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page being linked\n* $4 - the page linked from\n* $5 - The number of other pages that link to this page, except that if the count is greater than 99, this value will be 100; uses standard number formatting and used for PLURAL\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}\n{{Related|Notification-bundle}}",
"notification-header-article-reminder": "Message for page-reminder notification. Parameters:\n* $1 - the formatted username of the user who requested the reminder. \n* $2 - the username for GENDER\n* $3 - the formatted page title of the article the user requested.", "notification-header-article-reminder": "Message for page-reminder notification. Parameters:\n* $1 - the formatted username of the user who requested the reminder. \n* $2 - the username for GENDER\n* $3 - the formatted page title of the article the user requested.",
"notification-link-text-what-links-here": "Label for link to the WhatLinksHere special page for the page being linked in this notification.", "notification-link-text-what-links-here": "Label for link to the WhatLinksHere special page for the page being linked in this notification.",
"notification-body-mention": "{{notranslate}}", "notification-body-mention": "{{notranslate}}",

4
includes/Formatters/EchoPageLinkedPresentationModel.php
View file

@ -128,9 +128,7 @@ class EchoPageLinkedPresentationModel extends EchoEventPresentationModel {
$msg->params( $this->getTruncatedTitleText( $this->getPageFrom(), true ) ); $msg->params( $this->getTruncatedTitleText( $this->getPageFrom(), true ) );
$count = $count =
$this->getNotificationCountForOutput( true, [ $this, 'getLinkedPageId' ] ); $this->getNotificationCountForOutput( true, [ $this, 'getLinkedPageId' ] );
$msg->numParams( $count );
// Repeat is B/C until unused parameter is removed from translations
$msg->numParams( $count, $count );
return $msg; return $msg;
} }