From c246f71eb64154998a40e75bffb982c65bf22c64 Mon Sep 17 00:00:00 2001 From: thiemowmde Date: Mon, 24 Jun 2024 09:23:25 +0200 Subject: [PATCH] Remove unused param from notification-bundle-header-page-linked The duplicated parameter $6 is unused since 2016, see Iabeaae7. Nothing is left that uses the parameter. I also checked for local on-wiki overrides via GlobalSearch. Bug: T368249 Change-Id: I8a5975347756f2fd5f5e065112ddc38d829e89ed --- i18n/qqq.json | 2 +- includes/Formatters/EchoPageLinkedPresentationModel.php | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/i18n/qqq.json b/i18n/qqq.json index f3c81367c..49e1c72c3 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -170,7 +170,7 @@ "notification-body-edit-user-talk-with-section": "{{optional}}\nFlyout-specific format for displaying notification body of a user talk page being edited with a new section or new comment.\n\nParameters:\n* $1 - comment left on the user talk page.", "notification-header-page-linked": "Notification header message for articles being linked.\n\nParameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page being linked\n* $4 - the page linked from\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}", "notification-compact-header-page-linked": "Notification compact header message for articles being linked.\n\nParameters:\n* $1 - the page linked from.\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}", - "notification-bundle-header-page-linked": "Bundled message for page-linked notification. Parameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page title\n* $4 - the page linked from\n* $5 - The number of other pages that link to this page, except that if the count is greater than 99, this value will be 100; uses standard number formatting and used for PLURAL\n* $6 - Unused\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}\n{{Related|Notification-bundle}}", + "notification-bundle-header-page-linked": "Bundled message for page-linked notification. Parameters:\n* $1 - the formatted username of the person who linked the page. \n* $2 - the username for GENDER\n* $3 - the page being linked\n* $4 - the page linked from\n* $5 - The number of other pages that link to this page, except that if the count is greater than 99, this value will be 100; uses standard number formatting and used for PLURAL\nSee also:\n* {{msg-mw|Notification-page-linked-email-subject}}\n{{Related|Notification-bundle}}", "notification-header-article-reminder": "Message for page-reminder notification. Parameters:\n* $1 - the formatted username of the user who requested the reminder. \n* $2 - the username for GENDER\n* $3 - the formatted page title of the article the user requested.", "notification-link-text-what-links-here": "Label for link to the WhatLinksHere special page for the page being linked in this notification.", "notification-body-mention": "{{notranslate}}", diff --git a/includes/Formatters/EchoPageLinkedPresentationModel.php b/includes/Formatters/EchoPageLinkedPresentationModel.php index 748b25437..9414269b6 100644 --- a/includes/Formatters/EchoPageLinkedPresentationModel.php +++ b/includes/Formatters/EchoPageLinkedPresentationModel.php @@ -128,9 +128,7 @@ class EchoPageLinkedPresentationModel extends EchoEventPresentationModel { $msg->params( $this->getTruncatedTitleText( $this->getPageFrom(), true ) ); $count = $this->getNotificationCountForOutput( true, [ $this, 'getLinkedPageId' ] ); - - // Repeat is B/C until unused parameter is removed from translations - $msg->numParams( $count, $count ); + $msg->numParams( $count ); return $msg; }