wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 16:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

EchoTargetPage: Don't call Title::newFromId() repeatedly

Browse source 
Title::newFromId() can return null, and if this were the case the
instance caching would never work, so it would continually make useless
database queries.

Initialize the $title member variable as false to begin with, and use
that to check whether we've already checked Title::newFromId().

Change-Id: Id07c2c963ffcd03e212bed0a666735bcb68b92e0
This commit is contained in:
Kunal Mehta 2016-03-07 15:56:00 -08:00 committed by Catrope
parent 93387806c2
commit b2961ccb0c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/model/TargetPage.php
View file

@ -13,9 +13,9 @@ class EchoTargetPage extends EchoAbstractEntity {
protected $user; protected $user;
/** /**
* @var Title|null * @var Title|null|bool false if not initialized yet
*/ */
protected $title; protected $title = false;
/** /**
* @var int * @var int
@ -107,7 +107,7 @@ class EchoTargetPage extends EchoAbstractEntity {
* @return Title|null * @return Title|null
*/ */
public function getTitle() { public function getTitle() {
if ( !$this->title ) { if ( $this->title === false ) {
$this->title = Title::newFromId( $this->pageId ); $this->title = Title::newFromId( $this->pageId );
} }